Re: Review Request 29942: Updates so client will run in PyCharm.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29942/#review68486 --- Ship it! This is now on origin/master: ``` $ git log -1 origin/master commit 056c35b169874023760edca4fcc222c1ad21d8b1 Author: Joshua Cohen jco...@twopensource.com Date: Thu Jan 15 11:49:53 2015 -0800 Updates so client will run in PyCharm. ``` - Bill Farner On Jan. 15, 2015, 11:58 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29942/ --- (Updated Jan. 15, 2015, 11:58 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- Updates so client will run in PyCharm. Diffs - docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd docs/images/debug-client-test.png PRE-CREATION docs/images/debugging-client-test.png PRE-CREATION examples/vagrant/clusters.json PRE-CREATION examples/vagrant/provision-dev-cluster.sh 7af4b52a6876268a97630279221bb98d9b04efad src/main/python/apache/aurora/client/cli/__init__.py a59594855bb82c1b4d1d28dfa2e1ac2d66aeb569 Diff: https://reviews.apache.org/r/29942/diff/ Testing --- Ran/debug client in PyCharm. Previewed markdown doc changes here: https://github.com/jcohen/incubator-aurora/blob/jcohen/client/run-in-pycharm/docs/developing-aurora-client.md Thanks, Joshua Cohen
Re: Review Request 29942: Updates so client will run in PyCharm.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29942/#review68328 --- Ship it! Since git maintenance is currently underway, i cannot commit this yet. Please bug me tomorrow if i have not yet committed (providing maintenance completes). - Bill Farner On Jan. 15, 2015, 7:56 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29942/ --- (Updated Jan. 15, 2015, 7:56 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- Updates so client will run in PyCharm. Diffs - docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd docs/images/debug-client-test.png PRE-CREATION docs/images/debugging-client-test.png PRE-CREATION examples/vagrant/clusters.json PRE-CREATION examples/vagrant/provision-dev-cluster.sh 7af4b52a6876268a97630279221bb98d9b04efad src/main/python/apache/aurora/client/cli/__init__.py a59594855bb82c1b4d1d28dfa2e1ac2d66aeb569 Diff: https://reviews.apache.org/r/29942/diff/ Testing --- Ran/debug client in PyCharm. Previewed markdown doc changes here: https://github.com/jcohen/incubator-aurora/blob/jcohen/client/run-in-pycharm/docs/developing-aurora-client.md Thanks, Joshua Cohen
Re: Review Request 29942: Updates so client will run in PyCharm.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29942/#review68345 --- This patch does not apply cleanly on master (1acb428), do you need to rebase? I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 15, 2015, 7:56 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29942/ --- (Updated Jan. 15, 2015, 7:56 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- Updates so client will run in PyCharm. Diffs - docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd docs/images/debug-client-test.png PRE-CREATION docs/images/debugging-client-test.png PRE-CREATION examples/vagrant/clusters.json PRE-CREATION examples/vagrant/provision-dev-cluster.sh 7af4b52a6876268a97630279221bb98d9b04efad src/main/python/apache/aurora/client/cli/__init__.py a59594855bb82c1b4d1d28dfa2e1ac2d66aeb569 Diff: https://reviews.apache.org/r/29942/diff/ Testing --- Ran/debug client in PyCharm. Previewed markdown doc changes here: https://github.com/jcohen/incubator-aurora/blob/jcohen/client/run-in-pycharm/docs/developing-aurora-client.md Thanks, Joshua Cohen
Re: Review Request 29942: Updates so client will run in PyCharm.
On Jan. 15, 2015, 11:59 p.m., Aurora ReviewBot wrote: This patch does not apply cleanly on master (b75ed0f), do you need to rebase? I will refresh this build result if you post a review containing @ReviewBot retry I don't know what your deal is ReviewBot, it applied cleanly for me! - Joshua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29942/#review68365 --- On Jan. 15, 2015, 11:58 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29942/ --- (Updated Jan. 15, 2015, 11:58 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- Updates so client will run in PyCharm. Diffs - docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd docs/images/debug-client-test.png PRE-CREATION docs/images/debugging-client-test.png PRE-CREATION examples/vagrant/clusters.json PRE-CREATION examples/vagrant/provision-dev-cluster.sh 7af4b52a6876268a97630279221bb98d9b04efad src/main/python/apache/aurora/client/cli/__init__.py a59594855bb82c1b4d1d28dfa2e1ac2d66aeb569 Diff: https://reviews.apache.org/r/29942/diff/ Testing --- Ran/debug client in PyCharm. Previewed markdown doc changes here: https://github.com/jcohen/incubator-aurora/blob/jcohen/client/run-in-pycharm/docs/developing-aurora-client.md Thanks, Joshua Cohen
Re: Review Request 29942: Updates so client will run in PyCharm.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29942/ --- (Updated Jan. 15, 2015, 11:58 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes --- rebase Repository: aurora Description --- Updates so client will run in PyCharm. Diffs (updated) - docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd docs/images/debug-client-test.png PRE-CREATION docs/images/debugging-client-test.png PRE-CREATION examples/vagrant/clusters.json PRE-CREATION examples/vagrant/provision-dev-cluster.sh 7af4b52a6876268a97630279221bb98d9b04efad src/main/python/apache/aurora/client/cli/__init__.py a59594855bb82c1b4d1d28dfa2e1ac2d66aeb569 Diff: https://reviews.apache.org/r/29942/diff/ Testing --- Ran/debug client in PyCharm. Previewed markdown doc changes here: https://github.com/jcohen/incubator-aurora/blob/jcohen/client/run-in-pycharm/docs/developing-aurora-client.md Thanks, Joshua Cohen
Re: Review Request 29942: Updates so client will run in PyCharm.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29942/#review68365 --- This patch does not apply cleanly on master (b75ed0f), do you need to rebase? I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 15, 2015, 11:58 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29942/ --- (Updated Jan. 15, 2015, 11:58 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- Updates so client will run in PyCharm. Diffs - docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd docs/images/debug-client-test.png PRE-CREATION docs/images/debugging-client-test.png PRE-CREATION examples/vagrant/clusters.json PRE-CREATION examples/vagrant/provision-dev-cluster.sh 7af4b52a6876268a97630279221bb98d9b04efad src/main/python/apache/aurora/client/cli/__init__.py a59594855bb82c1b4d1d28dfa2e1ac2d66aeb569 Diff: https://reviews.apache.org/r/29942/diff/ Testing --- Ran/debug client in PyCharm. Previewed markdown doc changes here: https://github.com/jcohen/incubator-aurora/blob/jcohen/client/run-in-pycharm/docs/developing-aurora-client.md Thanks, Joshua Cohen
Review Request 29942: Updates so client will run in PyCharm.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29942/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- Updates so client will run in PyCharm. Diffs - docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd docs/images/debug-client-test.png PRE-CREATION docs/images/debugging-client-test.png PRE-CREATION examples/vagrant/clusters.json PRE-CREATION examples/vagrant/provision-dev-cluster.sh 7af4b52a6876268a97630279221bb98d9b04efad src/main/python/apache/aurora/client/cli/__init__.py a59594855bb82c1b4d1d28dfa2e1ac2d66aeb569 Diff: https://reviews.apache.org/r/29942/diff/ Testing --- Ran/debug client in PyCharm. Previewed markdown doc changes here: https://github.com/jcohen/incubator-aurora/blob/jcohen/client/run-in-pycharm/docs/developing-aurora-client.md Thanks, Joshua Cohen
Re: Review Request 29942: Updates so client will run in PyCharm.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29942/#review68307 --- Ship it! Ship It! - Kevin Sweeney On Jan. 15, 2015, 11:56 a.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29942/ --- (Updated Jan. 15, 2015, 11:56 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- Updates so client will run in PyCharm. Diffs - docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd docs/images/debug-client-test.png PRE-CREATION docs/images/debugging-client-test.png PRE-CREATION examples/vagrant/clusters.json PRE-CREATION examples/vagrant/provision-dev-cluster.sh 7af4b52a6876268a97630279221bb98d9b04efad src/main/python/apache/aurora/client/cli/__init__.py a59594855bb82c1b4d1d28dfa2e1ac2d66aeb569 Diff: https://reviews.apache.org/r/29942/diff/ Testing --- Ran/debug client in PyCharm. Previewed markdown doc changes here: https://github.com/jcohen/incubator-aurora/blob/jcohen/client/run-in-pycharm/docs/developing-aurora-client.md Thanks, Joshua Cohen
