Re: Review Request 31451: Port thermos observer to the path detector interface

On March 1, 2015, 8:47 p.m., Joe Smith wrote: src/main/python/apache/aurora/executor/common/resource_manager.py, line 96 https://reviews.apache.org/r/31451/diff/6/?file=880982#file880982line96 Why is this moving to kwargs? (My normal assumption is to stick with actual arguments)

Re: Review Request 31451: Port thermos observer to the path detector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31451/#review75074 --- Ship it! Ship It! - Joe Smith On March 3, 2015, 2:58 p.m.,

Re: Review Request 31451: Port thermos observer to the path detector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31451/#review75078 --- Ship it! Master (2bf03dc) is green with this patch.

Re: Review Request 31451: Port thermos observer to the path detector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31451/ --- (Updated March 3, 2015, 10:58 p.m.) Review request for Aurora, Joe Smith and

Re: Review Request 31451: Port thermos observer to the path detector interface

On March 1, 2015, 12:47 p.m., Joe Smith wrote: src/test/python/apache/thermos/observer/test_detector.py, line 76 https://reviews.apache.org/r/31451/diff/6/?file=881004#file881004line76 I think it's worthy to make this (and others) explicitly: assert on_active.mock_calls

Re: Review Request 31451: Port thermos observer to the path detector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31451/#review75082 --- Ship it! Ship It! - Zameer Manji On March 3, 2015, 2:58 p.m.,

Re: Review Request 31451: Port thermos observer to the path detector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31451/#review74709 --- src/main/python/apache/aurora/executor/common/resource_manager.py

Re: Review Request 31451: Port thermos observer to the path detector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31451/#review74633 --- Ship it! Master (4cca6a6) is green with this patch.

Re: Review Request 31451: Port thermos observer to the path detector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31451/ --- (Updated Feb. 26, 2015, 7:46 p.m.) Review request for Aurora, Joe Smith and

Re: Review Request 31451: Port thermos observer to the path detector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31451/#review74354 --- Master (36af017) is red with this patch.

Re: Review Request 31451: Port thermos observer to the path detector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31451/#review74345 --- Ship it! Ship It! - Zameer Manji On Feb. 26, 2015, 11:46 a.m.,

Re: Review Request 31451: Port thermos observer to the path detector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31451/#review74384 --- Master (db99eb0) is red with this patch.

Re: Review Request 31451: Port thermos observer to the path detector interface

On Feb. 25, 2015, 5:44 p.m., Brian Wickman wrote: src/main/python/apache/thermos/observer/task_observer.py, line 592 https://reviews.apache.org/r/31451/diff/1/?file=877050#file877050line592 fix this. Brian Wickman wrote: You should definitely be concerned about the current