Re: Review Request 17131: Improve test coverage for CronJobManager.

2014-01-22 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17131/#review32516 --- Ship it! Ship It! - Suman Karumuri On Jan. 20, 2014, 9:01 p.m.,

Re: Review Request 17131: Improve test coverage for CronJobManager.

2014-01-22 Thread Bill Farner
On Jan. 21, 2014, 3:29 p.m., Suman Karumuri wrote: src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java, line 456 https://reviews.apache.org/r/17131/diff/1/?file=432900#file432900line456 The name CronJob sounds too generic. Consider changing it to

Re: Review Request 17131: Improve test coverage for CronJobManager.

2014-01-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17131/ --- (Updated Jan. 22, 2014, 7:02 p.m.) Review request for Aurora, Suman Karumuri

Re: Review Request 17131: Improve test coverage for CronJobManager.

2014-01-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17131/#review32376 --- Ship it!

Review Request 17131: Improve test coverage for CronJobManager.

2014-01-20 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17131/ --- Review request for Aurora, Suman Karumuri and Maxim Khutornenko. Bugs: