Re: Review Request 18296: Adding admin_client sla_list_safe_domain command.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18296/ --- (Updated Feb. 21, 2014, 4:30 p.m.) Review request for Aurora, Mark Chu-Carroll and Brian Wickman. Changes --- CR comments. Bugs: AURORA-208 https://issues.apache.org/jira/browse/AURORA-208 Repository: aurora Description --- Implemented admin_client sla_list_safe_domain command. Diffs (updated) - src/main/python/apache/aurora/client/api/__init__.py 0999b6f99bd74361663258cdae9d3920b3bb636f src/main/python/apache/aurora/client/api/sla.py b0b2b245951ea72d113ff2b3969c4d54024f73e7 src/main/python/apache/aurora/client/commands/admin.py 45686aec8d69f0dfa1d649a92a19ca87bd315823 src/test/python/apache/aurora/client/api/test_sla.py 2e6c8faf668182b497df59fe41b74af240459de7 src/test/python/apache/aurora/client/commands/BUILD 02c27aa513d60ef901f446c56cbfc0d891445e30 src/test/python/apache/aurora/client/commands/test_admin_sla.py PRE-CREATION src/test/python/apache/aurora/client/commands/util.py 11ae990c0d8e41470c6df438d37d8a2a79907a58 Diff: https://reviews.apache.org/r/18296/diff/ Testing --- ./pants src/test/python/apache/aurora/client:all Thanks, Maxim Khutornenko
Re: Review Request 18296: Adding admin_client sla_list_safe_domain command.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18296/#review35170 --- src/main/python/apache/aurora/client/api/sla.py https://reviews.apache.org/r/18296/#comment65589 Same comment as class below. src/main/python/apache/aurora/client/api/sla.py https://reviews.apache.org/r/18296/#comment65588 Minor stylistic nit: for a class, you should say what it is, for a method, what it does. So this would read better as A grouping of all active tasks by:... src/main/python/apache/aurora/client/api/sla.py https://reviews.apache.org/r/18296/#comment65590 Would help if this comment said a bit more - I don't know what the override map values mean. Can they arbitrarily change the limits in either direction? Or only make them stricter? - Mark Chu-Carroll On Feb. 21, 2014, 11:30 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18296/ --- (Updated Feb. 21, 2014, 11:30 a.m.) Review request for Aurora, Mark Chu-Carroll and Brian Wickman. Bugs: AURORA-208 https://issues.apache.org/jira/browse/AURORA-208 Repository: aurora Description --- Implemented admin_client sla_list_safe_domain command. Diffs - src/main/python/apache/aurora/client/api/__init__.py 0999b6f99bd74361663258cdae9d3920b3bb636f src/main/python/apache/aurora/client/api/sla.py b0b2b245951ea72d113ff2b3969c4d54024f73e7 src/main/python/apache/aurora/client/commands/admin.py 45686aec8d69f0dfa1d649a92a19ca87bd315823 src/test/python/apache/aurora/client/api/test_sla.py 2e6c8faf668182b497df59fe41b74af240459de7 src/test/python/apache/aurora/client/commands/BUILD 02c27aa513d60ef901f446c56cbfc0d891445e30 src/test/python/apache/aurora/client/commands/test_admin_sla.py PRE-CREATION src/test/python/apache/aurora/client/commands/util.py 11ae990c0d8e41470c6df438d37d8a2a79907a58 Diff: https://reviews.apache.org/r/18296/diff/ Testing --- ./pants src/test/python/apache/aurora/client:all Thanks, Maxim Khutornenko
Re: Review Request 18296: Adding admin_client sla_list_safe_domain command.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18296/#review35203 --- src/main/python/apache/aurora/client/api/sla.py https://reviews.apache.org/r/18296/#comment65654 it looks like this was never updated. safe_hosts[host] = safe_limits != self_hosts[host].append(safe_limits) do you mean .extend()? src/main/python/apache/aurora/client/api/sla.py https://reviews.apache.org/r/18296/#comment65655 it looks like this was never updated. safe_hosts[host] = safe_limits != self_hosts[host].append(safe_limits) do you mean .extend()? - Brian Wickman On Feb. 21, 2014, 7:49 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18296/ --- (Updated Feb. 21, 2014, 7:49 p.m.) Review request for Aurora, Mark Chu-Carroll and Brian Wickman. Bugs: AURORA-208 https://issues.apache.org/jira/browse/AURORA-208 Repository: aurora Description --- Implemented admin_client sla_list_safe_domain command. Diffs - src/main/python/apache/aurora/client/api/__init__.py 0999b6f99bd74361663258cdae9d3920b3bb636f src/main/python/apache/aurora/client/api/sla.py b0b2b245951ea72d113ff2b3969c4d54024f73e7 src/main/python/apache/aurora/client/commands/admin.py 45686aec8d69f0dfa1d649a92a19ca87bd315823 src/test/python/apache/aurora/client/api/test_sla.py 2e6c8faf668182b497df59fe41b74af240459de7 src/test/python/apache/aurora/client/commands/BUILD 02c27aa513d60ef901f446c56cbfc0d891445e30 src/test/python/apache/aurora/client/commands/test_admin_sla.py PRE-CREATION src/test/python/apache/aurora/client/commands/util.py 11ae990c0d8e41470c6df438d37d8a2a79907a58 Diff: https://reviews.apache.org/r/18296/diff/ Testing --- ./pants src/test/python/apache/aurora/client:all Thanks, Maxim Khutornenko
