Re: Review Request 18526: Add support for slaveHosts set in TaskQuery.

2014-02-28 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18526/#review35836 ---

Re: Review Request 18526: Add support for slaveHosts set in TaskQuery.

2014-02-28 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18526/#review35861 ---

Re: Review Request 18526: Add support for slaveHosts set in TaskQuery.

2014-02-28 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18526/ --- (Updated Feb. 28, 2014, 10:53 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 18526: Add support for slaveHosts set in TaskQuery.

2014-02-28 Thread Bill Farner
On Feb. 28, 2014, 10:53 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java, line 80 https://reviews.apache.org/r/18526/diff/3/?file=506631#file506631line80 That would create an empty SetIJobKey in case jobkey is missing

Re: Review Request 18526: Add support for slaveHosts set in TaskQuery.

2014-02-27 Thread Maxim Khutornenko
On Feb. 27, 2014, 1:38 a.m., Kevin Sweeney wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 364 https://reviews.apache.org/r/18526/diff/1/?file=504721#file504721line364 Mind adding a ticket number (filing one if it doesn't exist)? Added ticket tracking removal. -

Re: Review Request 18526: Add support for slaveHosts set in TaskQuery.

2014-02-27 Thread Bill Farner
On Feb. 27, 2014, 11:19 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java, line 76 https://reviews.apache.org/r/18526/diff/2/?file=506086#file506086line76 I know why you're doing this here, but mind keeping it out for now? Ignore

Re: Review Request 18526: Add support for slaveHosts set in TaskQuery.

2014-02-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18526/#review35723 ---

Re: Review Request 18526: Add support for slaveHosts set in TaskQuery.

2014-02-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18526/#review35729 ---

Re: Review Request 18526: Add support for slaveHosts set in TaskQuery.

2014-02-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18526/#review35738 --- src/main/java/org/apache/aurora/scheduler/base/Query.java

Re: Review Request 18526: Add support for slaveHosts set in TaskQuery.

2014-02-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18526/ --- (Updated Feb. 28, 2014, 1:18 a.m.) Review request for Aurora, Kevin Sweeney

Review Request 18526: Add support for slaveHosts set in TaskQuery.

2014-02-26 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18526/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-232