Re: Review Request 19061: Disable kill of production jobs without force flag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19061/ --- (Updated March 12, 2014, 2:12 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Changes --- Address reviews. Repository: aurora Description --- Disable kill of production jobs without force flag. Diffs (updated) - src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223 src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f Diff: https://reviews.apache.org/r/19061/diff/ Testing --- Added new test cases to the unit test for the kill command to cover the new cases. All tests, new and old, pass. [sun-wukong incubator-aurora (kill-force)]$ ./pants src/test/python/apache/aurora/client/commands:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/commands/BUILD:all)]) = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 13 items src/test/python/apache/aurora/client/commands/test_admin_sla.py . == 13 passed in 0.47 seconds == = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 26 items src/test/python/apache/aurora/client/commands/test_cancel_update.py .. src/test/python/apache/aurora/client/commands/test_create.py .. src/test/python/apache/aurora/client/commands/test_diff.py ... src/test/python/apache/aurora/client/commands/test_kill.py . src/test/python/apache/aurora/client/commands/test_listjobs.py .. src/test/python/apache/aurora/client/commands/test_restart.py ... src/test/python/apache/aurora/client/commands/test_status.py .. src/test/python/apache/aurora/client/commands/test_update.py ... == 26 passed in 1.35 seconds == = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/commands/test_maintenance.py == 4 passed in 0.43 seconds === = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_run.py . == 1 passed in 0.49 seconds === = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_ssh.py . == 1 passed in 0.54 seconds === src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 19061: Disable kill of production jobs without force flag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19061/ --- (Updated March 11, 2014, 3:42 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Changes --- fix headers. Summary (updated) - Disable kill of production jobs without force flag Repository: aurora Description (updated) --- Disable kill of production jobs without force flag. Diffs - src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223 src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f Diff: https://reviews.apache.org/r/19061/diff/ Testing --- Added new test cases to the unit test for the kill command to cover the new cases. All tests, new and old, pass. [sun-wukong incubator-aurora (kill-force)]$ ./pants src/test/python/apache/aurora/client/commands:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/commands/BUILD:all)]) = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 13 items src/test/python/apache/aurora/client/commands/test_admin_sla.py . == 13 passed in 0.47 seconds == = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 26 items src/test/python/apache/aurora/client/commands/test_cancel_update.py .. src/test/python/apache/aurora/client/commands/test_create.py .. src/test/python/apache/aurora/client/commands/test_diff.py ... src/test/python/apache/aurora/client/commands/test_kill.py . src/test/python/apache/aurora/client/commands/test_listjobs.py .. src/test/python/apache/aurora/client/commands/test_restart.py ... src/test/python/apache/aurora/client/commands/test_status.py .. src/test/python/apache/aurora/client/commands/test_update.py ... == 26 passed in 1.35 seconds == = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/commands/test_maintenance.py == 4 passed in 0.43 seconds === = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_run.py . == 1 passed in 0.49 seconds === = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_ssh.py . == 1 passed in 0.54 seconds === src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 19061: Disable kill of production jobs without force flag
On March 11, 2014, 3:46 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/commands/core.py, line 398 https://reviews.apache.org/r/19061/diff/1/?file=516614#file516614line398 This will fail if a kill is attempted for a job that does not exist. Wouldn't that result in an error, which would be caught by the check-and-log-result? - Mark --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19061/#review36829 --- On March 11, 2014, 3:42 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19061/ --- (Updated March 11, 2014, 3:42 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- Disable kill of production jobs without force flag. Diffs - src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223 src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f Diff: https://reviews.apache.org/r/19061/diff/ Testing --- Added new test cases to the unit test for the kill command to cover the new cases. All tests, new and old, pass. [sun-wukong incubator-aurora (kill-force)]$ ./pants src/test/python/apache/aurora/client/commands:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/commands/BUILD:all)]) = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 13 items src/test/python/apache/aurora/client/commands/test_admin_sla.py . == 13 passed in 0.47 seconds == = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 26 items src/test/python/apache/aurora/client/commands/test_cancel_update.py .. src/test/python/apache/aurora/client/commands/test_create.py .. src/test/python/apache/aurora/client/commands/test_diff.py ... src/test/python/apache/aurora/client/commands/test_kill.py . src/test/python/apache/aurora/client/commands/test_listjobs.py .. src/test/python/apache/aurora/client/commands/test_restart.py ... src/test/python/apache/aurora/client/commands/test_status.py .. src/test/python/apache/aurora/client/commands/test_update.py ... == 26 passed in 1.35 seconds == = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/commands/test_maintenance.py == 4 passed in 0.43 seconds === = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_run.py . == 1 passed in 0.49 seconds === = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_ssh.py . == 1 passed in 0.54 seconds === src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 19061: Disable kill of production jobs without force flag
On March 11, 2014, 7:46 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/commands/core.py, line 398 https://reviews.apache.org/r/19061/diff/1/?file=516614#file516614line398 This will fail if a kill is attempted for a job that does not exist. Mark Chu-Carroll wrote: Wouldn't that result in an error, which would be caught by the check-and-log-result? I don't see a that anywhere in the call chain. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19061/#review36829 --- On March 11, 2014, 7:42 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19061/ --- (Updated March 11, 2014, 7:42 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- Disable kill of production jobs without force flag. Diffs - src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223 src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f Diff: https://reviews.apache.org/r/19061/diff/ Testing --- Added new test cases to the unit test for the kill command to cover the new cases. All tests, new and old, pass. [sun-wukong incubator-aurora (kill-force)]$ ./pants src/test/python/apache/aurora/client/commands:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/commands/BUILD:all)]) = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 13 items src/test/python/apache/aurora/client/commands/test_admin_sla.py . == 13 passed in 0.47 seconds == = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 26 items src/test/python/apache/aurora/client/commands/test_cancel_update.py .. src/test/python/apache/aurora/client/commands/test_create.py .. src/test/python/apache/aurora/client/commands/test_diff.py ... src/test/python/apache/aurora/client/commands/test_kill.py . src/test/python/apache/aurora/client/commands/test_listjobs.py .. src/test/python/apache/aurora/client/commands/test_restart.py ... src/test/python/apache/aurora/client/commands/test_status.py .. src/test/python/apache/aurora/client/commands/test_update.py ... == 26 passed in 1.35 seconds == = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/commands/test_maintenance.py == 4 passed in 0.43 seconds === = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_run.py . == 1 passed in 0.49 seconds === = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_ssh.py . == 1 passed in 0.54 seconds === src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 19061: Disable kill of production jobs without force flag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19061/#review36833 --- src/main/python/apache/aurora/client/commands/core.py https://reviews.apache.org/r/19061/#comment68020 This needs to check the error code. It also needs to check that tasks is non-empty (it could be if job_key refers to a cron job that isn't currently running). src/main/python/apache/aurora/client/commands/core.py https://reviews.apache.org/r/19061/#comment68018 Make this error more explicit - i.e. all instances will be killed. Bonus points for something like ALL len(tasks) will be killed. src/test/python/apache/aurora/client/commands/test_kill.py https://reviews.apache.org/r/19061/#comment68021 kill extra whitespace here and everywhere else - Kevin Sweeney On March 11, 2014, 12:42 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19061/ --- (Updated March 11, 2014, 12:42 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- Disable kill of production jobs without force flag. Diffs - src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223 src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f Diff: https://reviews.apache.org/r/19061/diff/ Testing --- Added new test cases to the unit test for the kill command to cover the new cases. All tests, new and old, pass. [sun-wukong incubator-aurora (kill-force)]$ ./pants src/test/python/apache/aurora/client/commands:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/commands/BUILD:all)]) = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 13 items src/test/python/apache/aurora/client/commands/test_admin_sla.py . == 13 passed in 0.47 seconds == = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 26 items src/test/python/apache/aurora/client/commands/test_cancel_update.py .. src/test/python/apache/aurora/client/commands/test_create.py .. src/test/python/apache/aurora/client/commands/test_diff.py ... src/test/python/apache/aurora/client/commands/test_kill.py . src/test/python/apache/aurora/client/commands/test_listjobs.py .. src/test/python/apache/aurora/client/commands/test_restart.py ... src/test/python/apache/aurora/client/commands/test_status.py .. src/test/python/apache/aurora/client/commands/test_update.py ... == 26 passed in 1.35 seconds == = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/commands/test_maintenance.py == 4 passed in 0.43 seconds === = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_run.py . == 1 passed in 0.49 seconds === = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_ssh.py . == 1 passed in 0.54 seconds === src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 19061: Disable kill of production jobs without force flag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19061/ --- (Updated March 11, 2014, 4:03 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Changes --- fix glitches found by reviewers. Repository: aurora Description --- Disable kill of production jobs without force flag. Diffs (updated) - src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223 src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f Diff: https://reviews.apache.org/r/19061/diff/ Testing --- Added new test cases to the unit test for the kill command to cover the new cases. All tests, new and old, pass. [sun-wukong incubator-aurora (kill-force)]$ ./pants src/test/python/apache/aurora/client/commands:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/commands/BUILD:all)]) = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 13 items src/test/python/apache/aurora/client/commands/test_admin_sla.py . == 13 passed in 0.47 seconds == = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 26 items src/test/python/apache/aurora/client/commands/test_cancel_update.py .. src/test/python/apache/aurora/client/commands/test_create.py .. src/test/python/apache/aurora/client/commands/test_diff.py ... src/test/python/apache/aurora/client/commands/test_kill.py . src/test/python/apache/aurora/client/commands/test_listjobs.py .. src/test/python/apache/aurora/client/commands/test_restart.py ... src/test/python/apache/aurora/client/commands/test_status.py .. src/test/python/apache/aurora/client/commands/test_update.py ... == 26 passed in 1.35 seconds == = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/commands/test_maintenance.py == 4 passed in 0.43 seconds === = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_run.py . == 1 passed in 0.49 seconds === = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_ssh.py . == 1 passed in 0.54 seconds === src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 19061: Disable kill of production jobs without force flag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19061/#review36836 --- src/main/python/apache/aurora/client/commands/core.py https://reviews.apache.org/r/19061/#comment68024 Actually not even this is sufficient. Due to a quirk in the query API, the responseCode is set to INVALID_REQUEST when the result set is empty (which will cause a die here). - Kevin Sweeney On March 11, 2014, 1:03 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19061/ --- (Updated March 11, 2014, 1:03 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- Disable kill of production jobs without force flag. Diffs - src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223 src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f Diff: https://reviews.apache.org/r/19061/diff/ Testing --- Added new test cases to the unit test for the kill command to cover the new cases. All tests, new and old, pass. [sun-wukong incubator-aurora (kill-force)]$ ./pants src/test/python/apache/aurora/client/commands:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/commands/BUILD:all)]) = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 13 items src/test/python/apache/aurora/client/commands/test_admin_sla.py . == 13 passed in 0.47 seconds == = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 26 items src/test/python/apache/aurora/client/commands/test_cancel_update.py .. src/test/python/apache/aurora/client/commands/test_create.py .. src/test/python/apache/aurora/client/commands/test_diff.py ... src/test/python/apache/aurora/client/commands/test_kill.py . src/test/python/apache/aurora/client/commands/test_listjobs.py .. src/test/python/apache/aurora/client/commands/test_restart.py ... src/test/python/apache/aurora/client/commands/test_status.py .. src/test/python/apache/aurora/client/commands/test_update.py ... == 26 passed in 1.35 seconds == = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/commands/test_maintenance.py == 4 passed in 0.43 seconds === = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_run.py . == 1 passed in 0.49 seconds === = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_ssh.py . == 1 passed in 0.54 seconds === src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 19061: Disable kill of production jobs without force flag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19061/#review36876 --- src/main/python/apache/aurora/client/commands/core.py https://reviews.apache.org/r/19061/#comment68069 exit 0? Or should we have a special code here for job did not exist. I think for backwards compatibility this would be an error code. src/main/python/apache/aurora/client/commands/core.py https://reviews.apache.org/r/19061/#comment68070 s/tasks/instances/ src/main/python/apache/aurora/client/commands/core.py https://reviews.apache.org/r/19061/#comment68071 There's no precedent for this in other parts of the client and this destroys the ability to sanely script the client. I'd support prompting by default but if the user has passed --force I don't think we should prompt. - Kevin Sweeney On March 11, 2014, 3:23 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19061/ --- (Updated March 11, 2014, 3:23 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- Disable kill of production jobs without force flag. Diffs - src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223 src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f Diff: https://reviews.apache.org/r/19061/diff/ Testing --- Added new test cases to the unit test for the kill command to cover the new cases. All tests, new and old, pass. [sun-wukong incubator-aurora (kill-force)]$ ./pants src/test/python/apache/aurora/client/commands:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/commands/BUILD:all)]) = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 13 items src/test/python/apache/aurora/client/commands/test_admin_sla.py . == 13 passed in 0.47 seconds == = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 26 items src/test/python/apache/aurora/client/commands/test_cancel_update.py .. src/test/python/apache/aurora/client/commands/test_create.py .. src/test/python/apache/aurora/client/commands/test_diff.py ... src/test/python/apache/aurora/client/commands/test_kill.py . src/test/python/apache/aurora/client/commands/test_listjobs.py .. src/test/python/apache/aurora/client/commands/test_restart.py ... src/test/python/apache/aurora/client/commands/test_status.py .. src/test/python/apache/aurora/client/commands/test_update.py ... == 26 passed in 1.35 seconds == = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/commands/test_maintenance.py == 4 passed in 0.43 seconds === = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_run.py . == 1 passed in 0.49 seconds === = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_ssh.py . == 1 passed in 0.54 seconds === src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 19061: Disable kill of production jobs without force flag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19061/#review36892 --- src/main/python/apache/aurora/client/commands/core.py https://reviews.apache.org/r/19061/#comment68082 +1. The idea here is to make scripting of production job kills harder and it achieves just that despite its ugliness. - Maxim Khutornenko On March 11, 2014, 10:23 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19061/ --- (Updated March 11, 2014, 10:23 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- Disable kill of production jobs without force flag. Diffs - src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223 src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f Diff: https://reviews.apache.org/r/19061/diff/ Testing --- Added new test cases to the unit test for the kill command to cover the new cases. All tests, new and old, pass. [sun-wukong incubator-aurora (kill-force)]$ ./pants src/test/python/apache/aurora/client/commands:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/commands/BUILD:all)]) = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 13 items src/test/python/apache/aurora/client/commands/test_admin_sla.py . == 13 passed in 0.47 seconds == = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 26 items src/test/python/apache/aurora/client/commands/test_cancel_update.py .. src/test/python/apache/aurora/client/commands/test_create.py .. src/test/python/apache/aurora/client/commands/test_diff.py ... src/test/python/apache/aurora/client/commands/test_kill.py . src/test/python/apache/aurora/client/commands/test_listjobs.py .. src/test/python/apache/aurora/client/commands/test_restart.py ... src/test/python/apache/aurora/client/commands/test_status.py .. src/test/python/apache/aurora/client/commands/test_update.py ... == 26 passed in 1.35 seconds == = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/commands/test_maintenance.py == 4 passed in 0.43 seconds === = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_run.py . == 1 passed in 0.49 seconds === = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_ssh.py . == 1 passed in 0.54 seconds === src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 19061: Disable kill of production jobs without force flag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19061/#review36877 --- src/main/python/apache/aurora/client/commands/core.py https://reviews.apache.org/r/19061/#comment68072 return 0 is equivalent to exit 0. App commands use the return value of the function as the exit code if it's numeric. Today, if the user calls kill on a command that doesn't exist, they don't get an error exit, so I didn't want to change that. src/main/python/apache/aurora/client/commands/core.py https://reviews.apache.org/r/19061/#comment68073 Chris IMed me and asked me to add it. I'm not a huge fan, but he insisted :-). In terms of scripting, I think this is a feature. Killing a production service is something that we want to discourage - saying that you can't do it from a script, and can only do it explicitly is a good thing. - Mark Chu-Carroll On March 11, 2014, 6:23 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19061/ --- (Updated March 11, 2014, 6:23 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- Disable kill of production jobs without force flag. Diffs - src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223 src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f Diff: https://reviews.apache.org/r/19061/diff/ Testing --- Added new test cases to the unit test for the kill command to cover the new cases. All tests, new and old, pass. [sun-wukong incubator-aurora (kill-force)]$ ./pants src/test/python/apache/aurora/client/commands:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/commands/BUILD:all)]) = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 13 items src/test/python/apache/aurora/client/commands/test_admin_sla.py . == 13 passed in 0.47 seconds == = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 26 items src/test/python/apache/aurora/client/commands/test_cancel_update.py .. src/test/python/apache/aurora/client/commands/test_create.py .. src/test/python/apache/aurora/client/commands/test_diff.py ... src/test/python/apache/aurora/client/commands/test_kill.py . src/test/python/apache/aurora/client/commands/test_listjobs.py .. src/test/python/apache/aurora/client/commands/test_restart.py ... src/test/python/apache/aurora/client/commands/test_status.py .. src/test/python/apache/aurora/client/commands/test_update.py ... == 26 passed in 1.35 seconds == = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/commands/test_maintenance.py == 4 passed in 0.43 seconds === = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_run.py . == 1 passed in 0.49 seconds === = test session starts = platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/commands/test_ssh.py . == 1 passed in 0.54 seconds === src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . SUCCESS src.test.python.apache.aurora.client.commands.maintenance . SUCCESS src.test.python.apache.aurora.client.commands.run . SUCCESS src.test.python.apache.aurora.client.commands.ssh . SUCCESS Thanks, Mark Chu-Carroll