Re: Review Request 19411: Add support for global hooks.

2014-03-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19411/#review38171 --- Ship it! - Maxim Khutornenko On March 21, 2014, 6:21 p.m., Mark C

Re: Review Request 19411: Add support for global hooks.

2014-03-21 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19411/#review38169 --- Ship it! Ship It! - Brian Wickman On March 21, 2014, 6:21 p.m.,

Re: Review Request 19411: Add support for global hooks.

2014-03-21 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19411/ --- (Updated March 21, 2014, 2:21 p.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 19411: Add support for global hooks.

2014-03-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19411/#review38139 --- src/main/python/apache/aurora/client/options.py

Re: Review Request 19411: Add support for global hooks.

2014-03-20 Thread Kevin Sweeney
> On March 19, 2014, 7:07 p.m., Brian Wickman wrote: > > src/main/python/apache/aurora/client/hooks/hooked_api.py, lines 130-131 > > > > > > you'll want GlobalHookRegistry.get_hooks() to return cls.HOOKS[:], > > other

Re: Review Request 19411: Add support for global hooks.

2014-03-20 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19411/ --- (Updated March 20, 2014, 9:28 a.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 19411: Add support for global hooks.

2014-03-20 Thread Mark Chu-Carroll
Dammit python! I thought x += y was a shorthand for x = x + y. You know, like we teach people. On Wed, Mar 19, 2014 at 10:07 PM, Brian Wickman wrote: >This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19411/ > > src/main/python/apache/aurora/cl

Re: Review Request 19411: Add support for global hooks.

2014-03-20 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19411/ --- (Updated March 20, 2014, 7:52 a.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 19411: Add support for global hooks.

2014-03-20 Thread Mark Chu-Carroll
Crap - didn't git add. Tests are sitting in my workspace, but not in the review. On Wed, Mar 19, 2014 at 8:57 PM, Maxim Khutornenko wrote: >This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19411/ > > src/main/python/apache/aurora/client/config.

Re: Review Request 19411: Add support for global hooks.

2014-03-19 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19411/#review37855 --- src/main/python/apache/aurora/client/hooks/hooked_api.py

Re: Review Request 19411: Add support for global hooks.

2014-03-19 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19411/#review37839 --- src/main/python/apache/aurora/client/config.py

Re: Review Request 19411: Add support for global hooks.

2014-03-19 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19411/#review37834 --- src/main/python/apache/aurora/client/config.py

Re: Review Request 19411: Add support for global hooks.

2014-03-19 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19411/#review37831 --- src/main/python/apache/aurora/client/config.py

Review Request 19411: Add support for global hooks.

2014-03-19 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19411/ --- Review request for Aurora, Maxim Khutornenko and Brian Wickman. Bugs: aurora-26