Re: Review Request 20521: Extend the client configuration plugin architecture.

2014-04-22 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20521/#review41056 --- Ship it! Ship It! - David Robinson On April 22, 2014, 7:38 p.m.,

Re: Review Request 20521: Extend the client configuration plugin architecture.

2014-04-22 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20521/ --- (Updated April 22, 2014, 3:38 p.m.) Review request for Aurora, David Robinson a

Re: Review Request 20521: Extend the client configuration plugin architecture.

2014-04-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20521/#review40919 --- Ship it! src/main/python/apache/aurora/client/cli/__init__.py

Re: Review Request 20521: Extend the client configuration plugin architecture.

2014-04-21 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20521/ --- (Updated April 21, 2014, 2:16 p.m.) Review request for Aurora, David Robinson a

Re: Review Request 20521: Extend the client configuration plugin architecture.

2014-04-21 Thread Maxim Khutornenko
> On April 21, 2014, 5:45 p.m., Mark Chu-Carroll wrote: > > src/main/python/apache/aurora/client/cli/__init__.py, line 337 > > > > > > The reason for this is because these errors are not intended to be > > handled. Th

Re: Review Request 20521: Extend the client configuration plugin architecture.

2014-04-21 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20521/#review40894 --- src/main/python/apache/aurora/client/cli/__init__.py

Re: Review Request 20521: Extend the client configuration plugin architecture.

2014-04-21 Thread Maxim Khutornenko
> On April 21, 2014, 4:53 p.m., Mark Chu-Carroll wrote: > > src/main/python/apache/aurora/client/cli/__init__.py, line 337 > > > > > > The pre-execution plugin takes the same command-context as the actual > > verb imp

Re: Review Request 20521: Extend the client configuration plugin architecture.

2014-04-21 Thread Mark Chu-Carroll
> On April 21, 2014, 12:53 p.m., Mark Chu-Carroll wrote: > > src/main/python/apache/aurora/client/cli/__init__.py, line 337 > > > > > > The pre-execution plugin takes the same command-context as the actual > > verb im

Re: Review Request 20521: Extend the client configuration plugin architecture.

2014-04-21 Thread Maxim Khutornenko
> On April 21, 2014, 4:53 p.m., Mark Chu-Carroll wrote: > > src/main/python/apache/aurora/client/cli/__init__.py, line 337 > > > > > > The pre-execution plugin takes the same command-context as the actual > > verb imp

Re: Review Request 20521: Extend the client configuration plugin architecture.

2014-04-21 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20521/ --- (Updated April 21, 2014, 12:53 p.m.) Review request for Aurora, David Robinson

Re: Review Request 20521: Extend the client configuration plugin architecture.

2014-04-21 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20521/#review40887 --- src/main/python/apache/aurora/client/cli/__init__.py

Re: Review Request 20521: Extend the client configuration plugin architecture.

2014-04-21 Thread Maxim Khutornenko
> On April 21, 2014, 4:35 p.m., Mark Chu-Carroll wrote: > > src/main/python/apache/aurora/client/cli/__init__.py, line 337 > > > > > > This has nothing to do with hooks: this is how error codes get returned > > when a

Re: Review Request 20521: Extend the client configuration plugin architecture.

2014-04-21 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20521/ --- (Updated April 21, 2014, 12:36 p.m.) Review request for Aurora, David Robinson

Re: Review Request 20521: Extend the client configuration plugin architecture.

2014-04-21 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20521/#review40885 --- src/main/python/apache/aurora/client/cli/__init__.py

Re: Review Request 20521: Extend the client configuration plugin architecture.

2014-04-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20521/#review40883 --- src/main/python/apache/aurora/client/cli/__init__.py

Review Request 20521: Extend the client configuration plugin architecture.

2014-04-21 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20521/ --- Review request for Aurora, David Robinson and Maxim Khutornenko. Bugs: aurora-3