Re: Review Request 20650: Exclude reports directory from idea project.

[Kevin Sweeney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20650/#review41492
---

Ship it!


Ship It!

- Kevin Sweeney


On April 23, 2014, 10:05 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20650/
> ---
> 
> (Updated April 23, 2014, 10:05 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> IDEA indexes non-excluded directories in dist.  This makes indexing take much 
> longer than necesary, and causes bogus results when searching for usages of 
> symbols.  This fixes (the majority, at least) both issues.
> 
> 
> Diffs
> -
> 
>   build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 
> 
> Diff: https://reviews.apache.org/r/20650/diff/
> 
> 
> Testing
> ---
> 
> IDEA no longer goes into as much of an indexing frenzy after running 
> ./gradlew build, and searching for symbols does not turn up javadoc HTML and 
> test results.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 20650: Exclude reports directory from idea project.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20650/#review41432
---

Ship it!


Ship It!

- Maxim Khutornenko


On April 24, 2014, 5:05 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20650/
> ---
> 
> (Updated April 24, 2014, 5:05 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> IDEA indexes non-excluded directories in dist.  This makes indexing take much 
> longer than necesary, and causes bogus results when searching for usages of 
> symbols.  This fixes (the majority, at least) both issues.
> 
> 
> Diffs
> -
> 
>   build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 
> 
> Diff: https://reviews.apache.org/r/20650/diff/
> 
> 
> Testing
> ---
> 
> IDEA no longer goes into as much of an indexing frenzy after running 
> ./gradlew build, and searching for symbols does not turn up javadoc HTML and 
> test results.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 20650: Exclude reports directory from idea project.

[Bill Farner]

> On April 24, 2014, 6:36 a.m., Suman Karumuri wrote:
> > build.gradle, line 338
> > 
> >
> > Can we add dist/ to this list?
> 
> Jake Farrell wrote:
> +1 with dist added
> 
> Bill Farner wrote:
> You cannot exclude dist/, since our generated code lands beneath dist 
> (see comment immediately above this line).  We could put generated source 
> elsewhere, but i don't want to do that without more careful thought (Kevin 
> had the idea to use a subproject for code generation, which might be a better 
> route).
> 
> Bill Farner wrote:
> > Is it possible then to exclude everything but the generated-src in dist?
> 
> Yes!  My first attempt was to list and filter the children of dist/.  
> However, this doesn't work if dist/reports or dist/test-results don't exist 
> yet (which would be the case if you ran ./gradlew idea on a fresh clone).
> 
> Maxim Khutornenko wrote:
> This looks promising 
> (http://stackoverflow.com/questions/16702126/how-to-specify-intellij-exclude-directories-using-gradle):
> 
> buildDir.listFiles({d,f->f != 'generated-sources'} as 
> FilenameFilter).each {excludeDirs += it}} // Exclude each buildDir child 
> (except generating-source).
> 
> Jake Farrell wrote:
> excludeDirs = []
> // Exclude everything in dist except the generated-src
> buildDir.listFiles({dir,name -> name != 'generated-src'} as 
> FilenameFilter).each { excludeDirs += it }
>

Rephrasing my comment above, AFAICT you can't do this by listing the contents 
of dist/, since the files you want to exclude might not be there _yet_.  Since 
dist/ is under the project root, anything in there that is not explicitly 
excluded will be indexed.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20650/#review41272
---


On April 24, 2014, 5:05 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20650/
> ---
> 
> (Updated April 24, 2014, 5:05 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> IDEA indexes non-excluded directories in dist.  This makes indexing take much 
> longer than necesary, and causes bogus results when searching for usages of 
> symbols.  This fixes (the majority, at least) both issues.
> 
> 
> Diffs
> -
> 
>   build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 
> 
> Diff: https://reviews.apache.org/r/20650/diff/
> 
> 
> Testing
> ---
> 
> IDEA no longer goes into as much of an indexing frenzy after running 
> ./gradlew build, and searching for symbols does not turn up javadoc HTML and 
> test results.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 20650: Exclude reports directory from idea project.

[Jake Farrell]

> On April 24, 2014, 6:36 a.m., Suman Karumuri wrote:
> > build.gradle, line 338
> > 
> >
> > Can we add dist/ to this list?
> 
> Jake Farrell wrote:
> +1 with dist added
> 
> Bill Farner wrote:
> You cannot exclude dist/, since our generated code lands beneath dist 
> (see comment immediately above this line).  We could put generated source 
> elsewhere, but i don't want to do that without more careful thought (Kevin 
> had the idea to use a subproject for code generation, which might be a better 
> route).
> 
> Bill Farner wrote:
> > Is it possible then to exclude everything but the generated-src in dist?
> 
> Yes!  My first attempt was to list and filter the children of dist/.  
> However, this doesn't work if dist/reports or dist/test-results don't exist 
> yet (which would be the case if you ran ./gradlew idea on a fresh clone).
> 
> Maxim Khutornenko wrote:
> This looks promising 
> (http://stackoverflow.com/questions/16702126/how-to-specify-intellij-exclude-directories-using-gradle):
> 
> buildDir.listFiles({d,f->f != 'generated-sources'} as 
> FilenameFilter).each {excludeDirs += it}} // Exclude each buildDir child 
> (except generating-source).

excludeDirs = []
// Exclude everything in dist except the generated-src
buildDir.listFiles({dir,name -> name != 'generated-src'} as 
FilenameFilter).each { excludeDirs += it }


- Jake


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20650/#review41272
---


On April 24, 2014, 5:05 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20650/
> ---
> 
> (Updated April 24, 2014, 5:05 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> IDEA indexes non-excluded directories in dist.  This makes indexing take much 
> longer than necesary, and causes bogus results when searching for usages of 
> symbols.  This fixes (the majority, at least) both issues.
> 
> 
> Diffs
> -
> 
>   build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 
> 
> Diff: https://reviews.apache.org/r/20650/diff/
> 
> 
> Testing
> ---
> 
> IDEA no longer goes into as much of an indexing frenzy after running 
> ./gradlew build, and searching for symbols does not turn up javadoc HTML and 
> test results.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 20650: Exclude reports directory from idea project.

[Maxim Khutornenko]

> On April 24, 2014, 6:36 a.m., Suman Karumuri wrote:
> > build.gradle, line 338
> > 
> >
> > Can we add dist/ to this list?
> 
> Jake Farrell wrote:
> +1 with dist added
> 
> Bill Farner wrote:
> You cannot exclude dist/, since our generated code lands beneath dist 
> (see comment immediately above this line).  We could put generated source 
> elsewhere, but i don't want to do that without more careful thought (Kevin 
> had the idea to use a subproject for code generation, which might be a better 
> route).
> 
> Bill Farner wrote:
> > Is it possible then to exclude everything but the generated-src in dist?
> 
> Yes!  My first attempt was to list and filter the children of dist/.  
> However, this doesn't work if dist/reports or dist/test-results don't exist 
> yet (which would be the case if you ran ./gradlew idea on a fresh clone).

This looks promising 
(http://stackoverflow.com/questions/16702126/how-to-specify-intellij-exclude-directories-using-gradle):

buildDir.listFiles({d,f->f != 'generated-sources'} as FilenameFilter).each 
{excludeDirs += it}} // Exclude each buildDir child (except generating-source).


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20650/#review41272
---


On April 24, 2014, 5:05 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20650/
> ---
> 
> (Updated April 24, 2014, 5:05 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> IDEA indexes non-excluded directories in dist.  This makes indexing take much 
> longer than necesary, and causes bogus results when searching for usages of 
> symbols.  This fixes (the majority, at least) both issues.
> 
> 
> Diffs
> -
> 
>   build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 
> 
> Diff: https://reviews.apache.org/r/20650/diff/
> 
> 
> Testing
> ---
> 
> IDEA no longer goes into as much of an indexing frenzy after running 
> ./gradlew build, and searching for symbols does not turn up javadoc HTML and 
> test results.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 20650: Exclude reports directory from idea project.

[Bill Farner]

> On April 24, 2014, 3:06 p.m., Maxim Khutornenko wrote:
> > build.gradle, line 338
> > 
> >
> > +1. This should work just fine:
> > excludeDirs = [file("$buildDir")]
> 
> Bill Farner wrote:
> Replied in thread above.
> 
> Maxim Khutornenko wrote:
> Is it possible then to exclude everything but the generated-src in dist?

Replied in thread above to keep life simpler :-)


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20650/#review41307
---


On April 24, 2014, 5:05 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20650/
> ---
> 
> (Updated April 24, 2014, 5:05 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> IDEA indexes non-excluded directories in dist.  This makes indexing take much 
> longer than necesary, and causes bogus results when searching for usages of 
> symbols.  This fixes (the majority, at least) both issues.
> 
> 
> Diffs
> -
> 
>   build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 
> 
> Diff: https://reviews.apache.org/r/20650/diff/
> 
> 
> Testing
> ---
> 
> IDEA no longer goes into as much of an indexing frenzy after running 
> ./gradlew build, and searching for symbols does not turn up javadoc HTML and 
> test results.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 20650: Exclude reports directory from idea project.

[Bill Farner]

> On April 24, 2014, 6:36 a.m., Suman Karumuri wrote:
> > build.gradle, line 338
> > 
> >
> > Can we add dist/ to this list?
> 
> Jake Farrell wrote:
> +1 with dist added
> 
> Bill Farner wrote:
> You cannot exclude dist/, since our generated code lands beneath dist 
> (see comment immediately above this line).  We could put generated source 
> elsewhere, but i don't want to do that without more careful thought (Kevin 
> had the idea to use a subproject for code generation, which might be a better 
> route).

> Is it possible then to exclude everything but the generated-src in dist?

Yes!  My first attempt was to list and filter the children of dist/.  However, 
this doesn't work if dist/reports or dist/test-results don't exist yet (which 
would be the case if you ran ./gradlew idea on a fresh clone).


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20650/#review41272
---


On April 24, 2014, 5:05 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20650/
> ---
> 
> (Updated April 24, 2014, 5:05 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> IDEA indexes non-excluded directories in dist.  This makes indexing take much 
> longer than necesary, and causes bogus results when searching for usages of 
> symbols.  This fixes (the majority, at least) both issues.
> 
> 
> Diffs
> -
> 
>   build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 
> 
> Diff: https://reviews.apache.org/r/20650/diff/
> 
> 
> Testing
> ---
> 
> IDEA no longer goes into as much of an indexing frenzy after running 
> ./gradlew build, and searching for symbols does not turn up javadoc HTML and 
> test results.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 20650: Exclude reports directory from idea project.

[Maxim Khutornenko]

> On April 24, 2014, 3:06 p.m., Maxim Khutornenko wrote:
> > build.gradle, line 338
> > 
> >
> > +1. This should work just fine:
> > excludeDirs = [file("$buildDir")]
> 
> Bill Farner wrote:
> Replied in thread above.

Is it possible then to exclude everything but the generated-src in dist?


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20650/#review41307
---


On April 24, 2014, 5:05 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20650/
> ---
> 
> (Updated April 24, 2014, 5:05 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> IDEA indexes non-excluded directories in dist.  This makes indexing take much 
> longer than necesary, and causes bogus results when searching for usages of 
> symbols.  This fixes (the majority, at least) both issues.
> 
> 
> Diffs
> -
> 
>   build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 
> 
> Diff: https://reviews.apache.org/r/20650/diff/
> 
> 
> Testing
> ---
> 
> IDEA no longer goes into as much of an indexing frenzy after running 
> ./gradlew build, and searching for symbols does not turn up javadoc HTML and 
> test results.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 20650: Exclude reports directory from idea project.

[Bill Farner]

> On April 24, 2014, 3:06 p.m., Maxim Khutornenko wrote:
> > build.gradle, line 338
> > 
> >
> > +1. This should work just fine:
> > excludeDirs = [file("$buildDir")]

Replied in thread above.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20650/#review41307
---


On April 24, 2014, 5:05 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20650/
> ---
> 
> (Updated April 24, 2014, 5:05 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> IDEA indexes non-excluded directories in dist.  This makes indexing take much 
> longer than necesary, and causes bogus results when searching for usages of 
> symbols.  This fixes (the majority, at least) both issues.
> 
> 
> Diffs
> -
> 
>   build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 
> 
> Diff: https://reviews.apache.org/r/20650/diff/
> 
> 
> Testing
> ---
> 
> IDEA no longer goes into as much of an indexing frenzy after running 
> ./gradlew build, and searching for symbols does not turn up javadoc HTML and 
> test results.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 20650: Exclude reports directory from idea project.

[Bill Farner]

> On April 24, 2014, 6:36 a.m., Suman Karumuri wrote:
> > build.gradle, line 338
> > 
> >
> > Can we add dist/ to this list?
> 
> Jake Farrell wrote:
> +1 with dist added

You cannot exclude dist/, since our generated code lands beneath dist (see 
comment immediately above this line).  We could put generated source elsewhere, 
but i don't want to do that without more careful thought (Kevin had the idea to 
use a subproject for code generation, which might be a better route).


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20650/#review41272
---


On April 24, 2014, 5:05 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20650/
> ---
> 
> (Updated April 24, 2014, 5:05 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> IDEA indexes non-excluded directories in dist.  This makes indexing take much 
> longer than necesary, and causes bogus results when searching for usages of 
> symbols.  This fixes (the majority, at least) both issues.
> 
> 
> Diffs
> -
> 
>   build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 
> 
> Diff: https://reviews.apache.org/r/20650/diff/
> 
> 
> Testing
> ---
> 
> IDEA no longer goes into as much of an indexing frenzy after running 
> ./gradlew build, and searching for symbols does not turn up javadoc HTML and 
> test results.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 20650: Exclude reports directory from idea project.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20650/#review41307
---



build.gradle


+1. This should work just fine:
excludeDirs = [file("$buildDir")]


- Maxim Khutornenko


On April 24, 2014, 5:05 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20650/
> ---
> 
> (Updated April 24, 2014, 5:05 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> IDEA indexes non-excluded directories in dist.  This makes indexing take much 
> longer than necesary, and causes bogus results when searching for usages of 
> symbols.  This fixes (the majority, at least) both issues.
> 
> 
> Diffs
> -
> 
>   build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 
> 
> Diff: https://reviews.apache.org/r/20650/diff/
> 
> 
> Testing
> ---
> 
> IDEA no longer goes into as much of an indexing frenzy after running 
> ./gradlew build, and searching for symbols does not turn up javadoc HTML and 
> test results.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 20650: Exclude reports directory from idea project.

[Jake Farrell]

> On April 24, 2014, 6:36 a.m., Suman Karumuri wrote:
> > build.gradle, line 338
> > 
> >
> > Can we add dist/ to this list?

+1 with dist added


- Jake


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20650/#review41272
---


On April 24, 2014, 5:05 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20650/
> ---
> 
> (Updated April 24, 2014, 5:05 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> IDEA indexes non-excluded directories in dist.  This makes indexing take much 
> longer than necesary, and causes bogus results when searching for usages of 
> symbols.  This fixes (the majority, at least) both issues.
> 
> 
> Diffs
> -
> 
>   build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 
> 
> Diff: https://reviews.apache.org/r/20650/diff/
> 
> 
> Testing
> ---
> 
> IDEA no longer goes into as much of an indexing frenzy after running 
> ./gradlew build, and searching for symbols does not turn up javadoc HTML and 
> test results.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 20650: Exclude reports directory from idea project.

[Suman Karumuri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20650/#review41272
---



build.gradle


Can we add dist/ to this list?


- Suman Karumuri


On April 24, 2014, 5:05 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20650/
> ---
> 
> (Updated April 24, 2014, 5:05 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> IDEA indexes non-excluded directories in dist.  This makes indexing take much 
> longer than necesary, and causes bogus results when searching for usages of 
> symbols.  This fixes (the majority, at least) both issues.
> 
> 
> Diffs
> -
> 
>   build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 
> 
> Diff: https://reviews.apache.org/r/20650/diff/
> 
> 
> Testing
> ---
> 
> IDEA no longer goes into as much of an indexing frenzy after running 
> ./gradlew build, and searching for symbols does not turn up javadoc HTML and 
> test results.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Review Request 20650: Exclude reports directory from idea project.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20650/
---

Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Repository: aurora


Description
---

IDEA indexes non-excluded directories in dist.  This makes indexing take much 
longer than necesary, and causes bogus results when searching for usages of 
symbols.  This fixes (the majority, at least) both issues.


Diffs
-

  build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 

Diff: https://reviews.apache.org/r/20650/diff/


Testing
---

IDEA no longer goes into as much of an indexing frenzy after running ./gradlew 
build, and searching for symbols does not turn up javadoc HTML and test results.


Thanks,

Bill Farner