Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-29 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20687/ --- (Updated April 29, 2014, 10:27 a.m.) Review request for Aurora, David

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-29 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20687/ --- (Updated April 29, 2014, 12:47 p.m.) Review request for Aurora, David

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-29 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20687/ --- (Updated April 29, 2014, 3:01 p.m.) Review request for Aurora, David

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-28 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20687/#review41616 --- src/main/python/apache/aurora/client/cli/__init__.py

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-28 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20687/ --- (Updated April 28, 2014, 3 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-28 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20687/ --- (Updated April 28, 2014, 3:01 p.m.) Review request for Aurora, David

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-28 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20687/#review41669 --- lgtm. Please cut a separate ticket for the tests. The only ship it

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-25 Thread David McLaughlin
On April 25, 2014, 12:15 a.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/cli/__init__.py, line 344 https://reviews.apache.org/r/20687/diff/1/?file=567983#file567983line344 Different cases. A command hook can signal that a command shouldn't be

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-25 Thread Mark Chu-Carroll
On April 24, 2014, 8:15 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/cli/__init__.py, line 344 https://reviews.apache.org/r/20687/diff/1/?file=567983#file567983line344 Different cases. A command hook can signal that a command shouldn't be executed,

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-25 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20687/#review41510 --- Ship it! Ship It! - David McLaughlin On April 25, 2014, 12:17

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-25 Thread Mark Chu-Carroll
Thanks for doing this so quickly! On Fri, Apr 25, 2014 at 3:31 PM, David McLaughlin da...@dmclaughlin.comwrote: This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20687/ Ship it! Ship It! - David McLaughlin On April 25th, 2014, 12:17 a.m. UTC,

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-24 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20687/#review41384 --- Should the documentation for this feature be part of this review?

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-24 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20687/#review41420 --- src/main/python/apache/aurora/client/cli/__init__.py

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-24 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20687/ --- (Updated April 24, 2014, 8:17 p.m.) Review request for Aurora, David