Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-07-01 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22839/#review47138 --- Ping!! Come on guys, this is getting silly! - Mark Chu-Carroll

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-07-01 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22839/#review47144 --- src/main/python/apache/aurora/client/cli/standalone_client.py

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-07-01 Thread Mark Chu-Carroll
On July 1, 2014, 4:55 p.m., Brian Wickman wrote: src/main/python/apache/aurora/client/cli/standalone_client.py, line 71 https://reviews.apache.org/r/22839/diff/3/?file=619405#file619405line71 i still don't see --logging-level= This is changed in my workspace... not sure what

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-07-01 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22839/ --- (Updated July 1, 2014, 5:08 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-06-30 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22839/#review46992 --- ping? - Mark Chu-Carroll On June 27, 2014, 11:27 a.m., Mark

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-06-27 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22839/#review46778 --- src/main/python/apache/aurora/client/cli/standalone_client.py

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-06-27 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22839/ --- (Updated June 27, 2014, 11:27 a.m.) Review request for Aurora, David

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-06-27 Thread Brian Wickman
On June 27, 2014, 3:14 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/cli/standalone_client.py, line 69 https://reviews.apache.org/r/22839/diff/2/?file=617025#file617025line69 No. We don't want to catch an invalid parameter like --logging-level-max. but you

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-06-27 Thread Mark Chu-Carroll
On June 27, 2014, 11:14 a.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/cli/standalone_client.py, line 69 https://reviews.apache.org/r/22839/diff/2/?file=617025#file617025line69 No. We don't want to catch an invalid parameter like --logging-level-max. Brian

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-06-26 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22839/#review46756 --- src/main/python/apache/aurora/client/cli/standalone_client.py

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-06-25 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22839/ --- (Updated June 25, 2014, 12:38 p.m.) Review request for Aurora, David

Review Request 22839: Add configuration plugins to default aurora client.

2014-06-20 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22839/ --- Review request for Aurora, David McLaughlin and Brian Wickman. Bugs:

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-06-20 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22839/#review46323 --- src/main/python/apache/aurora/client/cli/standalone_client.py

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-06-20 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22839/#review46325 --- not a big fan of globals here. can you instead annotate the

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-06-20 Thread Brian Wickman
On June 20, 2014, 9:30 p.m., Brian Wickman wrote: not a big fan of globals here. can you instead annotate the context with the exception and in post-dispatch have the plugin print it out if --reveal-errors is set? Mark Chu-Carroll wrote: I'm not a big fan of globals either, but

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-06-20 Thread Mark Chu-Carroll
On June 20, 2014, 5:30 p.m., Brian Wickman wrote: not a big fan of globals here. can you instead annotate the context with the exception and in post-dispatch have the plugin print it out if --reveal-errors is set? Mark Chu-Carroll wrote: I'm not a big fan of globals either, but

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-06-20 Thread Mark Chu-Carroll
On June 20, 2014, 5:30 p.m., Brian Wickman wrote: not a big fan of globals here. can you instead annotate the context with the exception and in post-dispatch have the plugin print it out if --reveal-errors is set? Mark Chu-Carroll wrote: I'm not a big fan of globals either, but