Re: Review Request 22982: Use java.util.Objects replacements for guava helpers.

2014-07-01 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22982/ --- (Updated July 1, 2014, 8:33 p.m.) Review request for Aurora and Maxim

Re: Review Request 22982: Use java.util.Objects replacements for guava helpers.

2014-06-26 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22982/#review46758 ---

Re: Review Request 22982: Use java.util.Objects replacements for guava helpers.

2014-06-26 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22982/#review46770 --- replace Preconditions.checkNotNull with Objects.requireNonNull as

Re: Review Request 22982: Use java.util.Objects replacements for guava helpers.

2014-06-26 Thread Bill Farner
On June 26, 2014, 4:59 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java, line 96 https://reviews.apache.org/r/22982/diff/1/?file=617559#file617559line96 This seems like a repeating pattern to avoid naming collision. What do

Re: Review Request 22982: Use java.util.Objects replacements for guava helpers.

2014-06-26 Thread Bill Farner
On June 26, 2014, 6:21 p.m., Kevin Sweeney wrote: replace Preconditions.checkNotNull with Objects.requireNonNull as well? Great suggestion, i'll update the diff to add that. - Bill --- This is an automatically generated e-mail. To

Re: Review Request 22982: Use java.util.Objects replacements for guava helpers.

2014-06-26 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22982/ --- (Updated June 26, 2014, 7:52 p.m.) Review request for Aurora and Maxim

Re: Review Request 22982: Use java.util.Objects replacements for guava helpers.

2014-06-26 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22982/#review46796 --- Latest diff is bad, i managed to pick up some python code with my

Re: Review Request 22982: Use java.util.Objects replacements for guava helpers.

2014-06-26 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22982/ --- (Updated June 26, 2014, 8:33 p.m.) Review request for Aurora and Maxim

Review Request 22982: Use java.util.Objects replacements for guava helpers.

2014-06-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22982/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora