Re: Review Request 24126: Adding a wait_for_batch_completion option into parallel updater.

2014-07-31 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24126/ --- (Updated July 31, 2014, 4:38 p.m.) Review request for Aurora, Kevin Sweeney,

Re: Review Request 24126: Adding a wait_for_batch_completion option into parallel updater.

2014-07-31 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24126/#review49272 --- src/main/python/apache/aurora/client/api/updater.py

Re: Review Request 24126: Adding a wait_for_batch_completion option into parallel updater.

2014-07-31 Thread Kevin Sweeney
On July 31, 2014, 12:04 p.m., Kevin Sweeney wrote: src/main/python/apache/aurora/client/api/updater.py, lines 234-235 https://reviews.apache.org/r/24126/diff/3/?file=646929#file646929line234 I can't find any documentation that this actually works - in theory

Review Request 24126: Adding a wait_for_batch_completion option into parallel updater.

2014-07-30 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24126/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-626

Re: Review Request 24126: Adding a wait_for_batch_completion option into parallel updater.

2014-07-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24126/#review49185 --- src/main/python/apache/aurora/client/api/updater.py

Re: Review Request 24126: Adding a wait_for_batch_completion option into parallel updater.

2014-07-30 Thread Bill Farner
On July 31, 2014, 12:19 a.m., Bill Farner wrote: src/test/python/apache/aurora/client/api/test_updater.py, line 821 https://reviews.apache.org/r/24126/diff/1/?file=646405#file646405line821 Can you add two more test cases with batch_size 1: - instances % batch_size ==

Re: Review Request 24126: Adding a wait_for_batch_completion option into parallel updater.

2014-07-30 Thread Maxim Khutornenko
On July 31, 2014, 12:19 a.m., Bill Farner wrote: src/test/python/apache/aurora/client/api/test_updater.py, line 821 https://reviews.apache.org/r/24126/diff/1/?file=646405#file646405line821 Can you add two more test cases with batch_size 1: - instances % batch_size ==

Re: Review Request 24126: Adding a wait_for_batch_completion option into parallel updater.

2014-07-30 Thread Maxim Khutornenko
On July 31, 2014, 12:19 a.m., Bill Farner wrote: src/test/python/apache/aurora/client/api/test_updater.py, line 821 https://reviews.apache.org/r/24126/diff/1/?file=646405#file646405line821 Can you add two more test cases with batch_size 1: - instances % batch_size ==