Re: Review Request 25357: Adding support for per-job task status metrics.

2014-09-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25357/#review52453 --- src/main/java/org/apache/aurora/scheduler/TaskVars.java

Re: Review Request 25357: Adding support for per-job task status metrics.

2014-09-05 Thread Maxim Khutornenko
On Sept. 5, 2014, 3:01 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/TaskVars.java, line 71 https://reviews.apache.org/r/25357/diff/2/?file=679151#file679151line71 I should have been more explicit. I would prefer that only the job-scoped vars be

Re: Review Request 25357: Adding support for per-job task status metrics.

2014-09-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25357/ --- (Updated Sept. 5, 2014, 6:47 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 25357: Adding support for per-job task status metrics.

2014-09-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25357/#review52497 --- Ship it! Ship It! - Bill Farner On Sept. 5, 2014, 6:47 p.m.,

Review Request 25357: Adding support for per-job task status metrics.

2014-09-04 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25357/ --- Review request for Aurora, David McLaughlin and Bill Farner. Bugs: AURORA-685

Re: Review Request 25357: Adding support for per-job task status metrics.

2014-09-04 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25357/#review52362 --- Ship it! lgtm(y still scheduler-naive eyes).

Re: Review Request 25357: Adding support for per-job task status metrics.

2014-09-04 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25357/#review52379 --- Ship it! Ship It! - David McLaughlin On Sept. 4, 2014, 9:42

Re: Review Request 25357: Adding support for per-job task status metrics.

2014-09-04 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25357/#review52382 --- src/main/java/org/apache/aurora/scheduler/TaskVars.java

Re: Review Request 25357: Adding support for per-job task status metrics.

2014-09-04 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25357/ --- (Updated Sept. 5, 2014, 12:23 a.m.) Review request for Aurora, David

Re: Review Request 25357: Adding support for per-job task status metrics.

2014-09-04 Thread Maxim Khutornenko
On Sept. 4, 2014, 11:59 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/TaskVars.java, line 168 https://reviews.apache.org/r/25357/diff/1/?file=679026#file679026line168 To mitigate the risk of OOM in the scheduler's internal TSDB, we should use untracked stats,