Re: Review Request 25505: Make aurora job status JSON output more friendly.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25505/#review52902 --- Since you are touching this code, mind fixing the error when no tasks returned: log(ERROR): Internal error executing command: 'NoneType' object is not iterable As opposed to aurora status: INFO] No tasks found. - Maxim Khutornenko On Sept. 10, 2014, 5:38 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25505/ --- (Updated Sept. 10, 2014, 5:38 p.m.) Review request for Aurora, David McLaughlin and Maxim Khutornenko. Bugs: aurora-666 https://issues.apache.org/jira/browse/aurora-666 Repository: aurora Description --- Use string names instead of numeric values for ScheduleStatus fields of records rendered in JSON. Diffs - src/main/python/apache/aurora/client/cli/jobs.py 38b5f6e306c2c8dd9aa8d98e21c6a628028ad899 src/test/python/apache/aurora/client/cli/test_status.py 721d9764190bdc4b1c5b65e416a039803b7c507c Diff: https://reviews.apache.org/r/25505/diff/ Testing --- Added new unit tests; all tests pass. Thanks, Mark Chu-Carroll
Re: Review Request 25505: Make aurora job status JSON output more friendly.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25505/ --- (Updated Sept. 10, 2014, 3:34 p.m.) Review request for Aurora, David McLaughlin and Maxim Khutornenko. Changes --- Fix other error in job status, generating error when no matching job is found. Bugs: aurora-666 https://issues.apache.org/jira/browse/aurora-666 Repository: aurora Description --- Use string names instead of numeric values for ScheduleStatus fields of records rendered in JSON. Diffs (updated) - src/main/python/apache/aurora/client/cli/jobs.py 38b5f6e306c2c8dd9aa8d98e21c6a628028ad899 src/test/python/apache/aurora/client/cli/test_status.py 721d9764190bdc4b1c5b65e416a039803b7c507c Diff: https://reviews.apache.org/r/25505/diff/ Testing --- Added new unit tests; all tests pass. Thanks, Mark Chu-Carroll
Re: Review Request 25505: Make aurora job status JSON output more friendly.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25505/#review52926 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 10, 2014, 7:34 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25505/ --- (Updated Sept. 10, 2014, 7:34 p.m.) Review request for Aurora, David McLaughlin and Maxim Khutornenko. Bugs: aurora-666 https://issues.apache.org/jira/browse/aurora-666 Repository: aurora Description --- Use string names instead of numeric values for ScheduleStatus fields of records rendered in JSON. Diffs - src/main/python/apache/aurora/client/cli/jobs.py 38b5f6e306c2c8dd9aa8d98e21c6a628028ad899 src/test/python/apache/aurora/client/cli/test_status.py 721d9764190bdc4b1c5b65e416a039803b7c507c Diff: https://reviews.apache.org/r/25505/diff/ Testing --- Added new unit tests; all tests pass. Thanks, Mark Chu-Carroll
Re: Review Request 25505: Make aurora job status JSON output more friendly.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25505/#review52930 --- Ship it! Ship It! - Zameer Manji On Sept. 10, 2014, 12:34 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25505/ --- (Updated Sept. 10, 2014, 12:34 p.m.) Review request for Aurora, David McLaughlin and Maxim Khutornenko. Bugs: aurora-666 https://issues.apache.org/jira/browse/aurora-666 Repository: aurora Description --- Use string names instead of numeric values for ScheduleStatus fields of records rendered in JSON. Diffs - src/main/python/apache/aurora/client/cli/jobs.py 38b5f6e306c2c8dd9aa8d98e21c6a628028ad899 src/test/python/apache/aurora/client/cli/test_status.py 721d9764190bdc4b1c5b65e416a039803b7c507c Diff: https://reviews.apache.org/r/25505/diff/ Testing --- Added new unit tests; all tests pass. Thanks, Mark Chu-Carroll
