Re: Review Request 25750: Store new task configuration in JobUpdateConfiguration as InstanceTaskConfig

2014-09-18 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25750/#review53860 --- Ship it! Ship It! - David McLaughlin On Sept. 17, 2014, 8:40

Re: Review Request 25750: Store new task configuration in JobUpdateConfiguration as InstanceTaskConfig

2014-09-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25750/ --- (Updated Sept. 18, 2014, 8:37 p.m.) Review request for Aurora, David

Re: Review Request 25750: Store new task configuration in JobUpdateConfiguration as InstanceTaskConfig

2014-09-17 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25750/ --- (Updated Sept. 17, 2014, 8:40 p.m.) Review request for Aurora, David

Re: Review Request 25750: Store new task configuration in JobUpdateConfiguration as InstanceTaskConfig

2014-09-17 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25750/#review53746 --- +1 to the code change, UI stuff in particular looks good to me. -1

Re: Review Request 25750: Store new task configuration in JobUpdateConfiguration as InstanceTaskConfig

2014-09-17 Thread Bill Farner
On Sept. 17, 2014, 9:18 p.m., David McLaughlin wrote: +1 to the code change, UI stuff in particular looks good to me. -1 to dropping instanceCount completely though. I thought we mentioned we wanted to capture and store all the original details the user sends? Even if this is

Re: Review Request 25750: Store new task configuration in JobUpdateConfiguration as InstanceTaskConfig

2014-09-17 Thread Maxim Khutornenko
On Sept. 17, 2014, 9:18 p.m., David McLaughlin wrote: +1 to the code change, UI stuff in particular looks good to me. -1 to dropping instanceCount completely though. I thought we mentioned we wanted to capture and store all the original details the user sends? Even if this is

Re: Review Request 25750: Store new task configuration in JobUpdateConfiguration as InstanceTaskConfig

2014-09-17 Thread David McLaughlin
On Sept. 17, 2014, 9:18 p.m., David McLaughlin wrote: +1 to the code change, UI stuff in particular looks good to me. -1 to dropping instanceCount completely though. I thought we mentioned we wanted to capture and store all the original details the user sends? Even if this is

Re: Review Request 25750: Store new task configuration in JobUpdateConfiguration as InstanceTaskConfig

2014-09-17 Thread Maxim Khutornenko
On Sept. 17, 2014, 9:18 p.m., David McLaughlin wrote: +1 to the code change, UI stuff in particular looks good to me. -1 to dropping instanceCount completely though. I thought we mentioned we wanted to capture and store all the original details the user sends? Even if this is