Review Request 25914: use javax.inject.Qualifier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25914/ --- Review request for Aurora. Repository: aurora Description --- use javax.inject.Qualifier instead of @BindingAnnotation See https://github.com/google/guice/wiki/JSR330 Diffs - src/main/java/org/apache/aurora/GuiceUtils.java a27243c6b93330bf8415a140ad7052e6144a1fef src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java e72961abf6509fbd3ee7e3c73ea61a4c2536bb80 src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 4088559c39014befaddb0b29dad45fac9f4545c4 src/main/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelay.java 1a65a3418c1bf8276f78a2d3aad532b4768a010c src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 882cdfd9b79b262befb81437cbd9a31a6bc1e40f src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLog.java fd08be11381255f1aca640db9c6276eaddeb7b91 src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 05417ca29714a18b0f3f8e062ae005d04671051e src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 085454c63a3023e28ae1d148c64d25cfed99c4f1 src/main/java/org/apache/aurora/scheduler/state/TaskLimitValidator.java 779e925e4d9e7889e8cfd369cea9a8e5da3554d2 src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java c4435cb74925c9ed04a37820b22c3ecdfcad49d4 src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java fc3eaf6ba461dbfc371afc6ccf5afbd34760f2c5 src/main/java/org/apache/aurora/scheduler/storage/Storage.java f83a71a877a317810cd166c74ca468dd17c50d07 src/main/java/org/apache/aurora/scheduler/storage/backup/StorageBackup.java 4bfb44d43224e8bb99efcd3051d7f01ee636c2a3 src/main/java/org/apache/aurora/scheduler/storage/log/Entries.java 6f94af50a9992dd5efd9f28c0d39ae808a3f3e87 src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 87bd6579409e4f397f1efaa10192e271e022cade src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 816f4504f067daab3b86e1885390957ace9d4f7b src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java ce42ad20e8839698583e04f1780c59197a9f0be8 src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 186bc46d74c562603d5e0a724b0fe2ff5b69131d src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java 52ff46447c4b73f2b126ac297f2a74b731373267 Diff: https://reviews.apache.org/r/25914/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney
Re: Review Request 25914: use javax.inject.Qualifier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25914/ --- (Updated Sept. 22, 2014, 4:35 p.m.) Review request for Aurora. Changes --- Fix import order for test sources Repository: aurora Description --- use javax.inject.Qualifier instead of @BindingAnnotation See https://github.com/google/guice/wiki/JSR330 Diffs (updated) - src/main/java/org/apache/aurora/GuiceUtils.java a27243c6b93330bf8415a140ad7052e6144a1fef src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java e72961abf6509fbd3ee7e3c73ea61a4c2536bb80 src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 4088559c39014befaddb0b29dad45fac9f4545c4 src/main/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelay.java 1a65a3418c1bf8276f78a2d3aad532b4768a010c src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 882cdfd9b79b262befb81437cbd9a31a6bc1e40f src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLog.java fd08be11381255f1aca640db9c6276eaddeb7b91 src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 05417ca29714a18b0f3f8e062ae005d04671051e src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 085454c63a3023e28ae1d148c64d25cfed99c4f1 src/main/java/org/apache/aurora/scheduler/state/TaskLimitValidator.java 779e925e4d9e7889e8cfd369cea9a8e5da3554d2 src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java c4435cb74925c9ed04a37820b22c3ecdfcad49d4 src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java fc3eaf6ba461dbfc371afc6ccf5afbd34760f2c5 src/main/java/org/apache/aurora/scheduler/storage/Storage.java f83a71a877a317810cd166c74ca468dd17c50d07 src/main/java/org/apache/aurora/scheduler/storage/backup/StorageBackup.java 4bfb44d43224e8bb99efcd3051d7f01ee636c2a3 src/main/java/org/apache/aurora/scheduler/storage/log/Entries.java 6f94af50a9992dd5efd9f28c0d39ae808a3f3e87 src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 87bd6579409e4f397f1efaa10192e271e022cade src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 816f4504f067daab3b86e1885390957ace9d4f7b src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java ce42ad20e8839698583e04f1780c59197a9f0be8 src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 186bc46d74c562603d5e0a724b0fe2ff5b69131d src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 49770e5f87f047502e4f5653b908657a40d8683f src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java d07220ae3e83c5dae43dd6280fa65c1f9a94f075 src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java 52ff46447c4b73f2b126ac297f2a74b731373267 Diff: https://reviews.apache.org/r/25914/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney
Re: Review Request 25914: use javax.inject.Qualifier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25914/#review54206 --- Ship it! Ship It! - Zameer Manji On Sept. 22, 2014, 4:35 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25914/ --- (Updated Sept. 22, 2014, 4:35 p.m.) Review request for Aurora. Repository: aurora Description --- use javax.inject.Qualifier instead of @BindingAnnotation See https://github.com/google/guice/wiki/JSR330 Diffs - src/main/java/org/apache/aurora/GuiceUtils.java a27243c6b93330bf8415a140ad7052e6144a1fef src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java e72961abf6509fbd3ee7e3c73ea61a4c2536bb80 src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 4088559c39014befaddb0b29dad45fac9f4545c4 src/main/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelay.java 1a65a3418c1bf8276f78a2d3aad532b4768a010c src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 882cdfd9b79b262befb81437cbd9a31a6bc1e40f src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLog.java fd08be11381255f1aca640db9c6276eaddeb7b91 src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 05417ca29714a18b0f3f8e062ae005d04671051e src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 085454c63a3023e28ae1d148c64d25cfed99c4f1 src/main/java/org/apache/aurora/scheduler/state/TaskLimitValidator.java 779e925e4d9e7889e8cfd369cea9a8e5da3554d2 src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java c4435cb74925c9ed04a37820b22c3ecdfcad49d4 src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java fc3eaf6ba461dbfc371afc6ccf5afbd34760f2c5 src/main/java/org/apache/aurora/scheduler/storage/Storage.java f83a71a877a317810cd166c74ca468dd17c50d07 src/main/java/org/apache/aurora/scheduler/storage/backup/StorageBackup.java 4bfb44d43224e8bb99efcd3051d7f01ee636c2a3 src/main/java/org/apache/aurora/scheduler/storage/log/Entries.java 6f94af50a9992dd5efd9f28c0d39ae808a3f3e87 src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 87bd6579409e4f397f1efaa10192e271e022cade src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 816f4504f067daab3b86e1885390957ace9d4f7b src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java ce42ad20e8839698583e04f1780c59197a9f0be8 src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 186bc46d74c562603d5e0a724b0fe2ff5b69131d src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 49770e5f87f047502e4f5653b908657a40d8683f src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java d07220ae3e83c5dae43dd6280fa65c1f9a94f075 src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java 52ff46447c4b73f2b126ac297f2a74b731373267 Diff: https://reviews.apache.org/r/25914/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney
Re: Review Request 25914: use javax.inject.Qualifier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25914/ --- (Updated Sept. 22, 2014, 5:27 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Repository: aurora Description --- use javax.inject.Qualifier instead of @BindingAnnotation See https://github.com/google/guice/wiki/JSR330 Diffs - src/main/java/org/apache/aurora/GuiceUtils.java a27243c6b93330bf8415a140ad7052e6144a1fef src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java e72961abf6509fbd3ee7e3c73ea61a4c2536bb80 src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 4088559c39014befaddb0b29dad45fac9f4545c4 src/main/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelay.java 1a65a3418c1bf8276f78a2d3aad532b4768a010c src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 882cdfd9b79b262befb81437cbd9a31a6bc1e40f src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLog.java fd08be11381255f1aca640db9c6276eaddeb7b91 src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 05417ca29714a18b0f3f8e062ae005d04671051e src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 085454c63a3023e28ae1d148c64d25cfed99c4f1 src/main/java/org/apache/aurora/scheduler/state/TaskLimitValidator.java 779e925e4d9e7889e8cfd369cea9a8e5da3554d2 src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java c4435cb74925c9ed04a37820b22c3ecdfcad49d4 src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java fc3eaf6ba461dbfc371afc6ccf5afbd34760f2c5 src/main/java/org/apache/aurora/scheduler/storage/Storage.java f83a71a877a317810cd166c74ca468dd17c50d07 src/main/java/org/apache/aurora/scheduler/storage/backup/StorageBackup.java 4bfb44d43224e8bb99efcd3051d7f01ee636c2a3 src/main/java/org/apache/aurora/scheduler/storage/log/Entries.java 6f94af50a9992dd5efd9f28c0d39ae808a3f3e87 src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 87bd6579409e4f397f1efaa10192e271e022cade src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 816f4504f067daab3b86e1885390957ace9d4f7b src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java ce42ad20e8839698583e04f1780c59197a9f0be8 src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 186bc46d74c562603d5e0a724b0fe2ff5b69131d src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 49770e5f87f047502e4f5653b908657a40d8683f src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java d07220ae3e83c5dae43dd6280fa65c1f9a94f075 src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java 52ff46447c4b73f2b126ac297f2a74b731373267 Diff: https://reviews.apache.org/r/25914/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney
