Review Request 26093: Revert Run python style checks in jenkins.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26093/ --- Review request for Aurora and Brian Wickman. Repository: aurora Description --- Not sure why, but this consistently fails in jenkins. Reverting unless you have any ideas how to sort it out. Diffs - build-support/jenkins/build.sh 602b0bcd050cc8270b1f2c2ff3765f8e9319dd22 Diff: https://reviews.apache.org/r/26093/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 26093: Revert Run python style checks in jenkins.
On Sept. 26, 2014, 8:29 p.m., Brian Wickman wrote: build-support/jenkins/build.sh, line 27 https://reviews.apache.org/r/26093/diff/1/?file=706245#file706245line27 without seeing the output, we have no idea. rather than remove completely, i'd prefer to change this to something like: if ! ./build-support/hooks/pre-commit; then build-support/python/isort-check || true build-support/python/checkstyle-check || true exit 1 fi (i know this leaks knowledge of the checks from pre-commit to build.sh, so we should probably add a build-support/python/check-all that build.sh and pre-commit can each call.) Bill Farner wrote: From a manual run, this is the error: Traceback (most recent call last): File https://builds.apache.org/job/Aurora/ws/build-support/python/checkstyle.venv/local/lib/python2.7/site-packages/twitter/common/app/application.py;, line 738, in _wrap_method return_code = method() File https://builds.apache.org/job/Aurora/ws/build-support/python/checkstyle.venv/local/lib/python2.7/site-packages/twitter/common/app/application.py;, line 760, in lambda main = lambda: main_method(*args, **kwargs) File https://builds.apache.org/job/Aurora/ws/build-support/python/checkstyle.venv/local/lib/python2.7/site-packages/twitter/checkstyle/checker.py;, line 155, in main for filename, line_filter in iterator: File https://builds.apache.org/job/Aurora/ws/build-support/python/checkstyle.venv/local/lib/python2.7/site-packages/twitter/checkstyle/iterators.py;, line 120, in git_iterator diff_commit = repo.rev_parse(options.diff or 'master') File https://builds.apache.org/job/Aurora/ws/build-support/python/checkstyle.venv/local/lib/python2.7/site-packages/git/repo/fun.py;, line 274, in rev_parse obj = name_to_object(repo, rev) File https://builds.apache.org/job/Aurora/ws/build-support/python/checkstyle.venv/local/lib/python2.7/site-packages/git/repo/fun.py;, line 86, in name_to_object raise BadObject(name) BadObject: BadObject: 6d6173746572 That's...bizarre. checkstyle-check by default runs checkstyle on the diff against master. Oh son of a ...running build-support/python/checkstyle-check src shows that checkstyle has drifted considerably probably for this very reason. The jenkins build should run checkstyle-check src. Let me fix all the checkstyle breaks + combined with an RB with the checkstyle added back to the build.sh. Submit this in the meantime. - Brian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26093/#review54724 --- On Sept. 26, 2014, 7:33 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26093/ --- (Updated Sept. 26, 2014, 7:33 p.m.) Review request for Aurora and Brian Wickman. Repository: aurora Description --- Not sure why, but this consistently fails in jenkins. Reverting unless you have any ideas how to sort it out. Diffs - build-support/jenkins/build.sh 602b0bcd050cc8270b1f2c2ff3765f8e9319dd22 Diff: https://reviews.apache.org/r/26093/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 26093: Revert Run python style checks in jenkins.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26093/#review54731 --- Ship it! Ship It! - Brian Wickman On Sept. 26, 2014, 7:33 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26093/ --- (Updated Sept. 26, 2014, 7:33 p.m.) Review request for Aurora and Brian Wickman. Repository: aurora Description --- Not sure why, but this consistently fails in jenkins. Reverting unless you have any ideas how to sort it out. Diffs - build-support/jenkins/build.sh 602b0bcd050cc8270b1f2c2ff3765f8e9319dd22 Diff: https://reviews.apache.org/r/26093/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 26093: Revert Run python style checks in jenkins.
On Sept. 26, 2014, 8:29 p.m., Brian Wickman wrote: build-support/jenkins/build.sh, line 27 https://reviews.apache.org/r/26093/diff/1/?file=706245#file706245line27 without seeing the output, we have no idea. rather than remove completely, i'd prefer to change this to something like: if ! ./build-support/hooks/pre-commit; then build-support/python/isort-check || true build-support/python/checkstyle-check || true exit 1 fi (i know this leaks knowledge of the checks from pre-commit to build.sh, so we should probably add a build-support/python/check-all that build.sh and pre-commit can each call.) Bill Farner wrote: From a manual run, this is the error: Traceback (most recent call last): File https://builds.apache.org/job/Aurora/ws/build-support/python/checkstyle.venv/local/lib/python2.7/site-packages/twitter/common/app/application.py;, line 738, in _wrap_method return_code = method() File https://builds.apache.org/job/Aurora/ws/build-support/python/checkstyle.venv/local/lib/python2.7/site-packages/twitter/common/app/application.py;, line 760, in lambda main = lambda: main_method(*args, **kwargs) File https://builds.apache.org/job/Aurora/ws/build-support/python/checkstyle.venv/local/lib/python2.7/site-packages/twitter/checkstyle/checker.py;, line 155, in main for filename, line_filter in iterator: File https://builds.apache.org/job/Aurora/ws/build-support/python/checkstyle.venv/local/lib/python2.7/site-packages/twitter/checkstyle/iterators.py;, line 120, in git_iterator diff_commit = repo.rev_parse(options.diff or 'master') File https://builds.apache.org/job/Aurora/ws/build-support/python/checkstyle.venv/local/lib/python2.7/site-packages/git/repo/fun.py;, line 274, in rev_parse obj = name_to_object(repo, rev) File https://builds.apache.org/job/Aurora/ws/build-support/python/checkstyle.venv/local/lib/python2.7/site-packages/git/repo/fun.py;, line 86, in name_to_object raise BadObject(name) BadObject: BadObject: 6d6173746572 Brian Wickman wrote: That's...bizarre. checkstyle-check by default runs checkstyle on the diff against master. Oh son of a ...running build-support/python/checkstyle-check src shows that checkstyle has drifted considerably probably for this very reason. The jenkins build should run checkstyle-check src. Let me fix all the checkstyle breaks + combined with an RB with the checkstyle added back to the build.sh. Submit this in the meantime. Thanks!! - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26093/#review54724 --- On Sept. 26, 2014, 7:33 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26093/ --- (Updated Sept. 26, 2014, 7:33 p.m.) Review request for Aurora and Brian Wickman. Repository: aurora Description --- Not sure why, but this consistently fails in jenkins. Reverting unless you have any ideas how to sort it out. Diffs - build-support/jenkins/build.sh 602b0bcd050cc8270b1f2c2ff3765f8e9319dd22 Diff: https://reviews.apache.org/r/26093/diff/ Testing --- Thanks, Bill Farner
