Re: Review Request 26095: Fix instance summary visualisation.

2014-09-29 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26095/#review54829 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 29, 2014, 4:11

Re: Review Request 26095: Fix instance summary visualisation.

2014-09-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26095/#review54830 --- Ship it! Ship It! - Bill Farner On Sept. 29, 2014, 4:11 p.m.,

Re: Review Request 26095: Fix instance summary visualisation.

2014-09-29 Thread Joshua Cohen
On Sept. 26, 2014, 8:19 p.m., Joshua Cohen wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js, line 440 https://reviews.apache.org/r/26095/diff/1/?file=706256#file706256line440 As far as I can see, allInstances is only used here to get the length, can

Re: Review Request 26095: Fix instance summary visualisation.

2014-09-29 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26095/#review54833 --- Ship it! Looks good to me. - Joshua Cohen On Sept. 29, 2014,

Review Request 26095: Fix instance summary visualisation.

2014-09-26 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26095/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-755