Re: Review Request 26137: Fix help for new update command.

2014-10-06 Thread Joe Smith
> On Sept. 29, 2014, 11:32 p.m., Joe Smith wrote: > > src/main/python/apache/aurora/client/cli/update.py, line 45 > > > > > > Could you update a test case to catch accessing these as properties to > > catch accidental

Re: Review Request 26137: Fix help for new update command.

2014-10-03 Thread Mark Chu-Carroll
> On Sept. 30, 2014, 2:32 a.m., Joe Smith wrote: > > src/main/python/apache/aurora/client/cli/update.py, line 45 > > > > > > Could you update a test case to catch accessing these as properties to > > catch accidental r

Re: Review Request 26137: Fix help for new update command.

2014-10-02 Thread Joe Smith
> On Sept. 29, 2014, 11:32 p.m., Joe Smith wrote: > > src/main/python/apache/aurora/client/cli/update.py, line 45 > > > > > > Could you update a test case to catch accessing these as properties to > > catch accidental

Re: Review Request 26137: Fix help for new update command.

2014-10-02 Thread Mark Chu-Carroll
> On Sept. 30, 2014, 2:32 a.m., Joe Smith wrote: > > src/main/python/apache/aurora/client/cli/update.py, line 45 > > > > > > Could you update a test case to catch accessing these as properties to > > catch accidental r

Re: Review Request 26137: Fix help for new update command.

2014-10-01 Thread David McLaughlin
> On Sept. 30, 2014, 6:32 a.m., Joe Smith wrote: > > src/main/python/apache/aurora/client/cli/update.py, line 45 > > > > > > Could you update a test case to catch accessing these as properties to > > catch accidental r

Re: Review Request 26137: Fix help for new update command.

2014-10-01 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26137/#review55125 --- Ship it! Ship It! - David McLaughlin On Sept. 29, 2014, 3:05 p.m

Re: Review Request 26137: Fix help for new update command.

2014-09-29 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26137/#review54953 --- src/main/python/apache/aurora/client/cli/update.py

Re: Review Request 26137: Fix help for new update command.

2014-09-29 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26137/#review54894 --- Ship it! Ship It! - Zameer Manji On Sept. 29, 2014, 8:05 a.m., M

Review Request 26137: Fix help for new update command.

2014-09-29 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26137/ --- Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-748