Re: Review Request 26376: Implementing non-prod MTTA/R SLA metrics.

2014-10-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26376/#review55984 --- Ship it!

Re: Review Request 26376: Implementing non-prod MTTA/R SLA metrics.

2014-10-09 Thread Maxim Khutornenko
On Oct. 9, 2014, 2:46 p.m., Bill Farner wrote: src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java, line 59 https://reviews.apache.org/r/26376/diff/1/?file=714221#file714221line59 Can you instead export these values into a MapString, AtomicLong and validate

Re: Review Request 26376: Implementing non-prod MTTA/R SLA metrics.

2014-10-09 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26376/ --- (Updated Oct. 9, 2014, 9:04 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 26376: Implementing non-prod MTTA/R SLA metrics.

2014-10-08 Thread Maxim Khutornenko
On Oct. 8, 2014, 5:32 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java, line 81 https://reviews.apache.org/r/26376/diff/1/?file=714219#file714219line81 Seems like we're moving towards identical calculations for prod and non-prod tasks.

Review Request 26376: Implementing non-prod MTTA/R SLA metrics.

2014-10-06 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26376/ --- Review request for Aurora. Bugs: AURORA-774

Re: Review Request 26376: Implementing non-prod MTTA/R SLA metrics.

2014-10-06 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26376/ --- (Updated Oct. 6, 2014, 7:10 p.m.) Review request for Aurora and Bill Farner.