---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26383/
---
(Updated Oct. 17, 2014, 10:09 a.m.)
Review request for Aurora, Joe Smith,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26383/#review57163
---
src/main/python/apache/aurora/executor/common/health_checker.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26383/
---
(Updated Oct. 17, 2014, 11:28 a.m.)
Review request for Aurora, Joe Smith,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26383/#review57197
---
Ship it!
Ship It!
- Maxim Khutornenko
On Oct. 17, 2014, 6:28
On Oct. 17, 2014, 12:18 p.m., Maxim Khutornenko wrote:
Ship It!
Bill Farner mentioned that once you give a shipit, it is good to go (and that
he is not needed for the review). Is it okay if you commit the change?
Thanks!
- David
On Oct. 17, 2014, 7:30 p.m., David Pan wrote:
Ship It!
This is on master. Thanks!
- Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26383/#review57199
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26383/
---
(Updated Oct. 16, 2014, 9:47 a.m.)
Review request for Aurora, Joe Smith, Brian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26383/
---
(Updated Oct. 16, 2014, 3 p.m.)
Review request for Aurora, Joe Smith, Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26383/#review57019
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 16, 2014, 3:04 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26383/
---
(Updated Oct. 13, 2014, 6:22 p.m.)
Review request for Aurora, Joe Smith, Brian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26383/
---
(Updated Oct. 13, 2014, 12:27 p.m.)
Review request for Aurora, Joe Smith,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26383/
---
(Updated Oct. 13, 2014, 1:53 p.m.)
Review request for Aurora, Joe Smith, Brian
On Oct. 9, 2014, 2:53 p.m., Bill Farner wrote:
src/main/python/apache/aurora/executor/common/health_checker.py, line 66
https://reviews.apache.org/r/26383/diff/3/?file=716355#file716355line66
FWIW i actually meant to suggest that the snooze has no concept of time
at all. If the
On Oct. 9, 2014, 2:53 p.m., Bill Farner wrote:
src/main/python/apache/aurora/executor/common/health_checker.py, line 66
https://reviews.apache.org/r/26383/diff/3/?file=716355#file716355line66
FWIW i actually meant to suggest that the snooze has no concept of time
at all. If the
On Oct. 9, 2014, 2:53 p.m., Bill Farner wrote:
src/main/python/apache/aurora/executor/common/health_checker.py, line 66
https://reviews.apache.org/r/26383/diff/3/?file=716355#file716355line66
FWIW i actually meant to suggest that the snooze has no concept of time
at all. If the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26383/#review55985
---
src/main/python/apache/aurora/executor/common/health_checker.py
On Oct. 9, 2014, 7:53 a.m., Bill Farner wrote:
src/main/python/apache/aurora/executor/common/health_checker.py, line 66
https://reviews.apache.org/r/26383/diff/3/?file=716355#file716355line66
FWIW i actually meant to suggest that the snooze has no concept of time
at all. If the
On Oct. 9, 2014, 7:53 a.m., Bill Farner wrote:
src/main/python/apache/aurora/executor/common/health_checker.py, line 66
https://reviews.apache.org/r/26383/diff/3/?file=716355#file716355line66
FWIW i actually meant to suggest that the snooze has no concept of time
at all. If the
On Oct. 9, 2014, 7:53 a.m., Bill Farner wrote:
src/main/python/apache/aurora/executor/common/health_checker.py, line 66
https://reviews.apache.org/r/26383/diff/3/?file=716355#file716355line66
FWIW i actually meant to suggest that the snooze has no concept of time
at all. If the
On Oct. 9, 2014, 2:53 p.m., Bill Farner wrote:
src/main/python/apache/aurora/executor/common/health_checker.py, line 66
https://reviews.apache.org/r/26383/diff/3/?file=716355#file716355line66
FWIW i actually meant to suggest that the snooze has no concept of time
at all. If the
On Oct. 9, 2014, 7:53 a.m., Bill Farner wrote:
src/main/python/apache/aurora/executor/common/health_checker.py, line 66
https://reviews.apache.org/r/26383/diff/3/?file=716355#file716355line66
FWIW i actually meant to suggest that the snooze has no concept of time
at all. If the
On Oct. 9, 2014, 2:53 p.m., Bill Farner wrote:
src/main/python/apache/aurora/executor/common/health_checker.py, line 66
https://reviews.apache.org/r/26383/diff/3/?file=716355#file716355line66
FWIW i actually meant to suggest that the snooze has no concept of time
at all. If the
I feel like we should err on the side of correctness here, rather than
simplicity? The dangers of someone accidentally leaving health checks
disabled indefinitely (on a service that has opted in to health checks) are
not insignificant.
On Thu, Oct 9, 2014 at 1:34 PM, Kevin Sweeney
On Oct. 9, 2014, 2:53 p.m., Bill Farner wrote:
src/main/python/apache/aurora/executor/common/health_checker.py, line 66
https://reviews.apache.org/r/26383/diff/3/?file=716355#file716355line66
FWIW i actually meant to suggest that the snooze has no concept of time
at all. If the
On Oct. 6, 2014, 10:55 p.m., Joshua Cohen wrote:
src/main/python/apache/aurora/config/schema/base.py, line 69
https://reviews.apache.org/r/26383/diff/1/?file=714259#file714259line69
Do we need to make this path configurable? I'm trying to think of a
reason that someone might want
On Oct. 6, 2014, 10:40 p.m., Brian Wickman wrote:
docs/configuration-reference.md, lines 359-360
https://reviews.apache.org/r/26383/diff/1/?file=714257#file714257line359
Is there any reason this needs to be configurable? Why not just
hardcode the filename as '.healthchecksnooze'
I'm +1 on removing the time control as well. If you need to extend the
snooze you could always touch -m the snooze file?
On Wed, Oct 8, 2014 at 9:51 AM, Bill Farner wfar...@apache.org wrote:
On Oct. 6, 2014, 10:40 p.m., Brian Wickman wrote:
docs/configuration-reference.md, lines 359-360
On Oct. 6, 2014, 10:55 p.m., Joshua Cohen wrote:
src/main/python/apache/aurora/executor/common/health_checker.py, lines
157-158
https://reviews.apache.org/r/26383/diff/1/?file=714260#file714260line157
I know you didn't originate this pattern, but it seems odd for these
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26383/
---
(Updated Oct. 9, 2014, 12:43 a.m.)
Review request for Aurora, Joe Smith, Brian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26383/
---
(Updated Oct. 9, 2014, 12:46 a.m.)
Review request for Aurora, Joe Smith, Brian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26383/#review55924
---
src/main/python/apache/aurora/executor/common/health_checker.py
On Oct. 8, 2014, 6:09 p.m., Zameer Manji wrote:
src/main/python/apache/aurora/executor/common/health_checker.py, line 41
https://reviews.apache.org/r/26383/diff/2/?file=716291#file716291line41
Why add a default value here?
David Pan wrote:
The reason why
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26383/
---
(Updated Oct. 9, 2014, 1:56 a.m.)
Review request for Aurora, Joe Smith, Brian
On Oct. 6, 2014, 10:40 p.m., Brian Wickman wrote:
docs/configuration-reference.md, lines 359-360
https://reviews.apache.org/r/26383/diff/1/?file=714257#file714257line359
Is there any reason this needs to be configurable? Why not just
hardcode the filename as '.healthchecksnooze'
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26383/
---
Review request for Aurora, Joe Smith, Brian Wickman, and Zameer Manji.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26383/#review55592
---
docs/configuration-reference.md
36 matches
Mail list logo