Review Request 26417: Change JSON result of job status when job isn't found.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26417/ --- Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-803 https://issues.apache.org/jira/browse/aurora-803 Repository: aurora Description --- Instead of just exiting with an error code, return a valid JSON structure when a user calls aurora job status, and no job matching the jobspec is running. Also, remove a bunch of pants labels from build files, which generated warnings while building the tests. Diffs - src/main/python/apache/aurora/client/cli/context.py 0816ac02846c30e0beab5c0339aca38f15c4ae10 src/main/python/apache/aurora/client/cli/jobs.py 103fb53cb5101d3e025d8712e3887bccdfbb6aeb src/test/python/apache/aurora/client/cli/BUILD 8ce6bd5b7faa1579372fb6935180ea982af64af8 src/test/python/apache/aurora/client/cli/test_status.py bd30b11022ee0d1fb38da9f6efd4d9c5923b7d13 Diff: https://reviews.apache.org/r/26417/diff/ Testing --- Ran all unit tests; added new test for the empty job list json case. Thanks, Mark Chu-Carroll
Re: Review Request 26417: Change JSON result of job status when job isn't found.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26417/#review55663 --- Ship it! Ship It! - David McLaughlin On Oct. 7, 2014, 5:12 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26417/ --- (Updated Oct. 7, 2014, 5:12 p.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-803 https://issues.apache.org/jira/browse/aurora-803 Repository: aurora Description --- Instead of just exiting with an error code, return a valid JSON structure when a user calls aurora job status, and no job matching the jobspec is running. Also, remove a bunch of pants labels from build files, which generated warnings while building the tests. Diffs - src/main/python/apache/aurora/client/cli/context.py 0816ac02846c30e0beab5c0339aca38f15c4ae10 src/main/python/apache/aurora/client/cli/jobs.py 103fb53cb5101d3e025d8712e3887bccdfbb6aeb src/test/python/apache/aurora/client/cli/BUILD 8ce6bd5b7faa1579372fb6935180ea982af64af8 src/test/python/apache/aurora/client/cli/test_status.py bd30b11022ee0d1fb38da9f6efd4d9c5923b7d13 Diff: https://reviews.apache.org/r/26417/diff/ Testing --- Ran all unit tests; added new test for the empty job list json case. Thanks, Mark Chu-Carroll
Re: Review Request 26417: Change JSON result of job status when job isn't found.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26417/#review55664 --- Ship it! Ship It! - Zameer Manji On Oct. 7, 2014, 10:12 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26417/ --- (Updated Oct. 7, 2014, 10:12 a.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-803 https://issues.apache.org/jira/browse/aurora-803 Repository: aurora Description --- Instead of just exiting with an error code, return a valid JSON structure when a user calls aurora job status, and no job matching the jobspec is running. Also, remove a bunch of pants labels from build files, which generated warnings while building the tests. Diffs - src/main/python/apache/aurora/client/cli/context.py 0816ac02846c30e0beab5c0339aca38f15c4ae10 src/main/python/apache/aurora/client/cli/jobs.py 103fb53cb5101d3e025d8712e3887bccdfbb6aeb src/test/python/apache/aurora/client/cli/BUILD 8ce6bd5b7faa1579372fb6935180ea982af64af8 src/test/python/apache/aurora/client/cli/test_status.py bd30b11022ee0d1fb38da9f6efd4d9c5923b7d13 Diff: https://reviews.apache.org/r/26417/diff/ Testing --- Ran all unit tests; added new test for the empty job list json case. Thanks, Mark Chu-Carroll
