Re: Review Request 26424: Disable requests http connection logging.

2014-10-14 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26424/#review56610 --- Ship it! Sorry for the delay on this, i didn't realize i was on

Re: Review Request 26424: Disable requests http connection logging.

2014-10-14 Thread Joshua Cohen
On Oct. 15, 2014, 12:02 a.m., Bill Farner wrote: Sorry for the delay on this, i didn't realize i was on the hook to commit. Now on master: $ git log -1 commit 72fed752fcdbacf0f29e7eaef56c177f5ec9fcf0 Author: Joshua Cohen jco...@twopensource.com Date: Tue Oct 14

Re: Review Request 26424: Disable requests http connection logging.

2014-10-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26424/#review55805 --- src/main/python/apache/aurora/common/transport.py

Re: Review Request 26424: Disable requests http connection logging.

2014-10-08 Thread Bill Farner
On Oct. 8, 2014, 4:28 p.m., Bill Farner wrote: src/main/python/apache/aurora/common/transport.py, line 28 https://reviews.apache.org/r/26424/diff/2/?file=714839#file714839line28 I find it odd to extract a function for this. If i were a newcomer, i would immediately inline this

Re: Review Request 26424: Disable requests http connection logging.

2014-10-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26424/#review55818 --- Ship it! Ship It! - Bill Farner On Oct. 8, 2014, 4:54 p.m.,

Re: Review Request 26424: Disable requests http connection logging.

2014-10-08 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26424/#review55860 --- Ship it! Inlining inside `__init__` WFM. thanks! - Joe Smith On

Review Request 26424: Disable requests http connection logging.

2014-10-07 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26424/ --- Review request for Aurora, Joe Smith and Bill Farner. Bugs: AURORA-770

Re: Review Request 26424: Disable requests http connection logging.

2014-10-07 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26424/#review55698 --- Ship it! src/test/python/apache/aurora/common/test_transport.py

Re: Review Request 26424: Disable requests http connection logging.

2014-10-07 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26424/ --- (Updated Oct. 7, 2014, 8:32 p.m.) Review request for Aurora, Joe Smith and

Re: Review Request 26424: Disable requests http connection logging.

2014-10-07 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26424/#review55727 --- Ship it! Aha, here we go. Thanks!! - Joe Smith On Oct. 7, 2014,