Re: Review Request 26425: Fixing quota checking for updates.

2014-10-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26425/#review55991 --- Ship it! Ship It! - Bill Farner On Oct. 8, 2014, 10:58 p.m.,

Re: Review Request 26425: Fixing quota checking for updates.

2014-10-08 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26425/#review55865 --- I'm underwater on reviews and unable to review this promptly -

Re: Review Request 26425: Fixing quota checking for updates.

2014-10-08 Thread Maxim Khutornenko
On Oct. 8, 2014, 5:17 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java, line 90 https://reviews.apache.org/r/26425/diff/1/?file=714851#file714851line90 These methods read strangely to me: check the quota of this task config, and check the

Re: Review Request 26425: Fixing quota checking for updates.

2014-10-08 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26425/ --- (Updated Oct. 8, 2014, 10:58 p.m.) Review request for Aurora and Bill Farner.

Review Request 26425: Fixing quota checking for updates.

2014-10-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26425/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-802