Review Request 26445: Fix error in incorrect deprecation warning on v1 ssh command.

2014-10-08 Thread Mark Chu-Carroll

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26445/
---

Review request for Aurora, David McLaughlin and Zameer Manji.


Bugs: aurora-804
https://issues.apache.org/jira/browse/aurora-804


Repository: aurora


Description
---

The error message incorrectly displayed a list-value for the
--tunnels parameter, when in fact it should expand the list
into multiple instances of --tunnels.


Diffs
-

  src/main/python/apache/aurora/client/commands/ssh.py 
9ee94a0bdfd8bbc030ae978e2ac3fe39571b4ce2 
  src/test/python/apache/aurora/client/commands/test_ssh.py 
c5ca66e378bfc97c40a406a758ae4dfaef8ab2c8 

Diff: https://reviews.apache.org/r/26445/diff/


Testing
---

New unit test.


Thanks,

Mark Chu-Carroll



Re: Review Request 26445: Fix error in incorrect deprecation warning on v1 ssh command.

2014-10-08 Thread Zameer Manji

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26445/#review55840
---

Ship it!


Ship It!

- Zameer Manji


On Oct. 8, 2014, 8:58 a.m., Mark Chu-Carroll wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/26445/
 ---
 
 (Updated Oct. 8, 2014, 8:58 a.m.)
 
 
 Review request for Aurora, David McLaughlin and Zameer Manji.
 
 
 Bugs: aurora-804
 https://issues.apache.org/jira/browse/aurora-804
 
 
 Repository: aurora
 
 
 Description
 ---
 
 The error message incorrectly displayed a list-value for the
 --tunnels parameter, when in fact it should expand the list
 into multiple instances of --tunnels.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/client/commands/ssh.py 
 9ee94a0bdfd8bbc030ae978e2ac3fe39571b4ce2 
   src/test/python/apache/aurora/client/commands/test_ssh.py 
 c5ca66e378bfc97c40a406a758ae4dfaef8ab2c8 
 
 Diff: https://reviews.apache.org/r/26445/diff/
 
 
 Testing
 ---
 
 New unit test.
 
 
 Thanks,
 
 Mark Chu-Carroll
 




Re: Review Request 26445: Fix error in incorrect deprecation warning on v1 ssh command.

2014-10-08 Thread David McLaughlin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26445/#review55849
---

Ship it!


Ship It!

- David McLaughlin


On Oct. 8, 2014, 3:58 p.m., Mark Chu-Carroll wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/26445/
 ---
 
 (Updated Oct. 8, 2014, 3:58 p.m.)
 
 
 Review request for Aurora, David McLaughlin and Zameer Manji.
 
 
 Bugs: aurora-804
 https://issues.apache.org/jira/browse/aurora-804
 
 
 Repository: aurora
 
 
 Description
 ---
 
 The error message incorrectly displayed a list-value for the
 --tunnels parameter, when in fact it should expand the list
 into multiple instances of --tunnels.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/client/commands/ssh.py 
 9ee94a0bdfd8bbc030ae978e2ac3fe39571b4ce2 
   src/test/python/apache/aurora/client/commands/test_ssh.py 
 c5ca66e378bfc97c40a406a758ae4dfaef8ab2c8 
 
 Diff: https://reviews.apache.org/r/26445/diff/
 
 
 Testing
 ---
 
 New unit test.
 
 
 Thanks,
 
 Mark Chu-Carroll