Re: Review Request 26478: Add a flag to deduplicate storage snapshots

2014-10-15 Thread Kevin Sweeney
On Oct. 15, 2014, 11:54 a.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotDeduplicator.java, line 56 https://reviews.apache.org/r/26478/diff/3/?file=721240#file721240line56 'reduplicate' doesn't sit well with me. Perhaps 'normalize' and

Re: Review Request 26478: Add a flag to deduplicate storage snapshots

2014-10-15 Thread Kevin Sweeney
On Oct. 9, 2014, 10:30 a.m., Maxim Khutornenko wrote: src/main/thrift/org/apache/aurora/gen/storage.thrift, line 205 https://reviews.apache.org/r/26478/diff/2/?file=716383#file716383line205 Please, document fields. What is taskConfigId here? Documented all fields. On Oct. 9,

Re: Review Request 26478: Add a flag to deduplicate storage snapshots

2014-10-15 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26478/#review56795 --- Ship it! Ship It! - Maxim Khutornenko On Oct. 15, 2014, 7:52

Re: Review Request 26478: Add a flag to deduplicate storage snapshots

2014-10-15 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26478/ --- (Updated Oct. 15, 2014, 2:32 p.m.) Review request for Aurora, Maxim

Re: Review Request 26478: Add a flag to deduplicate storage snapshots

2014-10-15 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26478/ --- (Updated Oct. 15, 2014, 5:05 p.m.) Review request for Aurora, Maxim

Re: Review Request 26478: Add a flag to deduplicate storage snapshots

2014-10-14 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26478/#review56562 --- Ping? Any progress here? - Bill Farner On Oct. 9, 2014, 2:39

Re: Review Request 26478: Add a flag to deduplicate storage snapshots

2014-10-14 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26478/ --- (Updated Oct. 14, 2014, 6:32 p.m.) Review request for Aurora, David

Re: Review Request 26478: Add a flag to deduplicate storage snapshots

2014-10-14 Thread Kevin Sweeney
On Oct. 9, 2014, 8:30 a.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java, line 86 https://reviews.apache.org/r/26478/diff/2/?file=716376#file716376line86 Method interceptors should work fine for package-priviate methods [1].

Re: Review Request 26478: Add a flag to deduplicate storage snapshots

2014-10-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26478/#review55986 ---

Re: Review Request 26478: Add a flag to deduplicate storage snapshots

2014-10-09 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26478/#review56010 ---

Re: Review Request 26478: Add a flag to deduplicate storage snapshots

2014-10-09 Thread Kevin Sweeney
On Oct. 9, 2014, 10:30 a.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotDeduplicator.java, line 133 https://reviews.apache.org/r/26478/diff/2/?file=716380#file716380line133 There is a remote possibility of numOutputTasks to be zero in a

Review Request 26478: Add a flag to deduplicate storage snapshots

2014-10-08 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26478/ --- Review request for Aurora, David McLaughlin, Bill Farner, and Zameer Manji.

Re: Review Request 26478: Add a flag to deduplicate storage snapshots

2014-10-08 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26478/ --- (Updated Oct. 8, 2014, 7:39 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 26478: Add a flag to deduplicate storage snapshots

2014-10-08 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26478/#review55943 --- Ship it! Ship It! - Zameer Manji On Oct. 8, 2014, 7:39 p.m.,