Review Request 26504: Restore JDK8 compatibility
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26504/
---
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Repository: aurora
Description
---
I misconfigured my IDE and noticed that we'd stopped compiling on JDK8.
Diffs
-
src/main/java/org/apache/aurora/scheduler/sla/SlaUtil.java
7ecb05ae87058e7a25d88959cf629b2da17dc520
src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java
d3c90416e48e25d83f28f966b21c018ee2a1ac27
Diff: https://reviews.apache.org/r/26504/diff/
Testing
---
./gradlew -Pq build
With
```
diff --git a/build.gradle b/build.gradle
index 8f7eed0..af3d4ba 100644
--- a/build.gradle
+++ b/build.gradle
@@ -38,8 +38,8 @@ def httpAssetsPath = 'scheduler/assets'
def thriftVersion = '0.9.1'
compileJava {
- sourceCompatibility = 1.7
- targetCompatibility = 1.7
+ sourceCompatibility = 1.8
+ targetCompatibility = 1.8
}
```
Thanks,
Kevin Sweeney
Re: Review Request 26504: Restore JDK8 compatibility
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26504/#review56003
---
Ship it!
Ship It!
- Maxim Khutornenko
On Oct. 9, 2014, 4:50 p.m., Kevin Sweeney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26504/
---
(Updated Oct. 9, 2014, 4:50 p.m.)
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Repository: aurora
Description
---
I misconfigured my IDE and noticed that we'd stopped compiling on JDK8.
Diffs
-
src/main/java/org/apache/aurora/scheduler/sla/SlaUtil.java
7ecb05ae87058e7a25d88959cf629b2da17dc520
src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java
d3c90416e48e25d83f28f966b21c018ee2a1ac27
Diff: https://reviews.apache.org/r/26504/diff/
Testing
---
./gradlew -Pq build
With
```
diff --git a/build.gradle b/build.gradle
index 8f7eed0..af3d4ba 100644
--- a/build.gradle
+++ b/build.gradle
@@ -38,8 +38,8 @@ def httpAssetsPath = 'scheduler/assets'
def thriftVersion = '0.9.1'
compileJava {
- sourceCompatibility = 1.7
- targetCompatibility = 1.7
+ sourceCompatibility = 1.8
+ targetCompatibility = 1.8
}
```
Thanks,
Kevin Sweeney
Re: Review Request 26504: Restore JDK8 compatibility
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26504/#review56011
---
Ship it!
Ship It!
- Joshua Cohen
On Oct. 9, 2014, 4:50 p.m., Kevin Sweeney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26504/
---
(Updated Oct. 9, 2014, 4:50 p.m.)
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Repository: aurora
Description
---
I misconfigured my IDE and noticed that we'd stopped compiling on JDK8.
Diffs
-
src/main/java/org/apache/aurora/scheduler/sla/SlaUtil.java
7ecb05ae87058e7a25d88959cf629b2da17dc520
src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java
d3c90416e48e25d83f28f966b21c018ee2a1ac27
Diff: https://reviews.apache.org/r/26504/diff/
Testing
---
./gradlew -Pq build
With
```
diff --git a/build.gradle b/build.gradle
index 8f7eed0..af3d4ba 100644
--- a/build.gradle
+++ b/build.gradle
@@ -38,8 +38,8 @@ def httpAssetsPath = 'scheduler/assets'
def thriftVersion = '0.9.1'
compileJava {
- sourceCompatibility = 1.7
- targetCompatibility = 1.7
+ sourceCompatibility = 1.8
+ targetCompatibility = 1.8
}
```
Thanks,
Kevin Sweeney
Re: Review Request 26504: Restore JDK8 compatibility
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26504/#review56012
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 9, 2014, 9:50 a.m., Kevin Sweeney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26504/
---
(Updated Oct. 9, 2014, 9:50 a.m.)
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Repository: aurora
Description
---
I misconfigured my IDE and noticed that we'd stopped compiling on JDK8.
Diffs
-
src/main/java/org/apache/aurora/scheduler/sla/SlaUtil.java
7ecb05ae87058e7a25d88959cf629b2da17dc520
src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java
d3c90416e48e25d83f28f966b21c018ee2a1ac27
Diff: https://reviews.apache.org/r/26504/diff/
Testing
---
./gradlew -Pq build
With
```
diff --git a/build.gradle b/build.gradle
index 8f7eed0..af3d4ba 100644
--- a/build.gradle
+++ b/build.gradle
@@ -38,8 +38,8 @@ def httpAssetsPath = 'scheduler/assets'
def thriftVersion = '0.9.1'
compileJava {
- sourceCompatibility = 1.7
- targetCompatibility = 1.7
+ sourceCompatibility = 1.8
+ targetCompatibility = 1.8
}
```
Thanks,
Kevin Sweeney
