Re: Review Request 26716: Use JobKey when getting roles to authenticate against.

2014-10-15 Thread Kevin Sweeney

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26716/#review56747
---

Ship it!


Ship It!

- Kevin Sweeney


On Oct. 14, 2014, 5:23 p.m., Zameer Manji wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/26716/
 ---
 
 (Updated Oct. 14, 2014, 5:23 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Bill Farner.
 
 
 Bugs: AURORA-837
 https://issues.apache.org/jira/browse/AURORA-837
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Use JobKey when getting roles to authenticate against.
 
 
 Diffs
 -
 
   src/main/java/org/apache/aurora/scheduler/base/Query.java 
 d8572bb21a92025e7a51cf18d5bdf00fc1281078 
   
 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
  a43e5d7748c22d60f56f03a8a3d52949faebeff2 
   src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 
 3b61ff3c237de3ec5224a239d1756ce8d7093a52 
   
 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
  0d51f7dc367081f72090736e36605bf363f3395e 
 
 Diff: https://reviews.apache.org/r/26716/diff/
 
 
 Testing
 ---
 
 ./gradlew clean test
 
 
 Thanks,
 
 Zameer Manji
 




Review Request 26716: Use JobKey when getting roles to authenticate against.

2014-10-14 Thread Zameer Manji

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26716/
---

Review request for Aurora.


Repository: aurora


Description
---

Use JobKey when getting roles to authenticate against.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/base/Query.java 
d8572bb21a92025e7a51cf18d5bdf00fc1281078 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
a43e5d7748c22d60f56f03a8a3d52949faebeff2 
  src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 
3b61ff3c237de3ec5224a239d1756ce8d7093a52 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 0d51f7dc367081f72090736e36605bf363f3395e 

Diff: https://reviews.apache.org/r/26716/diff/


Testing
---


Thanks,

Zameer Manji



Re: Review Request 26716: Use JobKey when getting roles to authenticate against.

2014-10-14 Thread Zameer Manji

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26716/
---

(Updated Oct. 14, 2014, 5:23 p.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Bugs: AURORA-837
https://issues.apache.org/jira/browse/AURORA-837


Repository: aurora


Description
---

Use JobKey when getting roles to authenticate against.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/base/Query.java 
d8572bb21a92025e7a51cf18d5bdf00fc1281078 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
a43e5d7748c22d60f56f03a8a3d52949faebeff2 
  src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 
3b61ff3c237de3ec5224a239d1756ce8d7093a52 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 0d51f7dc367081f72090736e36605bf363f3395e 

Diff: https://reviews.apache.org/r/26716/diff/


Testing (updated)
---

./gradlew clean test


Thanks,

Zameer Manji



Re: Review Request 26716: Use JobKey when getting roles to authenticate against.

2014-10-14 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26716/#review56631
---

Ship it!


Ship It!

- Bill Farner


On Oct. 15, 2014, 12:23 a.m., Zameer Manji wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/26716/
 ---
 
 (Updated Oct. 15, 2014, 12:23 a.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Bill Farner.
 
 
 Bugs: AURORA-837
 https://issues.apache.org/jira/browse/AURORA-837
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Use JobKey when getting roles to authenticate against.
 
 
 Diffs
 -
 
   src/main/java/org/apache/aurora/scheduler/base/Query.java 
 d8572bb21a92025e7a51cf18d5bdf00fc1281078 
   
 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
  a43e5d7748c22d60f56f03a8a3d52949faebeff2 
   src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 
 3b61ff3c237de3ec5224a239d1756ce8d7093a52 
   
 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
  0d51f7dc367081f72090736e36605bf363f3395e 
 
 Diff: https://reviews.apache.org/r/26716/diff/
 
 
 Testing
 ---
 
 ./gradlew clean test
 
 
 Thanks,
 
 Zameer Manji