Re: Review Request 26720: Limit the amount of work done while bootstrapping thrift.
On Oct. 15, 2014, 1:06 a.m., Kevin Sweeney wrote: build-support/thrift/Makefile, line 49 https://reviews.apache.org/r/26720/diff/1/?file=721229#file721229line49 Not your issue but this line appears impossible to execute. Removed. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26720/#review56632 --- On Oct. 15, 2014, 12:59 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26720/ --- (Updated Oct. 15, 2014, 12:59 a.m.) Review request for Aurora, Kevin Sweeney and Zameer Manji. Repository: aurora Description --- Limit the amount of work done while bootstrapping thrift. Diffs - build-support/thrift/Makefile 2b62b15ee946862b2bea6a4df2b7fdec2be1426a Diff: https://reviews.apache.org/r/26720/diff/ Testing --- Through a single trial on my workstation: Before this patch: $ git clean -fdx $ time ./gradlew build /dev/null real 2m2.406s user 5m14.128s sys 0m12.222s After this patch: $ git clean -fdx $ time ./gradlew build /dev/null real 1m30.926s user 5m18.393s sys 0m11.148s Thanks, Bill Farner
Re: Review Request 26720: Limit the amount of work done while bootstrapping thrift.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26720/ --- (Updated Oct. 15, 2014, 4:22 p.m.) Review request for Aurora, Kevin Sweeney and Zameer Manji. Repository: aurora Description --- Limit the amount of work done while bootstrapping thrift. Diffs (updated) - build-support/thrift/Makefile 2b62b15ee946862b2bea6a4df2b7fdec2be1426a Diff: https://reviews.apache.org/r/26720/diff/ Testing --- Through a single trial on my workstation: Before this patch: $ git clean -fdx $ time ./gradlew build /dev/null real2m2.406s user5m14.128s sys 0m12.222s After this patch: $ git clean -fdx $ time ./gradlew build /dev/null real1m30.926s user5m18.393s sys 0m11.148s Thanks, Bill Farner
Review Request 26720: Limit the amount of work done while bootstrapping thrift.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26720/ --- Review request for Aurora, Kevin Sweeney and Zameer Manji. Repository: aurora Description --- Limit the amount of work done while bootstrapping thrift. Diffs - build-support/thrift/Makefile 2b62b15ee946862b2bea6a4df2b7fdec2be1426a Diff: https://reviews.apache.org/r/26720/diff/ Testing --- Through a single trial on my workstation: Before this patch: $ git clean -fdx $ time ./gradlew build /dev/null real2m2.406s user5m14.128s sys 0m12.222s After this patch: $ git clean -fdx $ time ./gradlew build /dev/null real1m30.926s user5m18.393s sys 0m11.148s Thanks, Bill Farner
Re: Review Request 26720: Limit the amount of work done while bootstrapping thrift.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26720/#review56632 --- Ship it! build-support/thrift/Makefile https://reviews.apache.org/r/26720/#comment97016 Not your issue but this line appears impossible to execute. - Kevin Sweeney On Oct. 14, 2014, 5:59 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26720/ --- (Updated Oct. 14, 2014, 5:59 p.m.) Review request for Aurora, Kevin Sweeney and Zameer Manji. Repository: aurora Description --- Limit the amount of work done while bootstrapping thrift. Diffs - build-support/thrift/Makefile 2b62b15ee946862b2bea6a4df2b7fdec2be1426a Diff: https://reviews.apache.org/r/26720/diff/ Testing --- Through a single trial on my workstation: Before this patch: $ git clean -fdx $ time ./gradlew build /dev/null real 2m2.406s user 5m14.128s sys 0m12.222s After this patch: $ git clean -fdx $ time ./gradlew build /dev/null real 1m30.926s user 5m18.393s sys 0m11.148s Thanks, Bill Farner
