Re: Review Request 26821: Handle resourceOffers callback asynchronsly.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26821/#review56995 --- src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java https://reviews.apache.org/r/26821/#comment97432 nit, move to previous line. src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java https://reviews.apache.org/r/26821/#comment97433 s/Augment/augment - Joshua Cohen On Oct. 16, 2014, 8:26 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26821/ --- (Updated Oct. 16, 2014, 8:26 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-848 https://issues.apache.org/jira/browse/AURORA-848 Repository: aurora Description --- Handle resourceOffers callback asynchronsly. Diffs - src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java e4439f6a28535f774cfdc1000a0d6d2976254aee src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 31c8650a2cf211290ea4197f97c840f78cfd7646 src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 606b5b03616c8ddbc83cb89f1206feb409f187c2 Diff: https://reviews.apache.org/r/26821/diff/ Testing --- ./gradlew clean build Thanks, Zameer Manji
Re: Review Request 26821: Handle resourceOffers callback asynchronsly.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26821/#review56996 --- src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java https://reviews.apache.org/r/26821/#comment97434 Nit: the whole piece of software is called the scheduler, maybe use somethign more specific (like incoming Mesos message handler) here. - Kevin Sweeney On Oct. 16, 2014, 1:26 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26821/ --- (Updated Oct. 16, 2014, 1:26 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-848 https://issues.apache.org/jira/browse/AURORA-848 Repository: aurora Description --- Handle resourceOffers callback asynchronsly. Diffs - src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java e4439f6a28535f774cfdc1000a0d6d2976254aee src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 31c8650a2cf211290ea4197f97c840f78cfd7646 src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 606b5b03616c8ddbc83cb89f1206feb409f187c2 Diff: https://reviews.apache.org/r/26821/diff/ Testing --- ./gradlew clean build Thanks, Zameer Manji
Re: Review Request 26821: Handle resourceOffers callback asynchronsly.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26821/ --- (Updated Oct. 16, 2014, 1:59 p.m.) Review request for Aurora and Bill Farner. Changes --- Feedback. Bugs: AURORA-848 https://issues.apache.org/jira/browse/AURORA-848 Repository: aurora Description --- Handle resourceOffers callback asynchronsly. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java e4439f6a28535f774cfdc1000a0d6d2976254aee src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 31c8650a2cf211290ea4197f97c840f78cfd7646 src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 606b5b03616c8ddbc83cb89f1206feb409f187c2 Diff: https://reviews.apache.org/r/26821/diff/ Testing --- ./gradlew clean build Thanks, Zameer Manji
Re: Review Request 26821: Handle resourceOffers callback asynchronsly.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26821/#review57001 --- Ship it! src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java https://reviews.apache.org/r/26821/#comment97440 remove newline src/main/java/org/apache/aurora/scheduler/SchedulerModule.java https://reviews.apache.org/r/26821/#comment97442 // TODO(zmanji): Create singleThreadedExecutor (non-scheduled) variant. - Bill Farner On Oct. 16, 2014, 8:59 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26821/ --- (Updated Oct. 16, 2014, 8:59 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-848 https://issues.apache.org/jira/browse/AURORA-848 Repository: aurora Description --- Handle resourceOffers callback asynchronsly. Diffs - src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java e4439f6a28535f774cfdc1000a0d6d2976254aee src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 31c8650a2cf211290ea4197f97c840f78cfd7646 src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 606b5b03616c8ddbc83cb89f1206feb409f187c2 Diff: https://reviews.apache.org/r/26821/diff/ Testing --- ./gradlew clean build Thanks, Zameer Manji
Re: Review Request 26821: Handle resourceOffers callback asynchronsly.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26821/ --- (Updated Oct. 16, 2014, 2:15 p.m.) Review request for Aurora and Bill Farner. Changes --- Bill's feedback. Bugs: AURORA-848 https://issues.apache.org/jira/browse/AURORA-848 Repository: aurora Description --- Handle resourceOffers callback asynchronsly. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java e4439f6a28535f774cfdc1000a0d6d2976254aee src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 31c8650a2cf211290ea4197f97c840f78cfd7646 src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 606b5b03616c8ddbc83cb89f1206feb409f187c2 Diff: https://reviews.apache.org/r/26821/diff/ Testing --- ./gradlew clean build Thanks, Zameer Manji
Re: Review Request 26821: Handle resourceOffers callback asynchronsly.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26821/#review57003 --- Looks like you need to run this through quality checks. Build fails ./gradlew build -Pq - Bill Farner On Oct. 16, 2014, 9:15 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26821/ --- (Updated Oct. 16, 2014, 9:15 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-848 https://issues.apache.org/jira/browse/AURORA-848 Repository: aurora Description --- Handle resourceOffers callback asynchronsly. Diffs - src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java e4439f6a28535f774cfdc1000a0d6d2976254aee src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 31c8650a2cf211290ea4197f97c840f78cfd7646 src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 606b5b03616c8ddbc83cb89f1206feb409f187c2 Diff: https://reviews.apache.org/r/26821/diff/ Testing --- ./gradlew clean build Thanks, Zameer Manji
Re: Review Request 26821: Handle resourceOffers callback asynchronsly.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26821/ --- (Updated Oct. 16, 2014, 2:27 p.m.) Review request for Aurora and Bill Farner. Changes --- Fix checkstyle issues. Bugs: AURORA-848 https://issues.apache.org/jira/browse/AURORA-848 Repository: aurora Description --- Handle resourceOffers callback asynchronsly. Diffs (updated) - docs/configuration-reference.md 5166d45ddf95ae5d8afe39dd3b00654ac91857ec src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java e4439f6a28535f774cfdc1000a0d6d2976254aee src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 31c8650a2cf211290ea4197f97c840f78cfd7646 src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 3661f8487985f631e3ea437fe6430e0296376a9e src/main/python/apache/aurora/client/binding_helper.py 6d6a06785c6840e4345e304eb4e242682676ac66 src/main/python/apache/aurora/client/config.py e440f587d100ce46b2df85ccc663912c615051ef src/main/python/apache/aurora/config/recipes.py 68b5d252f87a592d4c2f7d52525163829bea2cc9 src/main/python/apache/aurora/config/schema/base.py f12634f103c3eb20e43f37c25d9b0fc3e3d228ec src/main/python/apache/aurora/config/thrift.py 288fb40f65629c8fd4eb7d92c8bf02369237de3b src/main/thrift/org/apache/aurora/gen/api.thrift c00f94371a27ffab41188b22f81bb1c8ec7a57e9 src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 606b5b03616c8ddbc83cb89f1206feb409f187c2 src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java ee9587582bd7c45a446e8afe28930c18a97d2792 src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 791aa6fed7380999ea9257d92d16b69ed89dcea0 src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java cdd29ea2b6fc92b967571028d299260556e16d42 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 0d51f7dc367081f72090736e36605bf363f3395e src/test/python/apache/aurora/client/api/test_scheduler_client.py 630f662ad2ffb8d192299d98c612ad4892161081 src/test/python/apache/aurora/client/cli/util.py 95a2123e127c9811fd2305e71cfc5c7c4376f904 src/test/python/apache/aurora/client/commands/util.py 21b8830df5a3eccc7d36067369fc16cc5fd9de2a src/test/python/apache/aurora/client/test_config.py 901c3378ed59c44b7e2dea239f186193f1f66355 src/test/python/apache/aurora/config/test_thrift.py fd28313df2cfd5a9c7d00f6d329518b4caabacb2 Diff: https://reviews.apache.org/r/26821/diff/ Testing --- ./gradlew clean build Thanks, Zameer Manji
Re: Review Request 26821: Handle resourceOffers callback asynchronsly.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26821/ --- (Updated Oct. 16, 2014, 2:28 p.m.) Review request for Aurora and Bill Farner. Changes --- Rebase. Bugs: AURORA-848 https://issues.apache.org/jira/browse/AURORA-848 Repository: aurora Description --- Handle resourceOffers callback asynchronsly. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java e4439f6a28535f774cfdc1000a0d6d2976254aee src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 31c8650a2cf211290ea4197f97c840f78cfd7646 src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 606b5b03616c8ddbc83cb89f1206feb409f187c2 Diff: https://reviews.apache.org/r/26821/diff/ Testing --- ./gradlew clean build Thanks, Zameer Manji
Re: Review Request 26821: Handle resourceOffers callback asynchronsly.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26821/#review57010 --- Ship it! Thanks, this is now on master: $ git log -1 --abbrev-commit origin/master commit 6fea534 Author: Zameer Manji zma...@twopensource.com Date: Thu Oct 16 14:38:14 2014 -0700 Handle resourceOffers callback asynchronsly. Bugs closed: AURORA-848 Reviewed at https://reviews.apache.org/r/26821/ - Bill Farner On Oct. 16, 2014, 9:28 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26821/ --- (Updated Oct. 16, 2014, 9:28 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-848 https://issues.apache.org/jira/browse/AURORA-848 Repository: aurora Description --- Handle resourceOffers callback asynchronsly. Diffs - src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java e4439f6a28535f774cfdc1000a0d6d2976254aee src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 31c8650a2cf211290ea4197f97c840f78cfd7646 src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 606b5b03616c8ddbc83cb89f1206feb409f187c2 Diff: https://reviews.apache.org/r/26821/diff/ Testing --- ./gradlew clean build Thanks, Zameer Manji
