Re: Review Request 27084: Fix error when job create is called with --open-browser.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27084/ --- (Updated Oct. 27, 2014, 11:07 a.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Changes --- rebase Bugs: aurora-886 https://issues.apache.org/jira/browse/aurora-886 Repository: aurora Description --- Fix error when job create is called with --open-browser. Diffs (updated) - src/main/python/apache/aurora/client/cli/jobs.py 625cb80a33ae565b403fc71bb9795e4700e1aeb7 src/test/python/apache/aurora/client/cli/test_create.py 8a5aef8d866f69e124951dd43bf98396f0bd1ef1 Diff: https://reviews.apache.org/r/27084/diff/ Testing --- Added new test; all unit tests pass. Thanks, Mark Chu-Carroll
Re: Review Request 27084: Fix error when job create is called with --open-browser.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27084/#review58377 --- Ship it! Ship It! - Zameer Manji On Oct. 23, 2014, 9:50 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27084/ --- (Updated Oct. 23, 2014, 9:50 a.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-886 https://issues.apache.org/jira/browse/aurora-886 Repository: aurora Description --- Fix error when job create is called with --open-browser. Diffs - src/main/python/apache/aurora/client/cli/jobs.py 10f8e0d331ca607e55e3aa6f96014caea744ed9f src/test/python/apache/aurora/client/cli/test_create.py 328297ab1d29efb0adce8f4931a13929a04dcd9c Diff: https://reviews.apache.org/r/27084/diff/ Testing --- Added new test; all unit tests pass. Thanks, Mark Chu-Carroll
Re: Review Request 27084: Fix error when job create is called with --open-browser.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27084/#review58387 --- Ship it! Ship It! - David McLaughlin On Oct. 23, 2014, 4:50 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27084/ --- (Updated Oct. 23, 2014, 4:50 p.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-886 https://issues.apache.org/jira/browse/aurora-886 Repository: aurora Description --- Fix error when job create is called with --open-browser. Diffs - src/main/python/apache/aurora/client/cli/jobs.py 10f8e0d331ca607e55e3aa6f96014caea744ed9f src/test/python/apache/aurora/client/cli/test_create.py 328297ab1d29efb0adce8f4931a13929a04dcd9c Diff: https://reviews.apache.org/r/27084/diff/ Testing --- Added new test; all unit tests pass. Thanks, Mark Chu-Carroll
Re: Review Request 27084: Fix error when job create is called with --open-browser.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27084/#review58213 --- This patch does not apply cleanly on master (53f4e73), do you need to rebase? - Aurora ReviewBot On Oct. 23, 2014, 4:50 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27084/ --- (Updated Oct. 23, 2014, 4:50 p.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-886 https://issues.apache.org/jira/browse/aurora-886 Repository: aurora Description --- Fix error when job create is called with --open-browser. Diffs - src/main/python/apache/aurora/client/cli/jobs.py 10f8e0d331ca607e55e3aa6f96014caea744ed9f src/test/python/apache/aurora/client/cli/test_create.py 328297ab1d29efb0adce8f4931a13929a04dcd9c Diff: https://reviews.apache.org/r/27084/diff/ Testing --- Added new test; all unit tests pass. Thanks, Mark Chu-Carroll
