Re: Review Request 27586: Increase robustness when reading PEX-INFO

2014-11-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27586/#review60060 --- Ship it! Thanks! This is now on master: $ git log -1 origin/m

Re: Review Request 27586: Increase robustness when reading PEX-INFO

2014-11-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27586/#review59927 --- Master (9847b7b) is red with this patch. ./build-support/jenkins/b

Re: Review Request 27586: Increase robustness when reading PEX-INFO

2014-11-04 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27586/ --- (Updated Nov. 4, 2014, 7:34 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 27586: Increase robustness when reading PEX-INFO

2014-11-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27586/#review59844 --- Ship it! Master (9ef905a) is green with this patch. ./build-suppo

Re: Review Request 27586: Increase robustness when reading PEX-INFO

2014-11-04 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27586/#review59840 --- src/test/python/apache/aurora/client/commands/test_version.py

Re: Review Request 27586: Increase robustness when reading PEX-INFO

2014-11-04 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27586/ --- (Updated Nov. 4, 2014, 1:22 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 27586: Increase robustness when reading PEX-INFO

2014-11-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27586/#review59821 --- Master (9ef905a) is red with this patch. ./build-support/jenkins/b

Re: Review Request 27586: Increase robustness when reading PEX-INFO

2014-11-04 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27586/#review59816 --- Ship it! Ship It! - Kevin Sweeney On Nov. 4, 2014, 11:55 a.m., Z

Re: Review Request 27586: Increase robustness when reading PEX-INFO

2014-11-04 Thread Bill Farner
> On Nov. 4, 2014, 7:48 p.m., Joshua Cohen wrote: > > Can you add a test case? +1 - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27586/#review59812 ---

Re: Review Request 27586: Increase robustness when reading PEX-INFO

2014-11-04 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27586/ --- (Updated Nov. 4, 2014, 11:55 a.m.) Review request for Aurora and Bill Farner.

Re: Review Request 27586: Increase robustness when reading PEX-INFO

2014-11-04 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27586/#review59812 --- Can you add a test case? - Joshua Cohen On Nov. 4, 2014, 7:39 p.m

Re: Review Request 27586: Increase robustness when reading PEX-INFO

2014-11-04 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27586/#review59810 --- src/main/python/apache/aurora/client/commands/core.py

Review Request 27586: Increase robustness when reading PEX-INFO

2014-11-04 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27586/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-456 https://issues.