Re: Review Request 28696: Use abstract decorators in CommandLine class.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28696/#review64247 --- Ship it! Ship It! - Bill Farner On Dec. 4, 2014, 7:40 a.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28696/ --- (Updated Dec. 4, 2014, 7:40 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- Use abstract decorators in CommandLine class. This ensures the name property and register_nouns method are implemented. Diffs - src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 Diff: https://reviews.apache.org/r/28696/diff/ Testing --- ./pants src/test/python/apache/aurora/client:: Thanks, Zameer Manji
Re: Review Request 28696: Use abstract decorators in CommandLine class.
On Dec. 8, 2014, 5:58 p.m., Bill Farner wrote: Ship It! This is now on master: ``` $ git log -1 --abbrev-commit origin/master commit a9e1217 Author: Zameer Manji zma...@twopensource.com Date: Mon Dec 8 09:59:32 2014 -0800 Use abstract decorators in CommandLine class. This ensures the name property and register_nouns method are implemented. Reviewed at https://reviews.apache.org/r/28696/ ``` - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28696/#review64247 --- On Dec. 4, 2014, 7:40 a.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28696/ --- (Updated Dec. 4, 2014, 7:40 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- Use abstract decorators in CommandLine class. This ensures the name property and register_nouns method are implemented. Diffs - src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 Diff: https://reviews.apache.org/r/28696/diff/ Testing --- ./pants src/test/python/apache/aurora/client:: Thanks, Zameer Manji
Re: Review Request 28696: Use abstract decorators in CommandLine class.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28696/#review63823 --- Master (11da34c) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Dec. 4, 2014, 7:40 a.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28696/ --- (Updated Dec. 4, 2014, 7:40 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- Use abstract decorators in CommandLine class. This ensures the name property and register_nouns method are implemented. Diffs - src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 Diff: https://reviews.apache.org/r/28696/diff/ Testing --- ./pants src/test/python/apache/aurora/client:: Thanks, Zameer Manji
