---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29698/#review67222
---
Ship it!
Ship It!
- Zameer Manji
On Jan. 7, 2015, 7:33 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29698/#review67231
---
Ship it!
src/main/python/apache/aurora/client/cli/task.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29698/#review67238
---
Ship it!
Ship It!
- Joshua Cohen
On Jan. 8, 2015, 3:33 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29698/#review67248
---
Ship it!
src/main/python/apache/aurora/client/cli/task.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29698/#review67290
---
Ship it!
docs/client-commands.md
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29698/#review67293
---
Ship it!
Ship It!
- Zameer Manji
On Jan. 8, 2015, 12:32 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29698/#review67292
---
Ship it!
Master (4053924) is green with this patch.
On Jan. 8, 2015, 6:15 p.m., Maxim Khutornenko wrote:
src/main/python/apache/aurora/client/cli/task.py, line 46
https://reviews.apache.org/r/29698/diff/1/?file=811543#file811543line46
The majority of subcommand help strings (i.e. jobs.py) start with
capital letter. Suggest making
On Jan. 8, 2015, 6:50 p.m., Kevin Sweeney wrote:
src/main/python/apache/aurora/client/cli/task.py, line 83
https://reviews.apache.org/r/29698/diff/1/?file=811543#file811543line83
since these aren't multiline anymore you don't need the triple quotes.
In fact, you can do
On Jan. 8, 2015, 6:50 p.m., Kevin Sweeney wrote:
src/main/python/apache/aurora/client/cli/task.py, line 83
https://reviews.apache.org/r/29698/diff/1/?file=811543#file811543line83
since these aren't multiline anymore you don't need the triple quotes.
In fact, you can do
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29698/
---
(Updated Jan. 8, 2015, 8:26 p.m.)
Review request for Aurora, Joshua Cohen,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29698/
---
(Updated Jan. 8, 2015, 8:32 p.m.)
Review request for Aurora, Joshua Cohen,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29698/#review67158
---
Ship it!
Master (9a817f2) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29698/
---
Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.
14 matches
Mail list logo