Re: Review Request 29731: Service status endpoint.

2015-01-08 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29731/#review67337
---

Ship it!


Ship It!

- Joshua Cohen


On Jan. 8, 2015, 11:47 p.m., Kevin Sweeney wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29731/
 ---
 
 (Updated Jan. 8, 2015, 11:47 p.m.)
 
 
 Review request for Aurora, Joshua Cohen and Bill Farner.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Service status endpoint for debugging.
 
 
 Diffs
 -
 
   src/main/java/org/apache/aurora/GuavaUtils.java 
 f3fa8cd9f9200e32ab5a81d2a174184faa49d0a3 
   src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 
 e741913c5c91bc3aba0a790759420f13a9ce00bd 
   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
 8a7926b8c82b318e2eef3d6493b0e817d67c2a6f 
   src/main/java/org/apache/aurora/scheduler/http/Services.java PRE-CREATION 
   src/main/resources/scheduler/assets/index.html 
 442f10b359b121660cbc0c74205441e1d738645f 
   src/test/java/org/apache/aurora/scheduler/http/ServicesTest.java 
 PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/29731/diff/
 
 
 Testing
 ---
 
 ./gradlew -Pq build
 
 Inspected output with ./gradlew run
 
 ```
 % curl http://localhost:8081/services | python -m json.tool
 [
 {
 name: TaskTimeout,
 state: RUNNING
 },
 {
 name: JobUpdateHistoryPruner,
 state: RUNNING
 },
 {
 name: TaskStatUpdaterService,
 state: RUNNING
 },
 {
 name: SlotSizeCounterService,
 state: RUNNING
 },
 {
 name: SlaUpdater,
 state: RUNNING
 },
 {
 name: CronLifecycle,
 state: RUNNING
 },
 {
 name: TaskVars,
 state: RUNNING
 },
 {
 name: RegisterGauges,
 state: RUNNING
 },
 {
 name: RegisterSubscribers,
 state: RUNNING
 },
 {
 name: RedirectMonitor,
 state: RUNNING
 }
 ]
 ```
 
 
 Thanks,
 
 Kevin Sweeney

Review Request 29731: Service status endpoint.

2015-01-08 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29731/
---

Review request for Aurora, Joshua Cohen and Bill Farner.


Repository: aurora


Description
---

Service status endpoint for debugging.


Diffs
-

  src/main/java/org/apache/aurora/GuavaUtils.java 
f3fa8cd9f9200e32ab5a81d2a174184faa49d0a3 
  src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 
e741913c5c91bc3aba0a790759420f13a9ce00bd 
  src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
8a7926b8c82b318e2eef3d6493b0e817d67c2a6f 
  src/main/java/org/apache/aurora/scheduler/http/Services.java PRE-CREATION 
  src/main/resources/scheduler/assets/index.html 
442f10b359b121660cbc0c74205441e1d738645f 
  src/test/java/org/apache/aurora/scheduler/http/ServicesTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/29731/diff/


Testing
---

./gradlew -Pq build

Inspected output with ./gradlew run

% curl http://localhost:8081/services | python -m json.tool
[
{
name: TaskTimeout,
state: RUNNING
},
{
name: JobUpdateHistoryPruner,
state: RUNNING
},
{
name: TaskStatUpdaterService,
state: RUNNING
},
{
name: SlotSizeCounterService,
state: RUNNING
},
{
name: SlaUpdater,
state: RUNNING
},
{
name: CronLifecycle,
state: RUNNING
},
{
name: TaskVars,
state: RUNNING
},
{
name: RegisterGauges,
state: RUNNING
},
{
name: RegisterSubscribers,
state: RUNNING
},
{
name: RedirectMonitor,
state: RUNNING
}
]


Thanks,

Kevin Sweeney

Re: Review Request 29731: Service status endpoint.

2015-01-08 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29731/
---

(Updated Jan. 8, 2015, 3:47 p.m.)


Review request for Aurora, Joshua Cohen and Bill Farner.


Repository: aurora


Description
---

Service status endpoint for debugging.


Diffs
-

  src/main/java/org/apache/aurora/GuavaUtils.java 
f3fa8cd9f9200e32ab5a81d2a174184faa49d0a3 
  src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 
e741913c5c91bc3aba0a790759420f13a9ce00bd 
  src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
8a7926b8c82b318e2eef3d6493b0e817d67c2a6f 
  src/main/java/org/apache/aurora/scheduler/http/Services.java PRE-CREATION 
  src/main/resources/scheduler/assets/index.html 
442f10b359b121660cbc0c74205441e1d738645f 
  src/test/java/org/apache/aurora/scheduler/http/ServicesTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/29731/diff/


Testing (updated)
---

./gradlew -Pq build

Inspected output with ./gradlew run

```
% curl http://localhost:8081/services | python -m json.tool
[
{
name: TaskTimeout,
state: RUNNING
},
{
name: JobUpdateHistoryPruner,
state: RUNNING
},
{
name: TaskStatUpdaterService,
state: RUNNING
},
{
name: SlotSizeCounterService,
state: RUNNING
},
{
name: SlaUpdater,
state: RUNNING
},
{
name: CronLifecycle,
state: RUNNING
},
{
name: TaskVars,
state: RUNNING
},
{
name: RegisterGauges,
state: RUNNING
},
{
name: RegisterSubscribers,
state: RUNNING
},
{
name: RedirectMonitor,
state: RUNNING
}
]
```


Thanks,

Kevin Sweeney

Re: Review Request 29731: Service status endpoint.

2015-01-08 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29731/#review67326
---

Ship it!


Master (4431297) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On Jan. 8, 2015, 11:47 p.m., Kevin Sweeney wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29731/
 ---
 
 (Updated Jan. 8, 2015, 11:47 p.m.)
 
 
 Review request for Aurora, Joshua Cohen and Bill Farner.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Service status endpoint for debugging.
 
 
 Diffs
 -
 
   src/main/java/org/apache/aurora/GuavaUtils.java 
 f3fa8cd9f9200e32ab5a81d2a174184faa49d0a3 
   src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 
 e741913c5c91bc3aba0a790759420f13a9ce00bd 
   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
 8a7926b8c82b318e2eef3d6493b0e817d67c2a6f 
   src/main/java/org/apache/aurora/scheduler/http/Services.java PRE-CREATION 
   src/main/resources/scheduler/assets/index.html 
 442f10b359b121660cbc0c74205441e1d738645f 
   src/test/java/org/apache/aurora/scheduler/http/ServicesTest.java 
 PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/29731/diff/
 
 
 Testing
 ---
 
 ./gradlew -Pq build
 
 Inspected output with ./gradlew run
 
 ```
 % curl http://localhost:8081/services | python -m json.tool
 [
 {
 name: TaskTimeout,
 state: RUNNING
 },
 {
 name: JobUpdateHistoryPruner,
 state: RUNNING
 },
 {
 name: TaskStatUpdaterService,
 state: RUNNING
 },
 {
 name: SlotSizeCounterService,
 state: RUNNING
 },
 {
 name: SlaUpdater,
 state: RUNNING
 },
 {
 name: CronLifecycle,
 state: RUNNING
 },
 {
 name: TaskVars,
 state: RUNNING
 },
 {
 name: RegisterGauges,
 state: RUNNING
 },
 {
 name: RegisterSubscribers,
 state: RUNNING
 },
 {
 name: RedirectMonitor,
 state: RUNNING
 }
 ]
 ```
 
 
 Thanks,
 
 Kevin Sweeney