Review Request 29734: Fix reviewbot to skip reviews that have no diffs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29734/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository: aurora Description --- Fix reviewbot to skip reviews that have no diffs. Diffs - build-support/jenkins/review_feedback.py bd2c9941960645f662ec835c2baa4d1f3dae7d79 Diff: https://reviews.apache.org/r/29734/diff/ Testing --- No... is there any way for me to test this? Thanks, Joshua Cohen
Re: Review Request 29734: Fix reviewbot to skip reviews that have no diffs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29734/#review67336 --- For testing you can run it locally. - Kevin Sweeney On Jan. 8, 2015, 4:04 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29734/ --- (Updated Jan. 8, 2015, 4:04 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository: aurora Description --- Fix reviewbot to skip reviews that have no diffs. We're seeing [failures](https://builds.apache.org/job/AuroraBot/724/console) of the AuroraBot job for a [review](https://reviews.apache.org/r/28943/) that has no diffs. This should fix those cases. Diffs - build-support/jenkins/review_feedback.py bd2c9941960645f662ec835c2baa4d1f3dae7d79 Diff: https://reviews.apache.org/r/29734/diff/ Testing --- No... is there any way for me to test this? Thanks, Joshua Cohen
Re: Review Request 29734: Fix reviewbot to skip reviews that have no diffs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29734/ --- (Updated Jan. 9, 2015, 1:02 a.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Changes --- -wfarner, +ksweeney so we can ship this and quiet the noise from failed reviewbot builds. Repository: aurora Description --- Fix reviewbot to skip reviews that have no diffs. We're seeing [failures](https://builds.apache.org/job/AuroraBot/724/console) of the AuroraBot job for a [review](https://reviews.apache.org/r/28943/) that has no diffs. This should fix those cases. Diffs - build-support/jenkins/review_feedback.py bd2c9941960645f662ec835c2baa4d1f3dae7d79 Diff: https://reviews.apache.org/r/29734/diff/ Testing --- Ran locally, it didn't crash on r28943 Thanks, Joshua Cohen
Re: Review Request 29734: Fix reviewbot to skip reviews that have no diffs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29734/ --- (Updated Jan. 9, 2015, 12:31 a.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository: aurora Description --- Fix reviewbot to skip reviews that have no diffs. We're seeing [failures](https://builds.apache.org/job/AuroraBot/724/console) of the AuroraBot job for a [review](https://reviews.apache.org/r/28943/) that has no diffs. This should fix those cases. Diffs - build-support/jenkins/review_feedback.py bd2c9941960645f662ec835c2baa4d1f3dae7d79 Diff: https://reviews.apache.org/r/29734/diff/ Testing (updated) --- Ran locally, it didn't crash on r28943 Thanks, Joshua Cohen
Re: Review Request 29734: Fix reviewbot to skip reviews that have no diffs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29734/ --- (Updated Jan. 9, 2015, 12:38 a.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Changes --- Fix my bad python. Repository: aurora Description --- Fix reviewbot to skip reviews that have no diffs. We're seeing [failures](https://builds.apache.org/job/AuroraBot/724/console) of the AuroraBot job for a [review](https://reviews.apache.org/r/28943/) that has no diffs. This should fix those cases. Diffs (updated) - build-support/jenkins/review_feedback.py bd2c9941960645f662ec835c2baa4d1f3dae7d79 docs/client-commands.md 75e69541fd95dfd9a7aa1e04de1a590b8fcbeacf docs/client.md 3ec39b4f3bd6b45692aa1291e66a0a171d7dbb68 src/main/python/apache/aurora/client/cli/__init__.py 395819fdf24b7919b32be51060fb5b581c8e1514 src/main/python/apache/aurora/client/cli/client.py 939e32b0287a4a6e9cd66c4d6ffe05b32ed26d78 src/main/python/apache/aurora/client/cli/options.py b7f5a031d135a33ec2d79aa521ce9c1438eb58c1 src/main/python/apache/aurora/client/cli/task.py e084c5bef54d8a726276764ed7e5ce44cdc99ec5 src/test/python/apache/aurora/client/cli/BUILD bbac5c8efc9892fd2a966a6ac25fe05ffd740733 src/test/python/apache/aurora/client/cli/test_help.py 9fa05e683f01a0e51253e08aa7fba69fd49d3756 src/test/python/apache/aurora/client/cli/test_plugins.py cf742a3feb12c6bb8fc6e80f15daaac7c2b2bf55 src/test/python/apache/aurora/client/cli/util.py 1fa1207d9380e57ac77d2aa24725b9ac39c83d4c Diff: https://reviews.apache.org/r/29734/diff/ Testing --- Ran locally, it didn't crash on r28943 Thanks, Joshua Cohen
Re: Review Request 29734: Fix reviewbot to skip reviews that have no diffs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29734/#review67354 --- Ship it! Master (4431297) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 9, 2015, 12:41 a.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29734/ --- (Updated Jan. 9, 2015, 12:41 a.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository: aurora Description --- Fix reviewbot to skip reviews that have no diffs. We're seeing [failures](https://builds.apache.org/job/AuroraBot/724/console) of the AuroraBot job for a [review](https://reviews.apache.org/r/28943/) that has no diffs. This should fix those cases. Diffs - build-support/jenkins/review_feedback.py bd2c9941960645f662ec835c2baa4d1f3dae7d79 Diff: https://reviews.apache.org/r/29734/diff/ Testing --- Ran locally, it didn't crash on r28943 Thanks, Joshua Cohen
Re: Review Request 29734: Fix reviewbot to skip reviews that have no diffs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29734/ --- (Updated Jan. 9, 2015, 12:04 a.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository: aurora Description (updated) --- Fix reviewbot to skip reviews that have no diffs. We're seeing [failures](https://builds.apache.org/job/AuroraBot/724/console) of the AuroraBot job for a [review](https://reviews.apache.org/r/28943/) that has no diffs. This should fix those cases. Diffs - build-support/jenkins/review_feedback.py bd2c9941960645f662ec835c2baa4d1f3dae7d79 Diff: https://reviews.apache.org/r/29734/diff/ Testing --- No... is there any way for me to test this? Thanks, Joshua Cohen
Re: Review Request 29734: Fix reviewbot to skip reviews that have no diffs.
On Jan. 9, 2015, 12:04 a.m., Kevin Sweeney wrote: For testing you can run it locally. Thanks, ran locally and all looked well. - Joshua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29734/#review67336 --- On Jan. 9, 2015, 12:04 a.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29734/ --- (Updated Jan. 9, 2015, 12:04 a.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository: aurora Description --- Fix reviewbot to skip reviews that have no diffs. We're seeing [failures](https://builds.apache.org/job/AuroraBot/724/console) of the AuroraBot job for a [review](https://reviews.apache.org/r/28943/) that has no diffs. This should fix those cases. Diffs - build-support/jenkins/review_feedback.py bd2c9941960645f662ec835c2baa4d1f3dae7d79 Diff: https://reviews.apache.org/r/29734/diff/ Testing --- No... is there any way for me to test this? Thanks, Joshua Cohen
Re: Review Request 29734: Fix reviewbot to skip reviews that have no diffs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29734/#review67342 --- Ship it! Master (66128e4) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 9, 2015, 12:04 a.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29734/ --- (Updated Jan. 9, 2015, 12:04 a.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository: aurora Description --- Fix reviewbot to skip reviews that have no diffs. We're seeing [failures](https://builds.apache.org/job/AuroraBot/724/console) of the AuroraBot job for a [review](https://reviews.apache.org/r/28943/) that has no diffs. This should fix those cases. Diffs - build-support/jenkins/review_feedback.py bd2c9941960645f662ec835c2baa4d1f3dae7d79 Diff: https://reviews.apache.org/r/29734/diff/ Testing --- No... is there any way for me to test this? Thanks, Joshua Cohen
Re: Review Request 29734: Fix reviewbot to skip reviews that have no diffs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29734/ --- (Updated Jan. 9, 2015, 12:41 a.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Changes --- Fix diff. Repository: aurora Description --- Fix reviewbot to skip reviews that have no diffs. We're seeing [failures](https://builds.apache.org/job/AuroraBot/724/console) of the AuroraBot job for a [review](https://reviews.apache.org/r/28943/) that has no diffs. This should fix those cases. Diffs (updated) - build-support/jenkins/review_feedback.py bd2c9941960645f662ec835c2baa4d1f3dae7d79 Diff: https://reviews.apache.org/r/29734/diff/ Testing --- Ran locally, it didn't crash on r28943 Thanks, Joshua Cohen
Re: Review Request 29734: Fix reviewbot to skip reviews that have no diffs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29734/#review67345 --- Ship it! Ship It! - Kevin Sweeney On Jan. 8, 2015, 4:31 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29734/ --- (Updated Jan. 8, 2015, 4:31 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository: aurora Description --- Fix reviewbot to skip reviews that have no diffs. We're seeing [failures](https://builds.apache.org/job/AuroraBot/724/console) of the AuroraBot job for a [review](https://reviews.apache.org/r/28943/) that has no diffs. This should fix those cases. Diffs - build-support/jenkins/review_feedback.py bd2c9941960645f662ec835c2baa4d1f3dae7d79 Diff: https://reviews.apache.org/r/29734/diff/ Testing --- Ran locally, it didn't crash on r28943 Thanks, Joshua Cohen
Re: Review Request 29734: Fix reviewbot to skip reviews that have no diffs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29734/#review67344 --- Ship it! build-support/jenkins/review_feedback.py https://reviews.apache.org/r/29734/#comment111341 if not diffs: should do the same - Maxim Khutornenko On Jan. 9, 2015, 12:31 a.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29734/ --- (Updated Jan. 9, 2015, 12:31 a.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository: aurora Description --- Fix reviewbot to skip reviews that have no diffs. We're seeing [failures](https://builds.apache.org/job/AuroraBot/724/console) of the AuroraBot job for a [review](https://reviews.apache.org/r/28943/) that has no diffs. This should fix those cases. Diffs - build-support/jenkins/review_feedback.py bd2c9941960645f662ec835c2baa4d1f3dae7d79 Diff: https://reviews.apache.org/r/29734/diff/ Testing --- Ran locally, it didn't crash on r28943 Thanks, Joshua Cohen
