Re: Review Request 30446: Fix compile errors under Java 8.

2015-01-30 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30446/#review70403 --- Ship it! Ship It! - Kevin Sweeney On Jan. 30, 2015, 10:53 a.m.,

Re: Review Request 30446: Fix compile errors under Java 8.

2015-01-30 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30446/ --- (Updated Jan. 30, 2015, 6:18 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 30446: Fix compile errors under Java 8.

2015-01-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30446/#review70393 --- I was able to address these compiler errors with a more targeted

Re: Review Request 30446: Fix compile errors under Java 8.

2015-01-30 Thread Joshua Cohen
On Jan. 30, 2015, 4:56 p.m., Maxim Khutornenko wrote: I'm not in love with this fix, but the alternative is to declare these methods as throwing Exception which propagates out pretty widely. - that happens to be exactly what we do in java unit tests. No matter the type, it will still

Re: Review Request 30446: Fix compile errors under Java 8.

2015-01-30 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30446/ --- (Updated Jan. 30, 2015, 6:18 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 30446: Fix compile errors under Java 8.

2015-01-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30446/#review70413 --- Ship it! Master (4f04a34) is green with this patch.

Re: Review Request 30446: Fix compile errors under Java 8.

2015-01-30 Thread Joshua Cohen
On Jan. 30, 2015, 6:44 p.m., Bill Farner wrote: I was able to address these compiler errors with a more targeted change, adding a type witness: ``` $ git diff src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java diff --git

Re: Review Request 30446: Fix compile errors under Java 8.

2015-01-30 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30446/ --- (Updated Jan. 30, 2015, 6:53 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 30446: Fix compile errors under Java 8.

2015-01-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30446/#review70332 --- Ship it! Master (4f04a34) is green with this patch.

Review Request 30446: Fix compile errors under Java 8.

2015-01-29 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30446/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora