Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

2015-02-24 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30895/#review73887 --- Ship it! Ship It! - Kevin Sweeney On Feb. 23, 2015, 2:47 p.m.,

Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

2015-02-23 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30895/ --- (Updated Feb. 23, 2015, 9:03 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

2015-02-23 Thread Maxim Khutornenko
On Feb. 23, 2015, 7:47 p.m., Bill Farner wrote: src/jmh/java/org/apache/aurora/benchmark/BenchmarkSettings.java, line 33 https://reviews.apache.org/r/30895/diff/2/?file=873059#file873059line33 This is bound to become a Texas constructor [1]. Please consider using the

Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

2015-02-23 Thread Maxim Khutornenko
On Feb. 23, 2015, 9:59 p.m., Bill Farner wrote: src/jmh/java/org/apache/aurora/benchmark/BenchmarkSettings.java, line 66 https://reviews.apache.org/r/30895/diff/3/?file=873099#file873099line66 Javadoc here would be nice. I failed to elaborate on the last review, but it's not

Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

2015-02-23 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30895/ --- (Updated Feb. 23, 2015, 10:47 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

2015-02-23 Thread Kevin Sweeney
On Feb. 23, 2015, 11:47 a.m., Bill Farner wrote: src/jmh/java/org/apache/aurora/benchmark/BenchmarkSettings.java, line 33 https://reviews.apache.org/r/30895/diff/2/?file=873059#file873059line33 This is bound to become a Texas constructor [1]. Please consider using the

Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

2015-02-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30895/#review73677 --- Master (277ac43) is red with this patch.

Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

2015-02-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30895/#review73680 --- Ship it!

Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

2015-02-11 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30895/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora

Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

2015-02-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30895/#review72048 --- Ship it! Master (7b531e9) is green with this patch.