On Feb. 24, 2015, 8:54 p.m., Zameer Manji wrote:
src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml,
line 149
https://reviews.apache.org/r/31376/diff/1/?file=874379#file874379line149
Have you filed an upstream bug about this behaviour?
I
On Feb. 24, 2015, 8:54 p.m., Zameer Manji wrote:
src/main/java/org/apache/aurora/scheduler/updater/Updates.java, line 57
https://reviews.apache.org/r/31376/diff/1/?file=874378#file874378line57
I don't think we should pass around any mutable state. I think data
objects like
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31376/
---
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31376/#review73899
---
Ship it!
On Feb. 24, 2015, 8:28 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/updater/Updates.java, line 57
https://reviews.apache.org/r/31376/diff/1/?file=874378#file874378line57
Would it make sense to accept/return `JobUpdateSummary`? The
mutable/immutable
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31376/#review73906
---
src/main/java/org/apache/aurora/scheduler/updater/Updates.java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31376/#review73900
---
Ship it!
Master (19378c1) is green with this patch.
