Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/#review74543 --- Ship it! Ship It! - Zameer Manji On Feb. 27, 2015, 9:54 a.m., Bi

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/#review74513 --- Ship it! Master (766d1c9) is green with this patch. ./build-suppo

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/ --- (Updated Feb. 27, 2015, 5:11 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/#review74509 --- Master (766d1c9) is red with this patch. ./build-support/jenkins/b

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/#review74508 --- Ship it! Ship It! - Maxim Khutornenko On Feb. 27, 2015, 4:49 p.m

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/ --- (Updated Feb. 27, 2015, 4:49 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/#review74193 --- Ship it! Ship It! - Zameer Manji On Feb. 25, 2015, 5:39 p.m., Bi

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/#review74190 --- Ship it! Master (9442e08) is green with this patch. ./build-suppo

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/ --- (Updated Feb. 26, 2015, 1:39 a.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

> On Feb. 25, 2015, 11:27 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java, > > line 219 > > > > > > Will this be addresed as apart of this effort? It actuall

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

> On Feb. 25, 2015, 11:01 p.m., Maxim Khutornenko wrote: > > This does not seem to address js invocations of the job update APIs. E.g: > > > > https://github.com/apache/incubator-aurora/blob/master/src/main/resources/scheduler/assets/js/controllers.js#L279 > > https://github.com/apache/incubator

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/#review74142 --- src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStore

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/#review74138 --- Ship it! Master (9442e08) is green with this patch. ./build-suppo

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

> On Feb. 25, 2015, 11:01 p.m., Maxim Khutornenko wrote: > > This does not seem to address js invocations of the job update APIs. E.g: > > > > https://github.com/apache/incubator-aurora/blob/master/src/main/resources/scheduler/assets/js/controllers.js#L279 > > https://github.com/apache/incubator

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/ --- (Updated Feb. 25, 2015, 11:04 p.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/#review74129 --- This does not seem to address js invocations of the job update APIs.

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/ --- (Updated Feb. 25, 2015, 10:59 p.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/#review74106 --- Master (9442e08) is red with this patch. ./build-support/jenkins/b

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/#review74102 --- @ReviewBot retry The last reply was not for the latest diff. - Bil

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/#review74092 --- Master (895d03b) is red with this patch. ./build-support/jenkins/b

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/ --- (Updated Feb. 25, 2015, 8:58 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/ --- (Updated Feb. 25, 2015, 8:37 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

> On Feb. 25, 2015, 12:17 a.m., Aurora ReviewBot wrote: > > Master (cd681d9) is red with this patch. > > ./build-support/jenkins/build.sh > > > >  role=role, > >  jobKey=job_key.to_thrift() if > > job_key else Non

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/#review73945 --- Master (cd681d9) is red with this patch. ./build-support/jenkins/b

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/ --- (Updated Feb. 25, 2015, 12:07 a.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/ --- (Updated Feb. 25, 2015, midnight) Review request for Aurora, Maxim Khutornenko

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/#review73936 --- This patch does not apply cleanly on master (cd681d9), do you need t

Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/ --- Review request for Aurora, Maxim Khutornenko and Zameer Manji. Bugs: AURORA-109