Re: Review Request 31814: Include messages with internal job updater state transitions.

2015-03-09 Thread Joshua Cohen
On March 7, 2015, 12:01 a.m., Joshua Cohen wrote: src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java, line 200 https://reviews.apache.org/r/31814/diff/1/?file=888014#file888014line200 The original scope for AURORA-1077 was to allow for passing a

Re: Review Request 31814: Include messages with internal job updater state transitions.

2015-03-09 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31814/#review75726 ---

Re: Review Request 31814: Include messages with internal job updater state transitions.

2015-03-09 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31814/#review75722 --- Ship it! Ship It! - Joshua Cohen On March 7, 2015, 1:06 a.m.,

Re: Review Request 31814: Include messages with internal job updater state transitions.

2015-03-09 Thread Bill Farner
On March 9, 2015, 5:50 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java, line 291 https://reviews.apache.org/r/31814/diff/2/?file=888120#file888120line291 What's the motivation behind dropping the Aurora Updater here?

Re: Review Request 31814: Include messages with internal job updater state transitions.

2015-03-09 Thread Kevin Sweeney
On March 9, 2015, 10:50 a.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java, line 291 https://reviews.apache.org/r/31814/diff/2/?file=888120#file888120line291 What's the motivation behind dropping the Aurora Updater here?

Re: Review Request 31814: Include messages with internal job updater state transitions.

2015-03-09 Thread Maxim Khutornenko
On March 9, 2015, 5:50 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java, line 291 https://reviews.apache.org/r/31814/diff/2/?file=888120#file888120line291 What's the motivation behind dropping the Aurora Updater here?

Re: Review Request 31814: Include messages with internal job updater state transitions.

2015-03-09 Thread Bill Farner
On March 9, 2015, 5:50 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java, line 291 https://reviews.apache.org/r/31814/diff/2/?file=888120#file888120line291 What's the motivation behind dropping the Aurora Updater here?

Re: Review Request 31814: Include messages with internal job updater state transitions.

2015-03-09 Thread Bill Farner
On March 9, 2015, 5:50 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java, line 291 https://reviews.apache.org/r/31814/diff/2/?file=888120#file888120line291 What's the motivation behind dropping the Aurora Updater here?

Re: Review Request 31814: Include messages with internal job updater state transitions.

2015-03-09 Thread Maxim Khutornenko
On March 9, 2015, 5:50 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java, line 291 https://reviews.apache.org/r/31814/diff/2/?file=888120#file888120line291 What's the motivation behind dropping the Aurora Updater here?

Re: Review Request 31814: Include messages with internal job updater state transitions.

2015-03-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31814/ --- (Updated March 10, 2015, 12:35 a.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 31814: Include messages with internal job updater state transitions.

2015-03-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31814/#review75829 --- Master (e55113d) is red with this patch.

Re: Review Request 31814: Include messages with internal job updater state transitions.

2015-03-09 Thread Bill Farner
On March 10, 2015, 1:10 a.m., Aurora ReviewBot wrote: Master (e55113d) is red with this patch. ./build-support/jenkins/build.sh src.test.python.apache.aurora.client.cli.plugins . SUCCESS

Re: Review Request 31814: Include messages with internal job updater state transitions.

2015-03-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31814/#review75842 --- Ship it! Master (1b1931c) is green with this patch.

Re: Review Request 31814: Include messages with internal job updater state transitions.

2015-03-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31814/#review75831 --- @ReviewBot retry - Bill Farner On March 10, 2015, 12:35 a.m.,

Re: Review Request 31814: Include messages with internal job updater state transitions.

2015-03-09 Thread Bill Farner
On March 10, 2015, 12:54 a.m., Aurora ReviewBot wrote: Master (e55113d) is red with this patch. ./build-support/jenkins/build.sh src.test.python.apache.aurora.client.cli.update . SUCCESS

Re: Review Request 31814: Include messages with internal job updater state transitions.

2015-03-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31814/#review75836 --- @ReviewBot retry - Bill Farner On March 10, 2015, 12:35 a.m.,