Re: Review Request 32055: Add a flag to configure Shiro at runtime.

2015-03-13 Thread Kevin Sweeney
On March 13, 2015, 12:59 p.m., Joshua Cohen wrote: src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java, line 95 https://reviews.apache.org/r/32055/diff/1/?file=894545#file894545line95 I thought it's generally preferable when installing user-supplied

Re: Review Request 32055: Add a flag to configure Shiro at runtime.

2015-03-13 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32055/ --- (Updated March 13, 2015, 1:18 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 32055: Add a flag to configure Shiro at runtime.

2015-03-13 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32055/ --- (Updated March 13, 2015, 1:26 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 32055: Add a flag to configure Shiro at runtime.

2015-03-13 Thread Joshua Cohen
On March 13, 2015, 7:59 p.m., Joshua Cohen wrote: src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java, line 95 https://reviews.apache.org/r/32055/diff/1/?file=894545#file894545line95 I thought it's generally preferable when installing user-supplied

Re: Review Request 32055: Add a flag to configure Shiro at runtime.

2015-03-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32055/#review76427 --- Ship it! Master (128e554) is green with this patch.

Re: Review Request 32055: Add a flag to configure Shiro at runtime.

2015-03-13 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32055/ --- (Updated March 13, 2015, 1:31 p.m.) Review request for Aurora, Joshua Cohen

Review Request 32055: Add a flag to configure Shiro at runtime.

2015-03-13 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32055/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-809

Re: Review Request 32055: Add a flag to configure Shiro at runtime.

2015-03-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32055/#review76421 --- Master (128e554) is red with this patch.