---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32313/#review77302
---
Ship it!
Master (f12d9fe) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32313/#review77242
---
Realized i neglected to update docs. Please review what's here,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32313/#review77248
---
Ship it!
src/test/python/apache/aurora/client/cli/test_supdate.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32313/
---
Review request for Aurora, Joshua Cohen and Zameer Manji.
Bugs: AURORA-1206
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32313/#review77243
---
Ship it!
Master (91aec8c) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32313/#review77268
---
Ship it!
Master (f12d9fe) is green with this patch.
On March 20, 2015, 5:59 p.m., Zameer Manji wrote:
src/test/python/apache/aurora/client/cli/test_supdate.py, line 101
https://reviews.apache.org/r/32313/diff/1/?file=901501#file901501line101
Using a raw mock here is a little bit dangerous if the shape of the raw
config changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32313/
---
(Updated March 20, 2015, 7:51 p.m.)
Review request for Aurora, Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32313/
---
(Updated March 20, 2015, 8:15 p.m.)
Review request for Aurora, Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32313/
---
(Updated March 20, 2015, 8:23 p.m.)
Review request for Aurora, Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32313/#review77284
---
Ship it!
src/test/python/apache/aurora/client/cli/test_supdate.py
On March 20, 2015, 10:11 p.m., Joshua Cohen wrote:
src/test/python/apache/aurora/client/cli/test_supdate.py, lines 158-162
https://reviews.apache.org/r/32313/diff/4/?file=901692#file901692line158
Can we assert `self._mock_api.start_job.mock_calls = [call(...)]`
instead?
We can!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32313/
---
(Updated March 20, 2015, 10:30 p.m.)
Review request for Aurora, Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32313/
---
(Updated March 20, 2015, 10:31 p.m.)
Review request for Aurora, Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32313/#review77291
---
Ship it!
src/test/python/apache/aurora/client/cli/test_supdate.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32313/#review77292
---
Master (f12d9fe) is red with this patch.
On March 20, 2015, 10:33 p.m., Joshua Cohen wrote:
src/test/python/apache/aurora/client/cli/test_supdate.py, line 636
https://reviews.apache.org/r/32313/diff/5/?file=901848#file901848line636
Yes, let us add stuff! Stuff is great and junk!
Stuff=added. This pointed out that i
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32313/
---
(Updated March 20, 2015, 10:48 p.m.)
Review request for Aurora, Joshua Cohen
18 matches
Mail list logo
