Review Request 32515: Kill inotify disk collector.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32515/ --- Review request for Aurora, Kevin Sweeney and Zameer Manji. Repository: aurora Description --- This is currently unwired and its only test is marked flaky. Diffs - 3rdparty/python/requirements.txt ee30136c9224a85b65a93185ec12a86d7051e354 src/main/python/apache/thermos/monitoring/BUILD a7864d4e490784fef04582d4986c2fd121947c9d src/main/python/apache/thermos/monitoring/disk.py ccf6d6aafe893836e72e179cc1a8010a1ac6ac7f src/test/python/apache/thermos/monitoring/test_disk.py e1373234feba08ab881179af0cbf6b7ed326cc45 Diff: https://reviews.apache.org/r/32515/diff/ Testing --- Thanks, Brian Wickman
Re: Review Request 32515: Kill inotify disk collector.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32515/#review77838 --- Ship it! Please close https://issues.apache.org/jira/browse/AURORA-916 when this lands. - Zameer Manji On March 25, 2015, 6:19 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32515/ --- (Updated March 25, 2015, 6:19 p.m.) Review request for Aurora, Kevin Sweeney and Zameer Manji. Repository: aurora Description --- This is currently unwired and its only test is marked flaky. Diffs - 3rdparty/python/requirements.txt ee30136c9224a85b65a93185ec12a86d7051e354 src/main/python/apache/thermos/monitoring/BUILD a7864d4e490784fef04582d4986c2fd121947c9d src/main/python/apache/thermos/monitoring/disk.py ccf6d6aafe893836e72e179cc1a8010a1ac6ac7f src/test/python/apache/thermos/monitoring/test_disk.py e1373234feba08ab881179af0cbf6b7ed326cc45 Diff: https://reviews.apache.org/r/32515/diff/ Testing --- Thanks, Brian Wickman
Re: Review Request 32515: Kill inotify disk collector.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32515/ --- (Updated March 26, 2015, 1:33 a.m.) Review request for Aurora, Kevin Sweeney and Zameer Manji. Changes --- Fix checkstyle violations. Repository: aurora Description --- This is currently unwired and its only test is marked flaky. Diffs (updated) - 3rdparty/python/requirements.txt ee30136c9224a85b65a93185ec12a86d7051e354 src/main/python/apache/thermos/monitoring/BUILD a7864d4e490784fef04582d4986c2fd121947c9d src/main/python/apache/thermos/monitoring/disk.py ccf6d6aafe893836e72e179cc1a8010a1ac6ac7f src/test/python/apache/thermos/monitoring/test_disk.py e1373234feba08ab881179af0cbf6b7ed326cc45 Diff: https://reviews.apache.org/r/32515/diff/ Testing --- Thanks, Brian Wickman
Re: Review Request 32515: Kill inotify disk collector.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32515/#review77841
---
Master (68d2e47) is red with this patch.
./build-support/jenkins/build.sh
Running setup.py install for twitter.common.app
Skipping installation of
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
(namespace package)
Skipping installation of
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
(namespace package)
Installing
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.app-0.3.0-py2.7-nspkg.pth
Running setup.py install for GitPython
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/local/lib/python2.7/site-packages/setuptools/dist.py:292:
UserWarning: The version specified ('0.3.2 RC1') is an invalid version, this
may not work as expected with newer versions of setuptools, pip, and PyPI.
Please see PEP 440 for more details.
details. % self.metadata.version
Running setup.py install for pep8
Installing pep8 script to
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/bin
Running setup.py install for pyflakes
Installing pyflakes script to
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/bin
Running setup.py install for twitter.checkstyle
Skipping installation of
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
(namespace package)
Installing
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.checkstyle-0.1.0-py2.7-nspkg.pth
Installing twitterstyle script to
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/bin
Successfully installed GitPython-0.3.2rc1 gitdb-0.6.4 pep8-1.4.5 pyflakes-0.7.2
smmap-0.9.0 twitter.checkstyle-0.1.0 twitter.common.app-0.3.0
twitter.common.collections-0.3.0 twitter.common.contextutil-0.3.0
twitter.common.dirutil-0.3.0 twitter.common.lang-0.3.0 twitter.common.log-0.3.0
twitter.common.options-0.3.0 twitter.common.process-0.3.0
twitter.common.string-0.3.0 twitter.common.util-0.3.0
F401:ERROR src/main/python/apache/thermos/monitoring/disk.py:021 'os'
imported but unused
|import os
F401:ERROR src/main/python/apache/thermos/monitoring/disk.py:024 'Queue'
imported but unused
|from Queue import Queue
F401:ERROR src/main/python/apache/thermos/monitoring/disk.py:027 'safe_bsize'
imported but unused
|from twitter.common.dirutil import du, safe_bsize
F401:ERROR src/main/python/apache/thermos/monitoring/disk.py:030 'Time'
imported but unused
|from twitter.common.quantity import Amount, Time
F401:ERROR src/main/python/apache/thermos/monitoring/disk.py:030 'Amount'
imported but unused
|from twitter.common.quantity import Amount, Time
F401:ERROR src/test/python/apache/thermos/monitoring/test_disk.py:016 'time'
imported but unused
|import time
F401:ERROR src/test/python/apache/thermos/monitoring/test_disk.py:019
'pytest' imported but unused
|import pytest
F401:ERROR src/test/python/apache/thermos/monitoring/test_disk.py:021 'Time'
imported but unused
|from twitter.common.quantity import Amount, Data, Time
I will refresh this build result if you post a review containing @ReviewBot
retry
- Aurora ReviewBot
On March 26, 2015, 1:19 a.m., Brian Wickman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32515/
---
(Updated March 26, 2015, 1:19 a.m.)
Review request for Aurora, Kevin Sweeney and Zameer Manji.
Repository: aurora
Description
---
This is currently unwired and its only test is marked flaky.
Diffs
-
3rdparty/python/requirements.txt ee30136c9224a85b65a93185ec12a86d7051e354
src/main/python/apache/thermos/monitoring/BUILD
a7864d4e490784fef04582d4986c2fd121947c9d
src/main/python/apache/thermos/monitoring/disk.py
ccf6d6aafe893836e72e179cc1a8010a1ac6ac7f
src/test/python/apache/thermos/monitoring/test_disk.py
e1373234feba08ab881179af0cbf6b7ed326cc45
Diff: https://reviews.apache.org/r/32515/diff/
Testing
---
Thanks,
Brian Wickman
Re: Review Request 32515: Kill inotify disk collector.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32515/#review77848 --- Master (68d2e47) is red with this patch. ./build-support/jenkins/build.sh plugins: cov, timeout [1m collecting 0 items[0m[1m collecting 1 items[0m[1m collected 1 items [0m src/test/python/apache/thermos/cli/test_main.py::test_noop [32mPASSED[0m generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/src.test.python.apache.thermos.cli.main.xml [32m[1m 1 passed in 0.19 seconds [0m [1m== test session starts ===[0m platform linux2 -- Python 2.7.6 -- py-1.4.26 -- pytest-2.6.4 -- /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/bin/python2.7 plugins: cov, timeout [1m collecting 0 items[0m[1m collecting 1 items[0m[1m collecting 2 items[0m[1m collected 2 items [0m src/test/python/apache/thermos/cli/commands/test_import.py::test_imports [32mPASSED[0m src/test/python/apache/thermos/cli/commands/test_simplerun.py - /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/thermos/cli/commands/test_simplerun.py::test_simplerun [32mPASSED[0m generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/src.test.python.apache.thermos.cli.commands.commands.xml [32m[1m 2 passed in 0.23 seconds [0m [1m== test session starts ===[0m platform linux2 -- Python 2.7.6 -- py-1.4.26 -- pytest-2.6.4 -- /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/bin/python2.7 plugins: cov, timeout [1m collecting 0 items[0m[1m collecting 0 items / 1 errors[0m[1m collected 0 items / 1 errors [0m = ERRORS = ERROR collecting src/test/python/apache/thermos/monitoring/test_disk.py src/test/python/apache/thermos/monitoring/test_disk.py:19: in module [1mfrom twitter.common.quantity import Amount, Data[0m [1m[31mE ImportError: No module named quantity[0m generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/src.test.python.apache.thermos.monitoring.test_disk.xml [1m[31m 1 error in 0.02 seconds =[0m src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS src.test.python.apache.thermos.cli.commands.commands . SUCCESS src.test.python.apache.thermos.cli.common . SUCCESS src.test.python.apache.thermos.cli.main . SUCCESS src.test.python.apache.thermos.common.test_pathspec . SUCCESS src.test.python.apache.thermos.monitoring.test_disk . FAILURE FAILURE [31m FAILURE[0m I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On March 26, 2015, 1:33 a.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32515/ --- (Updated March 26, 2015, 1:33 a.m.) Review request for Aurora, Kevin Sweeney and Zameer Manji. Repository: aurora Description --- This is currently unwired and its only test is marked flaky. Diffs - 3rdparty/python/requirements.txt ee30136c9224a85b65a93185ec12a86d7051e354 src/main/python/apache/thermos/monitoring/BUILD a7864d4e490784fef04582d4986c2fd121947c9d src/main/python/apache/thermos/monitoring/disk.py ccf6d6aafe893836e72e179cc1a8010a1ac6ac7f src/test/python/apache/thermos/monitoring/test_disk.py e1373234feba08ab881179af0cbf6b7ed326cc45 Diff:
Re: Review Request 32515: Kill inotify disk collector.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32515/ --- (Updated March 26, 2015, 1:55 a.m.) Review request for Aurora, Kevin Sweeney and Zameer Manji. Changes --- Add missing twitter.common.quantity for test_disk. Repository: aurora Description --- This is currently unwired and its only test is marked flaky. Diffs (updated) - 3rdparty/python/requirements.txt ee30136c9224a85b65a93185ec12a86d7051e354 src/main/python/apache/thermos/monitoring/BUILD a7864d4e490784fef04582d4986c2fd121947c9d src/main/python/apache/thermos/monitoring/disk.py ccf6d6aafe893836e72e179cc1a8010a1ac6ac7f src/test/python/apache/thermos/monitoring/BUILD 09deebb786ab3c9f4d7b88211c3f583cdc5ac9a9 src/test/python/apache/thermos/monitoring/test_disk.py e1373234feba08ab881179af0cbf6b7ed326cc45 Diff: https://reviews.apache.org/r/32515/diff/ Testing --- Thanks, Brian Wickman
Re: Review Request 32515: Kill inotify disk collector.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32515/#review77854 --- Master (68d2e47) is red with this patch. ./build-support/jenkins/build.sh src.test.python.apache.aurora.client.factory . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS src.test.python.apache.aurora.common.test_aurora_job_key . SUCCESS src.test.python.apache.aurora.common.test_cluster . SUCCESS src.test.python.apache.aurora.common.test_cluster_option . SUCCESS src.test.python.apache.aurora.common.test_clusters . SUCCESS src.test.python.apache.aurora.common.test_http_signaler . SUCCESS src.test.python.apache.aurora.common.test_pex_version . SUCCESS src.test.python.apache.aurora.common.test_shellify . SUCCESS src.test.python.apache.aurora.common.test_transport . SUCCESS src.test.python.apache.aurora.config.test_base . SUCCESS src.test.python.apache.aurora.config.test_constraint_parsing . SUCCESS src.test.python.apache.aurora.config.test_loader . SUCCESS src.test.python.apache.aurora.config.test_thrift . SUCCESS src.test.python.apache.aurora.executor.common.announcer . SUCCESS src.test.python.apache.aurora.executor.common.directory_sandbox . SUCCESS src.test.python.apache.aurora.executor.common.executor_detector . SUCCESS src.test.python.apache.aurora.executor.common.executor_timeout . SUCCESS src.test.python.apache.aurora.executor.common.health_checker . SUCCESS src.test.python.apache.aurora.executor.common.kill_manager . SUCCESS src.test.python.apache.aurora.executor.common.path_detector . SUCCESS src.test.python.apache.aurora.executor.common.status_checker . SUCCESS src.test.python.apache.aurora.executor.common.task_info . SUCCESS src.test.python.apache.aurora.executor.executor_base . SUCCESS src.test.python.apache.aurora.executor.executor_vars . SUCCESS src.test.python.apache.aurora.executor.gc_executor . FAILURE src.test.python.apache.aurora.executor.status_manager . SUCCESS src.test.python.apache.aurora.executor.thermos_task_runner . SUCCESS src.test.python.apache.thermos.cli.commands.commands . SUCCESS src.test.python.apache.thermos.cli.common . SUCCESS src.test.python.apache.thermos.cli.main . SUCCESS src.test.python.apache.thermos.common.test_pathspec . SUCCESS src.test.python.apache.thermos.core.test_runner_integration . SUCCESS src.test.python.apache.thermos.monitoring.test_disk . SUCCESS FAILURE [31m FAILURE[0m I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On March 26, 2015, 1:55 a.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32515/ --- (Updated March 26, 2015, 1:55 a.m.) Review request for Aurora, Kevin Sweeney and Zameer Manji.
