[GitHub] bahir pull request #41: [BAHIR-102] Initial support of Cloudant Query with p...

2017-04-10 Thread emlaver
Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/41#discussion_r110706772 --- Diff: sql-cloudant/README.md --- @@ -62,6 +62,8 @@ cloudant.protocol|https|protocol to use to transfer data: http or https cloudant.host||cloudant

[GitHub] bahir pull request #41: [BAHIR-102] Initial support of Cloudant Query with p...

2017-04-10 Thread emlaver
Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/41#discussion_r110706837 --- Diff: sql-cloudant/README.md --- @@ -62,6 +62,8 @@ cloudant.protocol|https|protocol to use to transfer data: http or https cloudant.host||cloudant

[GitHub] bahir pull request #41: [BAHIR-102] Initial support of Cloudant Query with p...

2017-04-10 Thread emlaver
Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/41#discussion_r110697369 --- Diff: sql-cloudant/README.md --- @@ -62,6 +62,8 @@ cloudant.protocol|https|protocol to use to transfer data: http or https cloudant.host||cloudant

[GitHub] bahir issue #40: [BAHIR-101] updates to sql-cloudant readme and python examp...

2017-04-06 Thread emlaver
Github user emlaver commented on the issue: https://github.com/apache/bahir/pull/40 @lresende Ok, no problem, I'll make sure to open a new JIRA for the next one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] bahir pull request #45: [WIP] [BAHIR-110] Implement _changes API for non-str...

2017-07-11 Thread emlaver
Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/45#discussion_r126801183 --- Diff: sql-cloudant/README.md --- @@ -52,39 +51,71 @@ Here each subsequent configuration overrides the previous one. Thus, configurati

[GitHub] bahir pull request #45: [WIP] [BAHIR-110] Implement _changes API for non-str...

2017-07-11 Thread emlaver
Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/45#discussion_r126801128 --- Diff: sql-cloudant/README.md --- @@ -52,39 +51,71 @@ Here each subsequent configuration overrides the previous one. Thus, configurati

[GitHub] bahir pull request #45: [WIP] [BAHIR-110] Implement _changes API for non-str...

2017-07-11 Thread emlaver
Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/45#discussion_r126801090 --- Diff: sql-cloudant/README.md --- @@ -31,15 +31,14 @@ The `--packages` argument can also be used with `bin/spark-submit`. Submit a job in Python

[GitHub] bahir pull request #45: [WIP] [BAHIR-110] Implement _changes API for non-str...

2017-07-11 Thread emlaver
Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/45#discussion_r126802018 --- Diff: sql-cloudant/README.md --- @@ -52,39 +51,71 @@ Here each subsequent configuration overrides the previous one. Thus, configurati

[GitHub] bahir pull request #45: [WIP] [BAHIR-110] Implement _changes API for non-str...

2017-07-11 Thread emlaver
Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/45#discussion_r126801991 --- Diff: sql-cloudant/README.md --- @@ -52,39 +51,71 @@ Here each subsequent configuration overrides the previous one. Thus, configurati

[GitHub] bahir pull request #45: [WIP] [BAHIR-110] Implement _changes API for non-str...

2017-07-18 Thread emlaver
Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/45#discussion_r127890607 --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/DefaultSource.scala --- @@ -98,29 +99,81 @@ class DefaultSource extends RelationProvider

[GitHub] bahir pull request #45: [WIP] [BAHIR-110] Implement _changes API for non-str...

2017-07-10 Thread emlaver
Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/45#discussion_r126444627 --- Diff: sql-cloudant/README.md --- @@ -31,15 +31,14 @@ The `--packages` argument can also be used with `bin/spark-submit`. Submit a job in Python

[GitHub] bahir pull request #45: [WIP] [BAHIR-110] Implement _changes API for non-str...

2017-07-10 Thread emlaver
Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/45#discussion_r126445660 --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/CloudantChangesConfig.scala --- @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache

[GitHub] bahir pull request #:

2017-07-24 Thread emlaver
Github user emlaver commented on the pull request: https://github.com/apache/bahir/commit/052abb4c64bb9da425ced6f1feeb0ab4fd52edfe#commitcomment-23271741 In sql-cloudant/README.md: In sql-cloudant/README.md on line 67: @mayya-sharipova All my stability and performance tests

[GitHub] bahir pull request #45: [WIP] [BAHIR-110] Implement _changes API for non-str...

2017-07-06 Thread emlaver
Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/45#discussion_r126073154 --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/CloudantAllDocsConfig.scala --- @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache

[GitHub] bahir pull request #45: [WIP] [BAHIR-110] Implement _changes API for non-str...

2017-07-06 Thread emlaver
Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/45#discussion_r126073211 --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/CloudantChangesConfig.scala --- @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache

[GitHub] bahir issue #45: [BAHIR-110] Implement _changes API for non-streaming receiv...

2017-06-19 Thread emlaver
Github user emlaver commented on the issue: https://github.com/apache/bahir/pull/45 @ckadner Updated tests to check if env. variables CLOUDANT_USER and CLOUDANT_PASSWORD exist. If they do not exist, all tests will be skipped in d57cfe7 --- If your project is set up for it, you

[GitHub] bahir issue #45: [BAHIR-110] Implement _changes API for non-streaming receiv...

2017-06-19 Thread emlaver
Github user emlaver commented on the issue: https://github.com/apache/bahir/pull/45 @yanglei99 Can you please review and add any comments? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] bahir pull request #45: [BAHIR-110] Implement _changes API for non-streaming...

2017-06-19 Thread emlaver
GitHub user emlaver opened a pull request: https://github.com/apache/bahir/pull/45 [BAHIR-110] Implement _changes API for non-streaming receiver See [JIRA-110](https://issues.apache.org/jira/browse/BAHIR-110) _What_ Add support for _changes API for non-streaming

[GitHub] bahir pull request #45: [BAHIR-110] Implement _changes API for non-streaming...

2017-06-19 Thread emlaver
Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/45#discussion_r122794148 --- Diff: sql-cloudant/src/test/scala/org/apache/bahir/cloudant/TestUtils.scala --- @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software

[GitHub] bahir pull request #45: [BAHIR-110] Implement _changes API for non-streaming...

2017-06-19 Thread emlaver
Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/45#discussion_r122797303 --- Diff: sql-cloudant/src/test/scala/org/apache/bahir/cloudant/TestUtils.scala --- @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software

[GitHub] bahir issue #51: [BAHIR-139] Force scala-maven-plugin to use java.version 1....

2017-10-13 Thread emlaver
Github user emlaver commented on the issue: https://github.com/apache/bahir/pull/51 +1 looks good ---

[GitHub] bahir issue #50: [BAHIR-123] Support latest version of play-json for sql-clo...

2017-09-28 Thread emlaver
Github user emlaver commented on the issue: https://github.com/apache/bahir/pull/50 @ckadner Tests are now passing. ---

[GitHub] bahir issue #50: [BAHIR-123] Support latest version of play-json for sql-clo...

2017-10-01 Thread emlaver
Github user emlaver commented on the issue: https://github.com/apache/bahir/pull/50 @ckadner Can I handle these `WARNING` messages in separate PR? I'll need to make changes in classes outside of this PR's scope. ---

[GitHub] bahir pull request #49: BAHIR-130

2017-08-24 Thread emlaver
Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/49#discussion_r135038265 --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/common/JsonStoreDataAccess.scala --- @@ -125,6 +125,19 @@ class JsonStoreDataAccess (config

[GitHub] bahir pull request #49: BAHIR-130

2017-08-24 Thread emlaver
Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/49#discussion_r135042956 --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/common/JsonStoreDataAccess.scala --- @@ -125,6 +125,19 @@ class JsonStoreDataAccess (config

[GitHub] bahir pull request #49: BAHIR-130

2017-08-24 Thread emlaver
Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/49#discussion_r135040382 --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/common/JsonStoreDataAccess.scala --- @@ -125,6 +125,19 @@ class JsonStoreDataAccess (config

[GitHub] bahir pull request #52: [BAHIR-140][sql-cloudant] Scala and Python notebook ...

2017-10-11 Thread emlaver
GitHub user emlaver opened a pull request: https://github.com/apache/bahir/pull/52 [BAHIR-140][sql-cloudant] Scala and Python notebook examples Added IPython and Markdown examples that run in IBM's Data Science Experience for the latest version of `sql-cloudant`. See

[GitHub] bahir pull request #57: [BAHIR-128][WIP] fix failing sql-cloudant test

2017-12-18 Thread emlaver
Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/57#discussion_r157533814 --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/internal/ChangesReceiver.scala --- @@ -39,56 +37,38 @@ class ChangesReceiver(config

[GitHub] bahir pull request #57: [BAHIR-128][WIP] fix failing sql-cloudant test

2017-12-18 Thread emlaver
Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/57#discussion_r157552982 --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/internal/ChangesReceiver.scala --- @@ -39,56 +37,38 @@ class ChangesReceiver(config

[GitHub] bahir pull request #57: [BAHIR-128][WIP] fix failing sql-cloudant test

2017-12-18 Thread emlaver
Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/57#discussion_r157553098 --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/CloudantChangesConfig.scala --- @@ -67,7 +67,8 @@ class CloudantChangesConfig(protocol

[GitHub] bahir pull request #59: [BAHIR-138] fix deprecated warnings in sql-cloudant

2017-12-15 Thread emlaver
GitHub user emlaver opened a pull request: https://github.com/apache/bahir/pull/59 [BAHIR-138] fix deprecated warnings in sql-cloudant _What_ Fix warnings in `DefaultSource` class, and in `CloudantStreaming` and `CloudantStreamingSelector` examples. _How_

[GitHub] bahir issue #57: [BAHIR-128][WIP] fix failing sql-cloudant test

2017-12-12 Thread emlaver
Github user emlaver commented on the issue: https://github.com/apache/bahir/pull/57 @ckadner I've got those changes on another branch that still needs a bit more testing. I'll open a PR with the separate ticket once it's ready. ---

[GitHub] bahir pull request #57: [BAHIR-128][WIP] fix failing sql-cloudant test

2017-12-07 Thread emlaver
GitHub user emlaver opened a pull request: https://github.com/apache/bahir/pull/57 [BAHIR-128][WIP] fix failing sql-cloudant test _What_ Fix test that's failing sporadically in sql-cloudant's `CloudantChangesDFSuite`. _How_ - Call stop in receiver when _changes

[GitHub] bahir pull request #57: [BAHIR-128][WIP] fix failing sql-cloudant test

2017-12-07 Thread emlaver
Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/57#discussion_r155699572 --- Diff: pom.xml --- @@ -458,7 +458,7 @@ .gitignore .repository/ - .idea

[GitHub] bahir issue #55: [BAHIR-104] Multi-topic MQTT DStream in Python is now a Pai...

2017-12-07 Thread emlaver
Github user emlaver commented on the issue: https://github.com/apache/bahir/pull/55 @ckadner Hi yes I will look into fixing this sporadically failing test. This shouldn't hold up this PR, right? ---

[GitHub] bahir pull request #57: [BAHIR-128][WIP] fix failing sql-cloudant test

2017-12-11 Thread emlaver
Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/57#discussion_r156123828 --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/common/ChangesRow.java --- @@ -0,0 +1,74 @@ +/* + * Copyright (c) 2017 IBM Cloudant

[GitHub] bahir pull request #57: [BAHIR-128][WIP] fix failing sql-cloudant test

2017-12-11 Thread emlaver
Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/57#discussion_r156206675 --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/common/ChangesRow.java --- @@ -0,0 +1,74 @@ +/* + * Copyright (c) 2017 IBM Cloudant

[GitHub] bahir pull request #60: [BAHIR-137][WIP] _changes feed receiver improvements

2018-01-05 Thread emlaver
Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/60#discussion_r160003061 --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/internal/ChangesReceiver.scala --- @@ -72,6 +72,7 @@ class ChangesReceiver(config

[GitHub] bahir pull request #60: [BAHIR-137][WIP] _changes feed receiver improvements

2018-01-05 Thread emlaver
Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/60#discussion_r160002892 --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/common/JsonStoreConfigManager.scala --- @@ -35,6 +35,7 @@ object JsonStoreConfigManager

[GitHub] bahir pull request #61: [BAHIR-154] Refactor sql-cloudant to use Cloudant's ...

2018-01-07 Thread emlaver
Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/61#discussion_r160077466 --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/CloudantConfig.scala --- @@ -16,34 +16,127 @@ */ package org.apache.bahir.cloudant

[GitHub] bahir pull request #61: [BAHIR-154] Refactor sql-cloudant to use Cloudant's ...

2018-01-07 Thread emlaver
Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/61#discussion_r160077474 --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/CloudantConfig.scala --- @@ -16,34 +16,127 @@ */ package org.apache.bahir.cloudant

[GitHub] bahir pull request #61: [BAHIR-154] Refactor sql-cloudant to use Cloudant's ...

2018-01-07 Thread emlaver
Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/61#discussion_r160077423 --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/CloudantConfig.scala --- @@ -16,34 +16,127 @@ */ package org.apache.bahir.cloudant

[GitHub] bahir pull request #61: [BAHIR-154] Refactor sql-cloudant to use Cloudant's ...

2018-01-07 Thread emlaver
Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/61#discussion_r160077433 --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/CloudantConfig.scala --- @@ -95,15 +189,49 @@ class CloudantConfig(val protocol: String, val

[GitHub] bahir pull request #61: [BAHIR-154] Refactor sql-cloudant to use Cloudant's ...

2018-01-07 Thread emlaver
Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/61#discussion_r160077412 --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/common/JsonStoreRDD.scala --- @@ -101,24 +105,24 @@ class JsonStoreRDD(sc: SparkContext

[GitHub] bahir pull request #61: [BAHIR-154] Refactor sql-cloudant to use Cloudant's ...

2018-01-04 Thread emlaver
Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/61#discussion_r159814009 --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/CloudantConfig.scala --- @@ -16,34 +16,127 @@ */ package org.apache.bahir.cloudant

[GitHub] bahir pull request #60: [BAHIR-137][WIP] _changes feed receiver improvements

2018-01-04 Thread emlaver
Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/60#discussion_r159722257 --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/internal/ChangesReceiver.scala --- @@ -72,6 +72,7 @@ class ChangesReceiver(config

[GitHub] bahir issue #61: [BAHIR-154] Refactor sql-cloudant to use Cloudant's java-cl...

2018-01-24 Thread emlaver
Github user emlaver commented on the issue: https://github.com/apache/bahir/pull/61 @lresende PR rebased and fixed error message after rebasing #60. ---

[GitHub] bahir issue #63: [BAHIR-138] fix deprecated warnings

2018-01-24 Thread emlaver
Github user emlaver commented on the issue: https://github.com/apache/bahir/pull/63 @lresende I've rebased. Once this one is merged, I'll rebase #61. ---

[GitHub] bahir pull request #61: [BAHIR-154] Refactor sql-cloudant to use Cloudant's ...

2018-01-11 Thread emlaver
Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/61#discussion_r161142828 --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/CloudantConfig.scala --- @@ -16,34 +16,127 @@ */ package org.apache.bahir.cloudant

[GitHub] bahir pull request #63: [BAHIR-138] fix deprecated warnings

2018-01-11 Thread emlaver
GitHub user emlaver opened a pull request: https://github.com/apache/bahir/pull/63 [BAHIR-138] fix deprecated warnings _What_ Fix deprecated warnings in `DefaultSource` class. _How_ - Imported `spark.implicits._` to convert Spark RDD to Dataset - Replaced

[GitHub] bahir pull request #60: [BAHIR-137][WIP] _changes feed receiver improvements

2017-12-20 Thread emlaver
GitHub user emlaver opened a pull request: https://github.com/apache/bahir/pull/60 [BAHIR-137][WIP] _changes feed receiver improvements _What_ - Added batchInterval option for tuning `_changes` receiver’s streaming batch interval - Throw a CloudantException if the final

[GitHub] bahir pull request #61: [BAHIR-154] Refactor sql-cloudant to use Cloudant's ...

2018-01-03 Thread emlaver
GitHub user emlaver opened a pull request: https://github.com/apache/bahir/pull/61 [BAHIR-154] Refactor sql-cloudant to use Cloudant's java-cloudant features _What_ Refactor sql-cloudant to use Cloudant's` java-cloudant` features _How_ - Use java-cloudant’s

[GitHub] bahir pull request #60: [BAHIR-137][WIP] _changes feed receiver improvements

2018-01-04 Thread emlaver
Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/60#discussion_r159669507 --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/common/JsonStoreConfigManager.scala --- @@ -35,6 +35,7 @@ object JsonStoreConfigManager

[GitHub] bahir pull request #75: [BAHIR-186]

2018-12-10 Thread emlaver
GitHub user emlaver opened a pull request: https://github.com/apache/bahir/pull/75 [BAHIR-186] _What_ Reduce the number of documents from 1967 to 100 in the n_flight.json test file. This should shorten the time to finish the `sql-cloudant` tests against the remote database