[GitHub] [helix] chenboat commented on issue #378: Make the reservoir used in ZkClientPathMonitor metric configurable.

chenboat commented on issue #378: Make the reservoir used in ZkClientPathMonitor metric configurable. URL: https://github.com/apache/helix/pull/378#issuecomment-523745879 This PR is ready to be merged, approved by [@jiajunwang].

[GitHub] [helix] chenboat commented on issue #378: Make the reservoir used in ZkClientPathMonitor metric configurable.

chenboat commented on issue #378: Make the reservoir used in ZkClientPathMonitor metric configurable. URL: https://github.com/apache/helix/pull/378#issuecomment-523745090 > @chenboat If you want this code merged, please review https://github.com/apache/helix/wiki/Pull-Request-Merge-Steps

[GitHub] [helix] narendly commented on a change in pull request #428: Add integration test for workflow ForceDelete

narendly commented on a change in pull request #428: Add integration test for workflow ForceDelete URL: https://github.com/apache/helix/pull/428#discussion_r316474110 ## File path: helix-core/src/test/java/org/apache/helix/integration/task/TestForceDeleteWorkflow.java ##

[GitHub] [helix] narendly commented on a change in pull request #428: Add integration test for workflow ForceDelete

narendly commented on a change in pull request #428: Add integration test for workflow ForceDelete URL: https://github.com/apache/helix/pull/428#discussion_r316473491 ## File path: helix-core/src/test/java/org/apache/helix/integration/task/TestForceDeleteWorkflow.java ##

[GitHub] [helix] narendly commented on a change in pull request #428: Add integration test for workflow ForceDelete

narendly commented on a change in pull request #428: Add integration test for workflow ForceDelete URL: https://github.com/apache/helix/pull/428#discussion_r316474328 ## File path: helix-core/src/test/java/org/apache/helix/integration/task/TestForceDeleteWorkflow.java ##

[GitHub] [helix] narendly commented on a change in pull request #428: Add integration test for workflow ForceDelete

narendly commented on a change in pull request #428: Add integration test for workflow ForceDelete URL: https://github.com/apache/helix/pull/428#discussion_r316473891 ## File path: helix-core/src/test/java/org/apache/helix/integration/task/TestForceDeleteWorkflow.java ##

[GitHub] [helix] narendly commented on a change in pull request #428: Add integration test for workflow ForceDelete

narendly commented on a change in pull request #428: Add integration test for workflow ForceDelete URL: https://github.com/apache/helix/pull/428#discussion_r316474928 ## File path: helix-core/src/test/java/org/apache/helix/integration/task/TestForceDeleteWorkflow.java ##

[GitHub] [helix] narendly commented on a change in pull request #428: Add integration test for workflow ForceDelete

narendly commented on a change in pull request #428: Add integration test for workflow ForceDelete URL: https://github.com/apache/helix/pull/428#discussion_r316473417 ## File path: helix-core/src/test/java/org/apache/helix/integration/task/TestForceDeleteWorkflow.java ##

[GitHub] [helix] narendly commented on a change in pull request #428: Add integration test for workflow ForceDelete

narendly commented on a change in pull request #428: Add integration test for workflow ForceDelete URL: https://github.com/apache/helix/pull/428#discussion_r316473724 ## File path: helix-core/src/test/java/org/apache/helix/integration/task/TestForceDeleteWorkflow.java ##

[GitHub] [helix] narendly commented on a change in pull request #428: Add integration test for workflow ForceDelete

narendly commented on a change in pull request #428: Add integration test for workflow ForceDelete URL: https://github.com/apache/helix/pull/428#discussion_r316474773 ## File path: helix-core/src/test/java/org/apache/helix/integration/task/TestForceDeleteWorkflow.java ##

[GitHub] [helix] narendly commented on a change in pull request #428: Add integration test for workflow ForceDelete

narendly commented on a change in pull request #428: Add integration test for workflow ForceDelete URL: https://github.com/apache/helix/pull/428#discussion_r316473628 ## File path: helix-core/src/test/java/org/apache/helix/integration/task/TestForceDeleteWorkflow.java ##

[GitHub] [helix] narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes

narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r316466395 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZkBucketDataAccessor.java ## @@ -0,0 +1,178

[GitHub] [helix] narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes

narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r316464968 ## File path: helix-core/src/main/java/org/apache/helix/BucketDataAccessor.java ## @@ -0,0 +1,35 @@ +package

[GitHub] [helix] narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes

narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r316464643 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZkBucketDataAccessor.java ## @@ -0,0 +1,178

[GitHub] [helix] narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes

narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r316464533 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/DummySerializer.java ## @@ -0,0 +1,44 @@

[GitHub] [helix] narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes

narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r316463980 ## File path: helix-core/src/main/java/org/apache/helix/BucketDataAccessor.java ## @@ -0,0 +1,35 @@ +package

[GitHub] [helix] narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes

narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r316463776 ## File path: helix-core/src/main/java/org/apache/helix/BucketDataAccessor.java ## @@ -0,0 +1,35 @@ +package

[GitHub] [helix] narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes

narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r316463090 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZkBucketDataAccessor.java ## @@ -0,0 +1,178

[GitHub] [helix] narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes

narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r316462672 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZNRecordJacksonSerializer.java ## @@ -0,0

[GitHub] [helix] narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes

narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r316462448 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZNRecordJacksonSerializer.java ## @@ -0,0

[GitHub] [helix] narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes

narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r316462448 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZNRecordJacksonSerializer.java ## @@ -0,0

[GitHub] [helix] narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes

narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r316462111 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/DummySerializer.java ## @@ -0,0 +1,44 @@

[GitHub] [helix] narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes

narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r316462111 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/DummySerializer.java ## @@ -0,0 +1,44 @@

[GitHub] [helix] narendly closed pull request #430: Rebase from master

narendly closed pull request #430: Rebase from master URL: https://github.com/apache/helix/pull/430 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [helix] narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes

narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r316454197 ## File path: helix-core/src/main/java/org/apache/helix/BucketDataAccessor.java ## @@ -0,0 +1,35 @@ +package

[GitHub] [helix] narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes

narendly commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r316453600 ## File path: helix-core/src/main/java/org/apache/helix/BucketDataAccessor.java ## @@ -0,0 +1,35 @@ +package

[GitHub] [helix] narendly commented on issue #426: Add BucketDataAccessor for large writes

narendly commented on issue #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#issuecomment-523690602 I will create a new PR since we aren't able to rebase. This is an automated

[GitHub] [helix] narendly edited a comment on issue #426: Add BucketDataAccessor for large writes

narendly edited a comment on issue #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#issuecomment-523690602 I will create a new PR since we aren't able to rebase from master This is

[GitHub] [helix] narendly opened a new pull request #430: Rebase from master

narendly opened a new pull request #430: Rebase from master URL: https://github.com/apache/helix/pull/430 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [helix] narendly closed pull request #429: Rebase commits from master into wagedRebalancer

narendly closed pull request #429: Rebase commits from master into wagedRebalancer URL: https://github.com/apache/helix/pull/429 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [helix] narendly opened a new pull request #429: Rebase commits from master into wagedRebalancer

narendly opened a new pull request #429: Rebase commits from master into wagedRebalancer URL: https://github.com/apache/helix/pull/429 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [helix] i3wangyi commented on a change in pull request #425: Rest - Clean up /namespaces/default/* when default helix name space is set

i3wangyi commented on a change in pull request #425: Rest - Clean up /namespaces/default/* when default helix name space is set URL: https://github.com/apache/helix/pull/425#discussion_r315961082 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #426: Add BucketDataAccessor for large writes

i3wangyi commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r316427888 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZkBucketDataAccessor.java ## @@ -0,0 +1,178

[GitHub] [helix] i3wangyi commented on a change in pull request #426: Add BucketDataAccessor for large writes

i3wangyi commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r316422052 ## File path: helix-core/src/main/java/org/apache/helix/BucketDataAccessor.java ## @@ -0,0 +1,35 @@ +package

[GitHub] [helix] i3wangyi commented on a change in pull request #426: Add BucketDataAccessor for large writes

i3wangyi commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r316421757 ## File path: helix-core/src/main/java/org/apache/helix/BucketDataAccessor.java ## @@ -0,0 +1,35 @@ +package

[GitHub] [helix] i3wangyi commented on a change in pull request #426: Add BucketDataAccessor for large writes

i3wangyi commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r316426327 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZkBucketDataAccessor.java ## @@ -0,0 +1,178

[GitHub] [helix] i3wangyi commented on a change in pull request #426: Add BucketDataAccessor for large writes

i3wangyi commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r316421353 ## File path: helix-core/src/main/java/org/apache/helix/BucketDataAccessor.java ## @@ -0,0 +1,35 @@ +package

[GitHub] [helix] i3wangyi commented on a change in pull request #426: Add BucketDataAccessor for large writes

i3wangyi commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r316429326 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZNRecordJacksonSerializer.java ## @@ -0,0

[GitHub] [helix] i3wangyi commented on a change in pull request #426: Add BucketDataAccessor for large writes

i3wangyi commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r316428656 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZNRecordJacksonSerializer.java ## @@ -0,0

[GitHub] [helix] i3wangyi commented on a change in pull request #426: Add BucketDataAccessor for large writes

i3wangyi commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r316427165 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZkBucketDataAccessor.java ## @@ -0,0 +1,178

[GitHub] [helix] jiajunwang commented on a change in pull request #422: Redefine the hard/soft constraints

jiajunwang commented on a change in pull request #422: Redefine the hard/soft constraints URL: https://github.com/apache/helix/pull/422#discussion_r316404083 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/constraints/SoftConstraint.java

[GitHub] [helix] alirezazamani opened a new pull request #428: Add integration test for workflow forcedelete and inspect the forcedelete logic

alirezazamani opened a new pull request #428: Add integration test for workflow forcedelete and inspect the forcedelete logic URL: https://github.com/apache/helix/pull/428 ### Issues - [x] My PR addresses the following Helix issues and references them in the PR title: Issue #385

[GitHub] [helix] i3wangyi commented on a change in pull request #422: Redefine the hard/soft constraints

i3wangyi commented on a change in pull request #422: Redefine the hard/soft constraints URL: https://github.com/apache/helix/pull/422#discussion_r316374689 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/constraints/SoftConstraint.java

[GitHub] [helix] jiajunwang commented on a change in pull request #426: Add BucketDataAccessor for large writes

jiajunwang commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r316367785 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZNRecordJacksonSerializer.java ## @@ -0,0

[GitHub] [helix] jiajunwang commented on a change in pull request #426: Add BucketDataAccessor for large writes

jiajunwang commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r316371410 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZkBucketDataAccessor.java ## @@ -0,0

[GitHub] [helix] jiajunwang commented on a change in pull request #426: Add BucketDataAccessor for large writes

jiajunwang commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r316364421 ## File path: helix-core/src/main/java/org/apache/helix/BucketDataAccessor.java ## @@ -0,0 +1,35 @@ +package

[GitHub] [helix] jiajunwang commented on a change in pull request #426: Add BucketDataAccessor for large writes

jiajunwang commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r316367663 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZNRecordJacksonSerializer.java ## @@ -0,0

[GitHub] [helix] jiajunwang commented on a change in pull request #426: Add BucketDataAccessor for large writes

jiajunwang commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r316364919 ## File path: helix-core/src/main/java/org/apache/helix/BucketDataAccessor.java ## @@ -0,0 +1,35 @@ +package

[GitHub] [helix] jiajunwang commented on a change in pull request #426: Add BucketDataAccessor for large writes

jiajunwang commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r316372056 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZkBucketDataAccessor.java ## @@ -0,0

[GitHub] [helix] jiajunwang commented on a change in pull request #426: Add BucketDataAccessor for large writes

jiajunwang commented on a change in pull request #426: Add BucketDataAccessor for large writes URL: https://github.com/apache/helix/pull/426#discussion_r316366382 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/DummySerializer.java ## @@ -0,0 +1,44 @@

[GitHub] [helix] i3wangyi commented on a change in pull request #422: Redefine the hard/soft constraints

i3wangyi commented on a change in pull request #422: Redefine the hard/soft constraints URL: https://github.com/apache/helix/pull/422#discussion_r316373193 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/constraints/SoftConstraint.java

[GitHub] [helix] jiajunwang commented on a change in pull request #422: Redefine the hard/soft constraints

jiajunwang commented on a change in pull request #422: Redefine the hard/soft constraints URL: https://github.com/apache/helix/pull/422#discussion_r316363236 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/constraints/SoftConstraint.java

[GitHub] [helix] jiajunwang commented on a change in pull request #378: Make the reservoir used in ZkClientPathMonitor metric configurable.

jiajunwang commented on a change in pull request #378: Make the reservoir used in ZkClientPathMonitor metric configurable. URL: https://github.com/apache/helix/pull/378#discussion_r316358839 ## File path: