[GitHub] [helix] pkuwm commented on a change in pull request #557: Add instance capacity gauge

2019-11-01 Thread GitBox
pkuwm commented on a change in pull request #557: Add instance capacity gauge URL: https://github.com/apache/helix/pull/557#discussion_r341796629 ## File path: helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java ## @@ -367,22 +367,28 @@

[GitHub] [helix] pkuwm commented on a change in pull request #557: Add instance capacity gauge

2019-11-01 Thread GitBox
pkuwm commented on a change in pull request #557: Add instance capacity gauge URL: https://github.com/apache/helix/pull/557#discussion_r341796662 ## File path: helix-core/src/main/java/org/apache/helix/monitoring/mbeans/dynamicMBeans/DynamicMBeanProvider.java ## @@ -103,7

[GitHub] [helix] pkuwm opened a new pull request #557: Add instance capacity gauge

2019-11-01 Thread GitBox
pkuwm opened a new pull request #557: Add instance capacity gauge URL: https://github.com/apache/helix/pull/557 ### Issues - [x] My PR addresses the following Helix issues and references them in the PR description: Implements one part of #539 : InstanceCapacityGauge

[GitHub] [helix] narendly opened a new pull request #564: Avoid redundant writes to metadata store in AssignmentMetadataStore

2019-11-01 Thread GitBox
narendly opened a new pull request #564: Avoid redundant writes to metadata store in AssignmentMetadataStore URL: https://github.com/apache/helix/pull/564 ### Issues - [x] My PR addresses the following Helix issues and references them in the PR description: Fixes #562

[GitHub] [helix] narendly merged pull request #548: Add max capacity usage metric for instance monitor.

2019-11-01 Thread GitBox
narendly merged pull request #548: Add max capacity usage metric for instance monitor. URL: https://github.com/apache/helix/pull/548 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [helix] pkuwm edited a comment on issue #548: Add max capacity usage metric for instance monitor.

2019-11-01 Thread GitBox
pkuwm edited a comment on issue #548: Add max capacity usage metric for instance monitor. URL: https://github.com/apache/helix/pull/548#issuecomment-548992171 This PR is ready to be merged, approved by @jiajunwang ``` We need to monitor instance's max utilization in purpose of

[GitHub] [helix] pkuwm edited a comment on issue #548: Add max capacity usage metric for instance monitor.

2019-11-01 Thread GitBox
pkuwm edited a comment on issue #548: Add max capacity usage metric for instance monitor. URL: https://github.com/apache/helix/pull/548#issuecomment-548992171 This PR is ready to be merged, approved by @jiajunwang ``` We need to monitor instance utilization in purpose of

[GitHub] [helix] pkuwm commented on issue #548: Add max capacity usage metric for instance monitor.

2019-11-01 Thread GitBox
pkuwm commented on issue #548: Add max capacity usage metric for instance monitor. URL: https://github.com/apache/helix/pull/548#issuecomment-548992171 This PR is ready to be merged, approved by @jiajunwang ``` We need to monitor instance utilization in purpose of understanding what

[GitHub] [helix] pkuwm commented on a change in pull request #548: Add max capacity usage metric for instance monitor.

2019-11-01 Thread GitBox
pkuwm commented on a change in pull request #548: Add max capacity usage metric for instance monitor. URL: https://github.com/apache/helix/pull/548#discussion_r341789870 ## File path: helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java ##

[GitHub] [helix] jiajunwang commented on a change in pull request #548: Add max capacity usage metric for instance monitor.

2019-11-01 Thread GitBox
jiajunwang commented on a change in pull request #548: Add max capacity usage metric for instance monitor. URL: https://github.com/apache/helix/pull/548#discussion_r341789492 ## File path: helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java

[GitHub] [helix] narendly commented on a change in pull request #534: Draft proposal of method signature for ZK custom serializer

2019-11-01 Thread GitBox
narendly commented on a change in pull request #534: Draft proposal of method signature for ZK custom serializer URL: https://github.com/apache/helix/pull/534#discussion_r341783440 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZkBaseDataAccessor.java

[GitHub] [helix] narendly commented on a change in pull request #516: Implement the propertyStore read endpoint

2019-11-01 Thread GitBox
narendly commented on a change in pull request #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#discussion_r341776904 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/service/PropertyStoreService.java ## @@

[GitHub] [helix] pkuwm commented on a change in pull request #548: Add max capacity usage metric for instance monitor.

2019-11-01 Thread GitBox
pkuwm commented on a change in pull request #548: Add max capacity usage metric for instance monitor. URL: https://github.com/apache/helix/pull/548#discussion_r341769988 ## File path: helix-core/src/main/java/org/apache/helix/monitoring/mbeans/InstanceMonitor.java ## @@

[GitHub] [helix] i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint

2019-11-01 Thread GitBox
i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#discussion_r341769814 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/service/PropertyStoreService.java ## @@

[GitHub] [helix] pkuwm commented on issue #548: Add max capacity usage metric for instance monitor.

2019-11-01 Thread GitBox
pkuwm commented on issue #548: Add max capacity usage metric for instance monitor. URL: https://github.com/apache/helix/pull/548#issuecomment-548968334 Resolved all comments. Thanks again @jiajunwang This is an automated

[GitHub] [helix] pkuwm commented on a change in pull request #548: Add max capacity usage metric for instance monitor.

2019-11-01 Thread GitBox
pkuwm commented on a change in pull request #548: Add max capacity usage metric for instance monitor. URL: https://github.com/apache/helix/pull/548#discussion_r341762604 ## File path: helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java ##

[GitHub] [helix] pkuwm commented on a change in pull request #548: Add max capacity usage metric for instance monitor.

2019-11-01 Thread GitBox
pkuwm commented on a change in pull request #548: Add max capacity usage metric for instance monitor. URL: https://github.com/apache/helix/pull/548#discussion_r341762306 ## File path: helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java ##

[GitHub] [helix] pkuwm commented on a change in pull request #548: Add max capacity usage metric for instance monitor.

2019-11-01 Thread GitBox
pkuwm commented on a change in pull request #548: Add max capacity usage metric for instance monitor. URL: https://github.com/apache/helix/pull/548#discussion_r341762932 ## File path: helix-core/src/main/java/org/apache/helix/monitoring/mbeans/InstanceMonitor.java ## @@

[GitHub] [helix] pkuwm commented on a change in pull request #548: Add max capacity usage metric for instance monitor.

2019-11-01 Thread GitBox
pkuwm commented on a change in pull request #548: Add max capacity usage metric for instance monitor. URL: https://github.com/apache/helix/pull/548#discussion_r341762986 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #516: Implement the propertyStore read endpoint

2019-11-01 Thread GitBox
narendly commented on a change in pull request #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#discussion_r341761973 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/service/PropertyStoreService.java ## @@

[GitHub] [helix] jiajunwang commented on a change in pull request #548: Add max capacity usage metric for instance monitor.

2019-11-01 Thread GitBox
jiajunwang commented on a change in pull request #548: Add max capacity usage metric for instance monitor. URL: https://github.com/apache/helix/pull/548#discussion_r341756481 ## File path: helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java

[GitHub] [helix] jiajunwang commented on a change in pull request #548: Add max capacity usage metric for instance monitor.

2019-11-01 Thread GitBox
jiajunwang commented on a change in pull request #548: Add max capacity usage metric for instance monitor. URL: https://github.com/apache/helix/pull/548#discussion_r341749020 ## File path: helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java

[GitHub] [helix] jiajunwang commented on a change in pull request #548: Add max capacity usage metric for instance monitor.

2019-11-01 Thread GitBox
jiajunwang commented on a change in pull request #548: Add max capacity usage metric for instance monitor. URL: https://github.com/apache/helix/pull/548#discussion_r341748528 ## File path: helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java

[GitHub] [helix] jiajunwang commented on a change in pull request #548: Add max capacity usage metric for instance monitor.

2019-11-01 Thread GitBox
jiajunwang commented on a change in pull request #548: Add max capacity usage metric for instance monitor. URL: https://github.com/apache/helix/pull/548#discussion_r341750466 ## File path: helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java

[GitHub] [helix] jiajunwang commented on a change in pull request #548: Add max capacity usage metric for instance monitor.

2019-11-01 Thread GitBox
jiajunwang commented on a change in pull request #548: Add max capacity usage metric for instance monitor. URL: https://github.com/apache/helix/pull/548#discussion_r341746626 ## File path: helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java

[GitHub] [helix] jiajunwang commented on a change in pull request #548: Add max capacity usage metric for instance monitor.

2019-11-01 Thread GitBox
jiajunwang commented on a change in pull request #548: Add max capacity usage metric for instance monitor. URL: https://github.com/apache/helix/pull/548#discussion_r341751162 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #548: Add max capacity usage metric for instance monitor.

2019-11-01 Thread GitBox
jiajunwang commented on a change in pull request #548: Add max capacity usage metric for instance monitor. URL: https://github.com/apache/helix/pull/548#discussion_r341744331 ## File path: helix-core/src/main/java/org/apache/helix/monitoring/mbeans/InstanceMonitor.java ##

[GitHub] [helix] i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint

2019-11-01 Thread GitBox
i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#discussion_r341744391 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/service/PropertyStoreService.java ## @@

[GitHub] [helix] jiajunwang commented on a change in pull request #548: Add max capacity usage metric for instance monitor.

2019-11-01 Thread GitBox
jiajunwang commented on a change in pull request #548: Add max capacity usage metric for instance monitor. URL: https://github.com/apache/helix/pull/548#discussion_r341742997 ## File path: helix-core/src/main/java/org/apache/helix/monitoring/mbeans/InstanceMonitor.java ##

[GitHub] [helix] narendly edited a comment on issue #534: Draft proposal of method signature for ZK custom serializer

2019-11-01 Thread GitBox
narendly edited a comment on issue #534: Draft proposal of method signature for ZK custom serializer URL: https://github.com/apache/helix/pull/534#issuecomment-548932224 @i3wangyi Also, let's create a branch off the tip of master and work against that branch since this PR itself is not

[GitHub] [helix] narendly commented on issue #534: Draft proposal of method signature for ZK custom serializer

2019-11-01 Thread GitBox
narendly commented on issue #534: Draft proposal of method signature for ZK custom serializer URL: https://github.com/apache/helix/pull/534#issuecomment-548932224 @i3wangyi Also, let's create a branch off the tip of master and work against that branch since this PR itself is not complete

[GitHub] [helix] narendly commented on a change in pull request #516: Implement the propertyStore read endpoint

2019-11-01 Thread GitBox
narendly commented on a change in pull request #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#discussion_r341730398 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/service/PropertyStoreService.java ## @@

[GitHub] [helix] i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint

2019-11-01 Thread GitBox
i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#discussion_r341714270 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/service/PropertyStoreService.java ## @@

[GitHub] [helix] pkuwm commented on issue #559: Fix formula incorrection in the comment for measuring baseline divergence

2019-11-01 Thread GitBox
pkuwm commented on issue #559: Fix formula incorrection in the comment for measuring baseline divergence URL: https://github.com/apache/helix/pull/559#issuecomment-548913131 This PR is ready to be merged, approved by @jiajunwang Commit message: ``` Fix incorrect formula in the

[GitHub] [helix] narendly commented on issue #562: AssignmentMetadataStore should skip updating if the new version is identical to the old one

2019-11-01 Thread GitBox
narendly commented on issue #562: AssignmentMetadataStore should skip updating if the new version is identical to the old one URL: https://github.com/apache/helix/issues/562#issuecomment-548896856 Ack. This is an automated

[GitHub] [helix] jiajunwang commented on issue #563: Improve the WAGED rebalancer calculating speed.

2019-11-01 Thread GitBox
jiajunwang commented on issue #563: Improve the WAGED rebalancer calculating speed. URL: https://github.com/apache/helix/issues/563#issuecomment-548687590 1. Potential algorithm inefficiency because of the max utilization calculating. 2. The rebalancer should skip all calculations

[GitHub] [helix] jiajunwang opened a new issue #563: Improve the WAGED rebalancer calculating speed.

2019-11-01 Thread GitBox
jiajunwang opened a new issue #563: Improve the WAGED rebalancer calculating speed. URL: https://github.com/apache/helix/issues/563 During our recent tests, we notice the new WAGED rebalancer calculating is not fast enough. This issue is for tracking all the performance tests and

[GitHub] [helix] jiajunwang commented on issue #562: AssignmentMetadataStore should skip updating if the new version is identical to the old one

2019-11-01 Thread GitBox
jiajunwang commented on issue #562: AssignmentMetadataStore should skip updating if the new version is identical to the old one URL: https://github.com/apache/helix/issues/562#issuecomment-548680497 @narendly Could you please help with this issue? Thanks.

[GitHub] [helix] jiajunwang opened a new issue #562: AssignmentMetadataStore should skip updating if the new version is identical to the old one

2019-11-01 Thread GitBox
jiajunwang opened a new issue #562: AssignmentMetadataStore should skip updating if the new version is identical to the old one URL: https://github.com/apache/helix/issues/562 Currently, our AssignmentMetadataStore always update to ZK on any new version of assignment data. This is not