[GitHub] [helix] narendly opened a new pull request #629: Add close() to ClusterSetup to avoid ZkClient leak

narendly opened a new pull request #629: Add close() to ClusterSetup to avoid ZkClient leak URL: https://github.com/apache/helix/pull/629 ### Issues - [x] My PR addresses the following Helix issues and references them in the PR description: Fixes #628 628 ###

[GitHub] [helix] narendly opened a new issue #628: ClusterSetup needs a close() method

narendly opened a new issue #628: ClusterSetup needs a close() method URL: https://github.com/apache/helix/issues/628 ClusterSetup is a helper class that's used for cluster-related operations. This class is missing a close() method users could call to prevent ZkClient/ZkConnection leak.

[GitHub] [helix] narendly opened a new issue #627: ClusterConfig.setInstanceCapacityKeys does not allow removal of keys

narendly opened a new issue #627: ClusterConfig.setInstanceCapacityKeys does not allow removal of keys URL: https://github.com/apache/helix/issues/627 ``` /** * Set the required Instance Capacity Keys. * @param capacityKeys */ public void

[GitHub] [helix] i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint

i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#discussion_r349400055 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/PropertyStoreAccessor.java

[GitHub] [helix] i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint

i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#discussion_r349400122 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/ServerContext.java ## @@ -46,9 +48,9 @@

[GitHub] [helix] i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint

i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#discussion_r349400191 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/PropertyStoreAccessor.java

[GitHub] [helix] i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint

i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#discussion_r349399924 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/PropertyStoreAccessor.java

[GitHub] [helix] i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint

i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#discussion_r349398874 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/PropertyStoreAccessor.java

[GitHub] [helix] i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint

i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#discussion_r349398685 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/AbstractResource.java ## @@

[GitHub] [helix] i3wangyi commented on issue #516: Implement the propertyStore read endpoint

i3wangyi commented on issue #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#issuecomment-557318468 > > > Why this PR contains customized serializer change? I would suggest to separate the PR. 1 for customized serializer change and another for

[GitHub] [helix] dasahcc commented on issue #516: Implement the propertyStore read endpoint

dasahcc commented on issue #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#issuecomment-557316739 > > Why this PR contains customized serializer change? I would suggest to separate the PR. 1 for customized serializer change and another for

[GitHub] [helix] dasahcc commented on issue #611: Add REST API endpoints for WAGED Rebalancer

dasahcc commented on issue #611: Add REST API endpoints for WAGED Rebalancer URL: https://github.com/apache/helix/pull/611#issuecomment-557315662 @narendly Have you updated the PR? This is an automated message from the Apache

[GitHub] [helix] i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint

i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#discussion_r349262606 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/PropertyStoreAccessor.java

[GitHub] [helix] zhangmeng916 commented on issue #600: add Helix cloud interface and implementation skeleton methods

zhangmeng916 commented on issue #600: add Helix cloud interface and implementation skeleton methods URL: https://github.com/apache/helix/pull/600#issuecomment-557224337 This PR is ready to be merged, approved by @dasahcc final commit message: Add Helix cloud interface and

[GitHub] [helix] i3wangyi commented on issue #516: Implement the propertyStore read endpoint

i3wangyi commented on issue #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#issuecomment-557223057 > Why this PR contains customized serializer change? I would suggest to separate the PR. 1 for customized serializer change and another for

[GitHub] [helix] dasahcc commented on issue #609: OnlineOffline model only works up to 0.6.9

dasahcc commented on issue #609: OnlineOffline model only works up to 0.6.9 URL: https://github.com/apache/helix/issues/609#issuecomment-557219730 @esarkissian-rythmos Thanks for the suggestion. Actually, we tried docker images for controllers and participants. The only leftover is

[GitHub] [helix] zhangmeng916 commented on a change in pull request #600: add Helix cloud interface and implementation skeleton methods

zhangmeng916 commented on a change in pull request #600: add Helix cloud interface and implementation skeleton methods URL: https://github.com/apache/helix/pull/600#discussion_r349253596 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java

[GitHub] [helix] zhangmeng916 commented on a change in pull request #600: add Helix cloud interface and implementation skeleton methods

zhangmeng916 commented on a change in pull request #600: add Helix cloud interface and implementation skeleton methods URL: https://github.com/apache/helix/pull/600#discussion_r349252836 ## File path: helix-core/pom.xml ## @@ -159,6 +159,12 @@ under the License.

[GitHub] [helix] zhangmeng916 commented on a change in pull request #600: add Helix cloud interface and implementation skeleton methods

zhangmeng916 commented on a change in pull request #600: add Helix cloud interface and implementation skeleton methods URL: https://github.com/apache/helix/pull/600#discussion_r349252730 ## File path: