[GitHub] [helix] narendly commented on issue #393: Remove all unused imports

2019-08-30 Thread GitBox
narendly commented on issue #393: Remove all unused imports URL: https://github.com/apache/helix/pull/393#issuecomment-526780538 @leesf I checked out your remote branch and ran the test. See the following: [INFO] Tests run: 838, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3

[GitHub] [helix] narendly commented on issue #393: Remove all unused imports

2019-08-30 Thread GitBox
narendly commented on issue #393: Remove all unused imports URL: https://github.com/apache/helix/pull/393#issuecomment-526772076 @leesf Thanks for the reminder! I'll run it today and update! This is an automated message from t

[GitHub] [helix] narendly commented on issue #393: Remove all unused imports

2019-08-14 Thread GitBox
narendly commented on issue #393: Remove all unused imports URL: https://github.com/apache/helix/pull/393#issuecomment-521517784 I'm tracking. I'll run the tests when I get a minute and update this PR :) This is an automated m

[GitHub] [helix] narendly commented on issue #393: Remove all unused imports

2019-08-08 Thread GitBox
narendly commented on issue #393: Remove all unused imports URL: https://github.com/apache/helix/pull/393#issuecomment-519786065 @leesf So I see a lot of failed tests, and this is concerning. But since all the changes are just removing redundant imports, I am convinced that it's the issue

[GitHub] [helix] narendly commented on issue #393: remove all unused imports

2019-08-08 Thread GitBox
narendly commented on issue #393: remove all unused imports URL: https://github.com/apache/helix/pull/393#issuecomment-519570671 Thanks for the PR. We try to stick to the guidelines to keep the quality up, so could you please follow https://github.com/apache/helix/wiki/Pull-Request-Guideli